)]}'
{"nova/tests/functional/api/openstack/placement/gabbits/resource-classes.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5337964c44be7d0f1c0806b48b10eaace14e9927","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a430d35_7ff505eb","line":7,"updated":"2017-02-08 17:29:25.000000000","message":"oh, interesting, what happens if you don\u0027t add this?","commit_id":"c31d779d3520e2f3850213fc2890cd4935f27188"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"475c2b5725393961f24e35e382e153cbdb85b8b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a430d35_45cdae5c","line":7,"in_reply_to":"1a430d35_37aabc85","updated":"2017-02-09 16:22:55.000000000","message":"I guess the json formatter doesn\u0027t execute unless we request json, that might not be what we want here actually, can we default the request to json if its missing?","commit_id":"c31d779d3520e2f3850213fc2890cd4935f27188"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"dd7a68d5cb2fa7d98dcc21afab163aa04670a87d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a430d35_4dd95083","line":7,"in_reply_to":"1a430d35_45cdae5c","updated":"2017-02-09 17:53:25.000000000","message":"webob formats response codes based on the accept header and defaults to something other than application/json\n\nThis is _good_ and _correct_ so I don\u0027t think we should change it. It\u0027s proper HTTP to use accept and content-type headers.","commit_id":"c31d779d3520e2f3850213fc2890cd4935f27188"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"68b004221a71afc609f2c786871e56474558650f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a430d35_3dd50db9","line":7,"in_reply_to":"1a430d35_4dd95083","updated":"2017-02-09 20:13:05.000000000","message":"Yes. I am wondering if it is a good idea to make it default in placement request. \nIs it possible to introduce accept type as application/json in header based on content-type for placement ? may be somewhere in context middleware.","commit_id":"c31d779d3520e2f3850213fc2890cd4935f27188"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"1214beaebe8387228ae864016c97ab1b2c39a498","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a430d35_37aabc85","line":7,"in_reply_to":"1a430d35_7ff505eb","updated":"2017-02-08 21:46:04.000000000","message":"Test fails with assertion error for response_json_paths saying mismatch error, cannot compare with None.\n\nWsgi does not set json formatter if client has accept type other than application/json\nhttps://github.com/Pylons/webob/blob/040e1a3c4e5d6ec6f3264c4ddd60308583b65a91/webob/exc.py#L329","commit_id":"c31d779d3520e2f3850213fc2890cd4935f27188"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2b10bb27f95fa3d2246d607430532fe39303b48e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"defaults:"},{"line_number":5,"context_line":"    request_headers:"},{"line_number":6,"context_line":"        x-auth-token: admin"},{"line_number":7,"context_line":"        accept: application/json"},{"line_number":8,"context_line":"        OpenStack-API-Version: placement latest"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"tests:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a1ff146_a8e17e9c","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":32},"updated":"2017-03-16 09:45:08.000000000","message":"yea accpet type not default with json.","commit_id":"95e1da06e7d407cbdb427b19946021c8a95324d0"}]}