)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"7448cce019042577be49b5f54d3590bccfe469d0","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    * live_migration_permit_auto_converge"},{"line_number":447,"context_line":"\"\"\"),"},{"line_number":448,"context_line":"    cfg.BoolOpt(\u0027live_migration_permit_auto_converge\u0027,"},{"line_number":449,"context_line":"                default\u003dFalse,"},{"line_number":450,"context_line":"                help\u003d\"\"\""},{"line_number":451,"context_line":"This option allows nova to start live migration with auto converge on."},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_9968d689","line":449,"range":{"start_line":449,"start_character":15,"end_line":449,"end_character":29},"updated":"2017-02-09 19:33:23.000000000","message":"I think we can set this to True as well, this might decrease the live migration abortion chances as well.","commit_id":"59d057819f86d7f242f3a413d13b1fa677491a15"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cceb215d6d8412758afa9e5376088904acec0c54","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    * live_migration_permit_auto_converge"},{"line_number":447,"context_line":"\"\"\"),"},{"line_number":448,"context_line":"    cfg.BoolOpt(\u0027live_migration_permit_auto_converge\u0027,"},{"line_number":449,"context_line":"                default\u003dFalse,"},{"line_number":450,"context_line":"                help\u003d\"\"\""},{"line_number":451,"context_line":"This option allows nova to start live migration with auto converge on."},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_7825d8c0","line":449,"range":{"start_line":449,"start_character":15,"end_line":449,"end_character":29},"in_reply_to":"1a430d35_9968d689","updated":"2017-02-10 10:24:33.000000000","message":"We could, but that does affect the guest, it makes it run slower. It would be nice to avoid that by default.","commit_id":"59d057819f86d7f242f3a413d13b1fa677491a15"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"7448cce019042577be49b5f54d3590bccfe469d0","unresolved":false,"context_lines":[{"line_number":6335,"context_line":"                             completion_timeout, instance\u003dinstance)"},{"line_number":6336,"context_line":"                    force_triggered \u003d False"},{"line_number":6337,"context_line":""},{"line_number":6338,"context_line":"                    if is_post_copy_enabled:"},{"line_number":6339,"context_line":"                        LOG.debug(\"Attempting to trigger post_copy \""},{"line_number":6340,"context_line":"                                  \"due to completion timeout.\")"},{"line_number":6341,"context_line":"                        force_triggered \u003d libvirt_migrate.\\"},{"line_number":6342,"context_line":"                            trigger_postcopy_switch("},{"line_number":6343,"context_line":"                                guest, instance, migration)"},{"line_number":6344,"context_line":""},{"line_number":6345,"context_line":"                    if (not force_triggered and"},{"line_number":6346,"context_line":"                        CONF.libvirt.\\"},{"line_number":6347,"context_line":"                            live_migration_force_on_completion_timeout):"},{"line_number":6348,"context_line":"                        self.live_migration_force_complete(instance)"},{"line_number":6349,"context_line":"                        force_triggered \u003d True"},{"line_number":6350,"context_line":""},{"line_number":6351,"context_line":"                    if not force_triggered:"},{"line_number":6352,"context_line":"                        LOG.debug(\"Attempting to abort live-migration \""},{"line_number":6353,"context_line":"                                  \"due to completion timeout.\")"},{"line_number":6354,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_de29648b","line":6351,"range":{"start_line":6338,"start_character":20,"end_line":6351,"end_character":43},"updated":"2017-02-09 19:33:23.000000000","message":"nit: I think we can have all these conditions in else if statements.","commit_id":"59d057819f86d7f242f3a413d13b1fa677491a15"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cceb215d6d8412758afa9e5376088904acec0c54","unresolved":false,"context_lines":[{"line_number":6335,"context_line":"                             completion_timeout, instance\u003dinstance)"},{"line_number":6336,"context_line":"                    force_triggered \u003d False"},{"line_number":6337,"context_line":""},{"line_number":6338,"context_line":"                    if is_post_copy_enabled:"},{"line_number":6339,"context_line":"                        LOG.debug(\"Attempting to trigger post_copy \""},{"line_number":6340,"context_line":"                                  \"due to completion timeout.\")"},{"line_number":6341,"context_line":"                        force_triggered \u003d libvirt_migrate.\\"},{"line_number":6342,"context_line":"                            trigger_postcopy_switch("},{"line_number":6343,"context_line":"                                guest, instance, migration)"},{"line_number":6344,"context_line":""},{"line_number":6345,"context_line":"                    if (not force_triggered and"},{"line_number":6346,"context_line":"                        CONF.libvirt.\\"},{"line_number":6347,"context_line":"                            live_migration_force_on_completion_timeout):"},{"line_number":6348,"context_line":"                        self.live_migration_force_complete(instance)"},{"line_number":6349,"context_line":"                        force_triggered \u003d True"},{"line_number":6350,"context_line":""},{"line_number":6351,"context_line":"                    if not force_triggered:"},{"line_number":6352,"context_line":"                        LOG.debug(\"Attempting to abort live-migration \""},{"line_number":6353,"context_line":"                                  \"due to completion timeout.\")"},{"line_number":6354,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_b806701e","line":6351,"range":{"start_line":6338,"start_character":20,"end_line":6351,"end_character":43},"in_reply_to":"1a430d35_de29648b","updated":"2017-02-10 10:24:33.000000000","message":"We can\u0027t because of how force_triggered is updated inside each of the if statements.","commit_id":"59d057819f86d7f242f3a413d13b1fa677491a15"}]}