)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9bbf6b2e09d4d24d4c235f2a1c0297e8b3fcd197","unresolved":false,"context_lines":[{"line_number":7,"context_line":"conf: Add neutron.floating_pool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron network driver in nova has subverted the meaning of the"},{"line_number":10,"context_line":"\u0027floating_pool_name\u0027 value for its own cruel and unusual purposes. This"},{"line_number":11,"context_line":"cannot be allowed to stand. Give neutron its own config option, stopping"},{"line_number":12,"context_line":"it from stealing others and allowing us to eventually retire the"},{"line_number":13,"context_line":"venerable \u0027floating_pool_name\u0027 option. A warning is included to alert"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_cbc77945","line":10,"range":{"start_line":10,"start_character":1,"end_line":10,"end_character":19},"updated":"2017-03-27 11:54:48.000000000","message":"Do you mean default_floating_pool? This doesn\u0027t seem consistent with the reno note","commit_id":"4485391d2fc80674526d0202657b7b5c427b4a1a"}],"nova/conf/neutron.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ac99fbce7da4c1165181553f53bbd58dc6494e08","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027ovs_bridge\u0027,"},{"line_number":53,"context_line":"         default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"         help\u003d\"\"\""},{"line_number":55,"context_line":"Default name for the Open vSwitch integration bridge."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Specifies the name of an integration bridge interface used by OpenvSwitch."},{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_f509b132","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":20},"updated":"2017-02-21 05:39:53.000000000","message":"unrelated changes","commit_id":"309723ef92d1e6d6d767e0f98e1937013c6908f4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01edf344e59f00b7d77fc9d501827eae158f58b8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027ovs_bridge\u0027,"},{"line_number":53,"context_line":"         default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"         help\u003d\"\"\""},{"line_number":55,"context_line":"Default name for the Open vSwitch integration bridge."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Specifies the name of an integration bridge interface used by OpenvSwitch."},{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_0ee739e5","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":20},"in_reply_to":"da36d5c6_f509b132","updated":"2017-03-07 10:33:39.000000000","message":"Not totally unrelated - it\u0027s related to the below option and I clarified the text to tie it into the below. I should have noted this in the commit message though","commit_id":"309723ef92d1e6d6d767e0f98e1937013c6908f4"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"fbc8d0b63348fe63d5f65b57c3335a27bc638b9c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027ovs_bridge\u0027,"},{"line_number":53,"context_line":"         default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"         help\u003d\"\"\""},{"line_number":55,"context_line":"Default name for the Open vSwitch integration bridge."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Specifies the name of an integration bridge interface used by OpenvSwitch."},{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_1c081a91","line":59,"range":{"start_line":55,"start_character":0,"end_line":59,"end_character":20},"in_reply_to":"da36d5c6_f509b132","updated":"2017-03-01 23:14:54.000000000","message":"Yup, but let\u0027s take it in.","commit_id":"309723ef92d1e6d6d767e0f98e1937013c6908f4"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9bbf6b2e09d4d24d4c235f2a1c0297e8b3fcd197","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Specifies the name of an integration bridge interface used by OpenvSwitch."},{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_6bd4ed20","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":21},"updated":"2017-03-27 11:54:48.000000000","message":"response or information?\n\nNova makes the port binding request, Neutron gives us the response.","commit_id":"4485391d2fc80674526d0202657b7b5c427b4a1a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9bbf6b2e09d4d24d4c235f2a1c0297e8b3fcd197","unresolved":false,"context_lines":[{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"},{"line_number":63,"context_line":"        help\u003d\"\"\""},{"line_number":64,"context_line":"Default name for the floating IP pool."}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_6bbd0dd7","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":29},"updated":"2017-03-27 11:54:48.000000000","message":"Doesn\u0027t default_floating_pool seem like a better name?","commit_id":"4485391d2fc80674526d0202657b7b5c427b4a1a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc9cb57eca696fe896558792afc854b5e5e3876f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"This option is only used if Neutron does not specify the OVS bridge name in"},{"line_number":59,"context_line":"port binding requests."},{"line_number":60,"context_line":"\"\"\"),"},{"line_number":61,"context_line":"    cfg.StrOpt(\u0027floating_pool\u0027,"},{"line_number":62,"context_line":"        default\u003d\u0027nova\u0027,"},{"line_number":63,"context_line":"        help\u003d\"\"\""},{"line_number":64,"context_line":"Default name for the floating IP pool."}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_a26faf90","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":29},"in_reply_to":"ffe62b97_6bbd0dd7","updated":"2017-03-27 14:29:26.000000000","message":"default_floating_pool sounds good to me","commit_id":"4485391d2fc80674526d0202657b7b5c427b4a1a"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"377f30af44405063d97b8bb01f203c7c9931d12b","unresolved":false,"context_lines":[{"line_number":1923,"context_line":"            LOG.warning(_LW(\"Config option \u0027default_floating_pool\u0027 is set to \""},{"line_number":1924,"context_line":"                            \"a non-default value. Falling back to this value \""},{"line_number":1925,"context_line":"                            \"for now but this behavior will change in a \""},{"line_number":1926,"context_line":"                            \"future release. You should unset this value0 \""},{"line_number":1927,"context_line":"                            \"and set the \u0027CONF.neutron.floating_pool\u0027 option \""},{"line_number":1928,"context_line":"                            \"instead.\"))"},{"line_number":1929,"context_line":"            return CONF.default_floating_pool"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_a4284134","line":1926,"range":{"start_line":1926,"start_character":67,"end_line":1926,"end_character":73},"updated":"2017-02-08 18:58:13.000000000","message":"typo?","commit_id":"86e4289ffbee446dc24a14e88693fcfddbf89949"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f41095ef5fe7f446ab9b0f55ec5f7b808994737e","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"                            \"instead.\"))"},{"line_number":1931,"context_line":"            return CONF.default_floating_pool"},{"line_number":1932,"context_line":""},{"line_number":1933,"context_line":"        return CONF.neutron.floating_pool"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"    def allocate_floating_ip(self, context, pool\u003dNone):"},{"line_number":1936,"context_line":"        \"\"\"Add a floating IP to a project from a pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_3a0e248c","line":1933,"range":{"start_line":1933,"start_character":8,"end_line":1933,"end_character":41},"updated":"2017-03-13 10:41:56.000000000","message":"having default value as same as default_floating_pool does  not break any user.","commit_id":"2e4f53ecb224449c3cac36444f8bc0319a6e8f15"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1c3a76bc890ec39033e22757007c9b45b0c474fb","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"                            \"a non-default value. Falling back to this value \""},{"line_number":1927,"context_line":"                            \"for now but this behavior will change in a \""},{"line_number":1928,"context_line":"                            \"future release. You should unset this value \""},{"line_number":1929,"context_line":"                            \"and set the \u0027CONF.neutron.floating_pool\u0027 option \""},{"line_number":1930,"context_line":"                            \"instead.\"))"},{"line_number":1931,"context_line":"            return CONF.default_floating_pool"},{"line_number":1932,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_4a98a01a","line":1929,"range":{"start_line":1929,"start_character":55,"end_line":1929,"end_character":68},"updated":"2017-03-29 08:36:36.000000000","message":"you missed to change this - default_floating_pool","commit_id":"3d0c3e1756f9245ec41a912de4b5188e59588991"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dd6ac43c34300bac6d020251bcb71fc5774d1569","unresolved":false,"context_lines":[{"line_number":1926,"context_line":"                            \"a non-default value. Falling back to this value \""},{"line_number":1927,"context_line":"                            \"for now but this behavior will change in a \""},{"line_number":1928,"context_line":"                            \"future release. You should unset this value \""},{"line_number":1929,"context_line":"                            \"and set the \u0027CONF.neutron.floating_pool\u0027 option \""},{"line_number":1930,"context_line":"                            \"instead.\"))"},{"line_number":1931,"context_line":"            return CONF.default_floating_pool"},{"line_number":1932,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_89cea460","line":1929,"range":{"start_line":1929,"start_character":55,"end_line":1929,"end_character":68},"in_reply_to":"ffe62b97_4a98a01a","updated":"2017-03-29 14:38:31.000000000","message":"Done","commit_id":"3d0c3e1756f9245ec41a912de4b5188e59588991"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"05e4e1a7c11d9474cd74af2b466148bd9dd58148","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"        TODO(stephenfin): Remove this helper function in Queens, opting to"},{"line_number":1921,"context_line":"        use the [neutron] option only."},{"line_number":1922,"context_line":"        \"\"\""},{"line_number":1923,"context_line":"        if CONF.default_floating_pool !\u003d \u0027nova\u0027:"},{"line_number":1924,"context_line":"            LOG.warning(_LW(\"Config option \u0027default_floating_pool\u0027 is set to \""},{"line_number":1925,"context_line":"                            \"a non-default value. Falling back to this value \""},{"line_number":1926,"context_line":"                            \"for now but this behavior will change in a \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5ff73747_d0176e51","line":1923,"updated":"2017-05-03 11:39:58.000000000","message":"so... isn\u0027t the question really\n\nCONF.default_floating_pool !\u003d CONF.neutron.default_floating_pool\n\nAnd so there would be unexpected impacts going forward. Would it be better to use that as the match, and warn if they aren\u0027t the same, and that CONF.neutron.default_floating_pool should be updated to the value of CONF.default_floating_pool?","commit_id":"babb6f5f28c156a5f54af7434747a9848789b048"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"49c6d03d6cad3fc9a4ad232b8e4915e39b7e1231","unresolved":false,"context_lines":[{"line_number":1920,"context_line":"        TODO(stephenfin): Remove this helper function in Queens, opting to"},{"line_number":1921,"context_line":"        use the [neutron] option only."},{"line_number":1922,"context_line":"        \"\"\""},{"line_number":1923,"context_line":"        if CONF.default_floating_pool !\u003d \u0027nova\u0027:"},{"line_number":1924,"context_line":"            LOG.warning(_LW(\"Config option \u0027default_floating_pool\u0027 is set to \""},{"line_number":1925,"context_line":"                            \"a non-default value. Falling back to this value \""},{"line_number":1926,"context_line":"                            \"for now but this behavior will change in a \""}],"source_content_type":"text/x-python","patch_set":10,"id":"5ff73747_fb392bf2","line":1923,"in_reply_to":"5ff73747_d0176e51","updated":"2017-05-03 12:10:24.000000000","message":"If the option isn\u0027t included in a configuration file, CONF.default_floating_pool will always return the default. If we reworked this per above, it wouldn\u0027t be possible for users to delete the older config option (\u0027[DEFAULT] default_floating_pool\u0027) from their configuration file until the option was completely removed, at which point they would no longer get a hint to remove it. I figured it was better to give people a strong hint?","commit_id":"babb6f5f28c156a5f54af7434747a9848789b048"}],"releasenotes/notes/add-neutron-floating_pool-option-cba402c2de407b78.yaml":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9bbf6b2e09d4d24d4c235f2a1c0297e8b3fcd197","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``default_floating_pool`` option has been moved to the ``[neutron]``"},{"line_number":5,"context_line":"    group and renamed ``floating_pool``. An alias is provided but this will be"},{"line_number":6,"context_line":"    removed for neutron users in a future release. The existing"},{"line_number":7,"context_line":"    ``default_floating_pool`` option in ``[DEFAULT]`` is retained for"},{"line_number":8,"context_line":"    nova-network users."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_8ba85177","line":5,"range":{"start_line":5,"start_character":14,"end_line":5,"end_character":21},"updated":"2017-03-27 11:54:48.000000000","message":"Not sure I like the rename. I don\u0027t really get why.","commit_id":"4485391d2fc80674526d0202657b7b5c427b4a1a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1c3a76bc890ec39033e22757007c9b45b0c474fb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``default_floating_pool`` option has been moved to the ``[neutron]``"},{"line_number":5,"context_line":"    group. An alias is provided but this will be removed for neutron users in a"},{"line_number":6,"context_line":"    future release. The existing ``default_floating_pool`` option in"},{"line_number":7,"context_line":"    ``[DEFAULT]`` is retained for nova-network users."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_25210da0","line":6,"range":{"start_line":5,"start_character":11,"end_line":6,"end_character":19},"updated":"2017-03-29 08:36:36.000000000","message":"This is not very clear actually. can we mention something like-\n\nThis new options under [neutron] group is recommended to use by neutron users instead of one under default group. Currently nova fall back to old config options if that is configured explicitly which will not be case in future.","commit_id":"3d0c3e1756f9245ec41a912de4b5188e59588991"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"dd6ac43c34300bac6d020251bcb71fc5774d1569","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``default_floating_pool`` option has been moved to the ``[neutron]``"},{"line_number":5,"context_line":"    group. An alias is provided but this will be removed for neutron users in a"},{"line_number":6,"context_line":"    future release. The existing ``default_floating_pool`` option in"},{"line_number":7,"context_line":"    ``[DEFAULT]`` is retained for nova-network users."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_a9b3a8e8","line":6,"range":{"start_line":5,"start_character":11,"end_line":6,"end_character":19},"in_reply_to":"ffe62b97_25210da0","updated":"2017-03-29 14:38:31.000000000","message":"Done","commit_id":"3d0c3e1756f9245ec41a912de4b5188e59588991"}]}