)]}'
{"nova/conf/floating_ips.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"77067d0c9f1b4fec3c2b6994d4e8087adeaf169e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        deprecated_since\u003d\u002716.0.0\u0027,"},{"line_number":24,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":25,"context_line":"This option was used for two purposes: to set the floating IP pool name for"},{"line_number":26,"context_line":"nova-network and to do the same for neutron. nova-network is deprecated, as are"},{"line_number":27,"context_line":"any related configuration options. Users of neutron, meanwhile, should use the"},{"line_number":28,"context_line":"\u0027floating_pool\u0027 option in the \u0027[neutron]\u0027 group."},{"line_number":29,"context_line":"\"\"\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_3959d48e","line":26,"range":{"start_line":26,"start_character":76,"end_line":26,"end_character":79},"updated":"2017-02-15 20:31:59.000000000","message":"nit: if you keep the line length close to 75, it will render better.\nhttp://docs-draft.openstack.org/38/431038/1/check/gate-nova-docs-ubuntu-xenial/d80c9b6//doc/build/html/sample_config.html","commit_id":"64636a759949a377fdcf0ea6678edea9e650fee1"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"611b106cb324cf2beccf50dfeffb580ea296ecbe","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This option was used for two purposes: to set the floating IP pool name for"},{"line_number":26,"context_line":"nova-network and to do the same for neutron. nova-network is deprecated, as are"},{"line_number":27,"context_line":"any related configuration options. Users of neutron, meanwhile, should use the"},{"line_number":28,"context_line":"\u0027floating_pool\u0027 option in the \u0027[neutron]\u0027 group."},{"line_number":29,"context_line":"\"\"\","},{"line_number":30,"context_line":"        help\u003d\"\"\""},{"line_number":31,"context_line":"Default pool for floating IPs."}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_02ebfb78","line":28,"range":{"start_line":28,"start_character":1,"end_line":28,"end_character":14},"updated":"2017-03-27 14:40:58.000000000","message":"oops, and this bit.","commit_id":"cb051575eaf524186870887b87c75a92b6754163"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"8193942819dab7755bf9bfcbd30473975abf2ddd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"This option was used for two purposes: to set the floating IP pool name for"},{"line_number":26,"context_line":"nova-network and to do the same for neutron. nova-network is deprecated, as are"},{"line_number":27,"context_line":"any related configuration options. Users of neutron, meanwhile, should use the"},{"line_number":28,"context_line":"\u0027floating_pool\u0027 option in the \u0027[neutron]\u0027 group."},{"line_number":29,"context_line":"\"\"\","},{"line_number":30,"context_line":"        help\u003d\"\"\""},{"line_number":31,"context_line":"Default pool for floating IPs."}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_37484e85","line":28,"range":{"start_line":28,"start_character":1,"end_line":28,"end_character":14},"updated":"2017-03-28 13:14:52.000000000","message":"When your 2nd patch gets merged this will be default_floating_pool","commit_id":"2f57890d6c0bb1f5b7eba9567223a0b12e19d7bb"}],"releasenotes/notes/deprecate-more-nova-network-opts-a9f87c79f7d26438.yaml":[{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9a1aac39bcf9e1403561930aaff103526bd266dd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The following options, found in ``DEFAULT``, were only used for configuring"},{"line_number":5,"context_line":"    nova-network and are, like nova-network itself, now deprecated."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``default_floating_pool``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_3cb15ee2","line":5,"updated":"2017-03-01 23:13:22.000000000","message":"Nit: maybe add note from the deprecation line, about the neutron counterpart?","commit_id":"668b6d2c97d72cc40756d1921eabd799e9f7b942"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"275bd9e70d827a5788c9fe93d46be09b887010be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The following options, found in ``DEFAULT``, were only used for configuring"},{"line_number":5,"context_line":"    nova-network and are, like nova-network itself, now deprecated."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``default_floating_pool``"},{"line_number":8,"context_line":"    - ``ipv6_backend``"},{"line_number":9,"context_line":"    - ``firewall_driver``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_7ad97cf2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2017-03-13 10:45:24.000000000","message":"I feel this should go with some more description, It does not come under L4-5. As of now it is used for neutron also (even we have new config option for neutron).\n\nCan we add separate lines for this options saying, this is used for both and new option for neutron there so us that instead of this.","commit_id":"92022f5c533d02e9fd533db22c5b3b8630180f95"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c52866ca806dc096167c7889d00f1a46b446c767","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The following options, found in ``DEFAULT``, were only used for configuring"},{"line_number":5,"context_line":"    nova-network and are, like nova-network itself, now deprecated."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``default_floating_pool``"},{"line_number":8,"context_line":"    - ``ipv6_backend``"},{"line_number":9,"context_line":"    - ``firewall_driver``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_93e53b0a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"in_reply_to":"9a30ddce_7ad97cf2","updated":"2017-03-13 11:41:59.000000000","message":"I\u0027ve already covered this in [1] though. I was treating [1] as the sign to migrate neutron workloads across, and this as a sign that the now-\"nova network-only\" option was deprecated. Is this duplication? Possibly. Do I think that\u0027s a bad thing? Not really :)\n\n[1] https://review.openstack.org/#/c/431037/4/releasenotes/notes/add-neutron-floating_pool-option-cba402c2de407b78.yaml","commit_id":"92022f5c533d02e9fd533db22c5b3b8630180f95"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d9976af448e509f73bd175b909d8c9201525097f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The following options, found in ``DEFAULT``, were only used for configuring"},{"line_number":5,"context_line":"    nova-network and are, like nova-network itself, now deprecated."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``default_floating_pool``"},{"line_number":8,"context_line":"    - ``ipv6_backend``"},{"line_number":9,"context_line":"    - ``firewall_driver``"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a22e58a_0b8901cb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"in_reply_to":"9a30ddce_93e53b0a","updated":"2017-03-14 06:38:38.000000000","message":"I agree on new config for neutron but thats in same release which means ``default_floating_pool`` is still used by user for neutron also. \nIf we had separate options for nova-network and neutron earlier and made ``default_floating_pool`` for nova-network only in previous release that makes ``default_floating_pool`` as nova-network options only.","commit_id":"92022f5c533d02e9fd533db22c5b3b8630180f95"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ea589ea927dcb088e4564395995ca0e50a4eb018","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    nova-network and are, like nova-network itself, now deprecated."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    - ``default_floating_pool`` (neutron users should use the"},{"line_number":8,"context_line":"      ``neutron.floating_pool``)"},{"line_number":9,"context_line":"    - ``ipv6_backend``"},{"line_number":10,"context_line":"    - ``firewall_driver``"},{"line_number":11,"context_line":"    - ``metadata_host``"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_02d2dbd2","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":29},"updated":"2017-03-27 14:40:41.000000000","message":"This needs updating now.","commit_id":"cb051575eaf524186870887b87c75a92b6754163"}]}