)]}'
{"nova/tests/unit/fake_volume.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e92113dc9ba832e1a8e2778c0f72226d197217b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if snapshot is not None:"},{"line_number":39,"context_line":"            snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":40,"context_line":"        if volume_id is None:"},{"line_number":41,"context_line":"            volume_id \u003d str(fake_volume.volume_id)"},{"line_number":42,"context_line":"            fake_volume.volume_id \u003d fake_volume.volume_id + 1"},{"line_number":43,"context_line":"        self.vol \u003d {"},{"line_number":44,"context_line":"            \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":45,"context_line":"            \u0027deleted_at\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_3a6ebb96","line":42,"range":{"start_line":41,"start_character":12,"end_line":42,"end_character":61},"updated":"2017-02-13 03:21:58.000000000","message":"we should generate random uuid instead of incremental int\n\nvolume_id \u003d uuidutils.generate_uuid()","commit_id":"5f0858a8209c58d2b0eb5222cfcb17964608e745"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"199224510a81a7ae7aa6470fe894ed2742581443","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if snapshot is not None:"},{"line_number":39,"context_line":"            snapshot_id \u003d snapshot[\u0027id\u0027]"},{"line_number":40,"context_line":"        if volume_id is None:"},{"line_number":41,"context_line":"            volume_id \u003d str(fake_volume.volume_id)"},{"line_number":42,"context_line":"            fake_volume.volume_id \u003d fake_volume.volume_id + 1"},{"line_number":43,"context_line":"        self.vol \u003d {"},{"line_number":44,"context_line":"            \u0027created_at\u0027: timeutils.utcnow(),"},{"line_number":45,"context_line":"            \u0027deleted_at\u0027: None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_69bbfae5","line":42,"range":{"start_line":41,"start_character":12,"end_line":42,"end_character":61},"in_reply_to":"fa31d9ce_3a6ebb96","updated":"2017-02-13 13:36:17.000000000","message":"Should we? I was under the impression that the uuid field (line 47) is for that, and that volume_id is the incremental int id, like a SQL incremental index.","commit_id":"5f0858a8209c58d2b0eb5222cfcb17964608e745"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e92113dc9ba832e1a8e2778c0f72226d197217b","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":132,"context_line":"               volume_type\u003dNone, metadata\u003dNone, availability_zone\u003dNone,"},{"line_number":133,"context_line":"               **kwargs):"},{"line_number":134,"context_line":"        v \u003d fake_volume(size, name,"},{"line_number":135,"context_line":"                        description, None,"},{"line_number":136,"context_line":"                        snapshot, volume_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_1a2657ce","line":133,"range":{"start_line":133,"start_character":15,"end_line":133,"end_character":23},"updated":"2017-02-13 03:21:58.000000000","message":"do we need this, there is already another method for kwargs- create_with_kwargs","commit_id":"5f0858a8209c58d2b0eb5222cfcb17964608e745"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"199224510a81a7ae7aa6470fe894ed2742581443","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":132,"context_line":"               volume_type\u003dNone, metadata\u003dNone, availability_zone\u003dNone,"},{"line_number":133,"context_line":"               **kwargs):"},{"line_number":134,"context_line":"        v \u003d fake_volume(size, name,"},{"line_number":135,"context_line":"                        description, None,"},{"line_number":136,"context_line":"                        snapshot, volume_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_4969d68a","line":133,"range":{"start_line":133,"start_character":15,"end_line":133,"end_character":23},"in_reply_to":"fa31d9ce_1a2657ce","updated":"2017-02-13 13:36:17.000000000","message":"We do in following patches - when we stub this API in for Cinder, some code calls create with the image kwarg, which is not in the create kwargs.","commit_id":"5f0858a8209c58d2b0eb5222cfcb17964608e745"}]}