)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"04caf19aa5b3d97000d1c3e67611cca50e3914d7","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                node \u003d self.driver.get_available_nodes()[0]"},{"line_number":1469,"context_line":"                LOG.debug(_(\u0027No node specified, defaulting to %s\u0027), node)"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"            self._start_building(context, instance)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"            try:"},{"line_number":1474,"context_line":"                self._build_and_run_instance(context, instance, image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASX%2F%2F8gU%3D","line":1471,"updated":"2013-08-23 12:18:07.000000000","message":"his could raise a InstanceNotFound - I assume we should watch for that here as well, like in the old boot path.\n\nAlso I don\u0027t like how this is just a wrapper around _instance_update (with a log call), but only this update is special cased? If it bugs you like it does me (you\u0027re slightly OCD :) ) maybe you can just do _instance_update here and then remove the wrapper once we migrate to this path? Just a suggestion.","commit_id":"c0dc447e54ac83b0f5ec63b14f7b59fb13ba4dc5"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"e498c60d72057576c42a4ee8c65437bf9660e69a","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"                node \u003d self.driver.get_available_nodes()[0]"},{"line_number":1469,"context_line":"                LOG.debug(_(\u0027No node specified, defaulting to %s\u0027), node)"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"            self._start_building(context, instance)"},{"line_number":1472,"context_line":""},{"line_number":1473,"context_line":"            try:"},{"line_number":1474,"context_line":"                self._build_and_run_instance(context, instance, image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASX%2F%2F8H8%3D","line":1471,"in_reply_to":"AAAASX%2F%2F8gU%3D","updated":"2013-08-23 13:34:15.000000000","message":"Yep, I should wrap this in a try/except.\n\nYeah, I wasn\u0027t a big fan either so I\u0027ll move it here.","commit_id":"c0dc447e54ac83b0f5ec63b14f7b59fb13ba4dc5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3480e2ed4045ffb12b960f85432aa112189a38aa","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"                LOG.audit(_(\u0027Starting instance...\u0027), context\u003dcontext,"},{"line_number":1474,"context_line":"                      instance\u003dinstance)"},{"line_number":1475,"context_line":"                self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1476,"context_line":"                        vm_state\u003dvm_states.BUILDING, task_state\u003dNone,"},{"line_number":1477,"context_line":"                        expected_task_state\u003d(task_states.SCHEDULING, None))"},{"line_number":1478,"context_line":"            except exception.InstanceNotFound:"},{"line_number":1479,"context_line":"                msg \u003d _(\u0027Instance disappeared before build.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fqrg%3D","line":1476,"updated":"2013-08-31 16:43:06.000000000","message":"question - why is the task_state not SPAWNING here?","commit_id":"e4c1cc59373df94c7f22e0ae2693bd4f302ccd35"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"dc35c48005515100c8a7b991ff9fe8f6502dd072","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"                LOG.audit(_(\u0027Starting instance...\u0027), context\u003dcontext,"},{"line_number":1474,"context_line":"                      instance\u003dinstance)"},{"line_number":1475,"context_line":"                self._instance_update(context, instance[\u0027uuid\u0027],"},{"line_number":1476,"context_line":"                        vm_state\u003dvm_states.BUILDING, task_state\u003dNone,"},{"line_number":1477,"context_line":"                        expected_task_state\u003d(task_states.SCHEDULING, None))"},{"line_number":1478,"context_line":"            except exception.InstanceNotFound:"},{"line_number":1479,"context_line":"                msg \u003d _(\u0027Instance disappeared before build.\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fj9Q%3D","line":1476,"in_reply_to":"AAAASn%2F%2Fqrg%3D","updated":"2013-09-03 13:48:50.000000000","message":"It could be, but the task state goes through NETWORKING and BLOCK_DEVICE_MAPPING before it gets to SPAWNING below so it wouldn\u0027t last long.  This matches how it\u0027s done in the current code path.","commit_id":"e4c1cc59373df94c7f22e0ae2693bd4f302ccd35"}]}