)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"c9a71cbdd60374c219b8a411aacdfa62f735f346","unresolved":false,"context_lines":[{"line_number":1640,"context_line":"    def set_host_maintenance(self, context, host, mode):"},{"line_number":1641,"context_line":"        \"\"\"Start/Stop host maintenance window. On start, it triggers"},{"line_number":1642,"context_line":"        guest VMs evacuation.\"\"\""},{"line_number":1643,"context_line":"        raise _call_compute_message(self.db, \"host_maintenance_mode\", context,"},{"line_number":1644,"context_line":"                                    host\u003dhost, params\u003d{\"host\": host,"},{"line_number":1645,"context_line":"                                                       \"mode\": mode})"},{"line_number":1646,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F3Bo%3D","line":1643,"updated":"2012-02-23 01:23:52.000000000","message":"raise?","commit_id":"bcdaa1cced93d8086ddf1c3fe258c4511e43aece"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6001f1bd8be9ae6135602a6bf4484a319cc351e","unresolved":false,"context_lines":[{"line_number":1640,"context_line":"    def set_host_maintenance(self, context, host, mode):"},{"line_number":1641,"context_line":"        \"\"\"Start/Stop host maintenance window. On start, it triggers"},{"line_number":1642,"context_line":"        guest VMs evacuation.\"\"\""},{"line_number":1643,"context_line":"        raise _call_compute_message(self.db, \"host_maintenance_mode\", context,"},{"line_number":1644,"context_line":"                                    host\u003dhost, params\u003d{\"host\": host,"},{"line_number":1645,"context_line":"                                                       \"mode\": mode})"},{"line_number":1646,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F26g%3D","line":1643,"in_reply_to":"AAAAEn%2F%2F3Bo%3D","updated":"2012-02-23 10:33:45.000000000","message":"well spotted!","commit_id":"bcdaa1cced93d8086ddf1c3fe258c4511e43aece"}],"nova/virt/xenapi/host.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"a8ebbfe2a6e642c01974d772fba26e795f2957b9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                        new_host \u003d _host_find(ctxt, self._session, host,"},{"line_number":69,"context_line":"                                              self._session.get_xenapi_host())"},{"line_number":70,"context_line":"                        db.instance_update(ctxt,"},{"line_number":71,"context_line":"                                           instance.id, {\u0027host\u0027: new_host})"},{"line_number":72,"context_line":"                        migrations_counter \u003d migrations_counter + 1"},{"line_number":73,"context_line":"                        break"},{"line_number":74,"context_line":"                    except self.XenAPI.Failure:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F3BE%3D","line":71,"updated":"2012-02-23 01:33:18.000000000","message":"This looks very specific to pools, which not everyone uses.  Also, it feels like moving instances should go through the scheduler to find an appropriate new host.","commit_id":"bcdaa1cced93d8086ddf1c3fe258c4511e43aece"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f6001f1bd8be9ae6135602a6bf4484a319cc351e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                        new_host \u003d _host_find(ctxt, self._session, host,"},{"line_number":69,"context_line":"                                              self._session.get_xenapi_host())"},{"line_number":70,"context_line":"                        db.instance_update(ctxt,"},{"line_number":71,"context_line":"                                           instance.id, {\u0027host\u0027: new_host})"},{"line_number":72,"context_line":"                        migrations_counter \u003d migrations_counter + 1"},{"line_number":73,"context_line":"                        break"},{"line_number":74,"context_line":"                    except self.XenAPI.Failure:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAEn%2F%2F26c%3D","line":71,"in_reply_to":"AAAAEn%2F%2F3BE%3D","updated":"2012-02-23 10:33:45.000000000","message":"Yes this is very pools specific. I was thinking of refactoring this once the branch for xenapi live migration gets in, so that we can leverage that one instead. \nA first draft of the live migration branch is ready but it couldn\u0027t make for Essex (being too late). It will be pushed for review as soon as Folsom open, by which time this code will be refactored. Would this be good enough in the meantime?","commit_id":"bcdaa1cced93d8086ddf1c3fe258c4511e43aece"}]}