)]}'
{"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5f045ae06062e8f395be20418f025758ed157353","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    sr_rec \u003d session.call_xenapi(\"SR.get_record\", sr_ref)"},{"line_number":677,"context_line":"    sr_uuid \u003d sr_rec[\"uuid\"]"},{"line_number":678,"context_line":"    if sr_rec[\"type\"] not in [\"ext\", \"nfs\", \"ffs\"]:"},{"line_number":679,"context_line":"        raise exception.NovaException("},{"line_number":680,"context_line":"            _(\"Only file-based SRs (ext/NFS) are supported by this feature.\""},{"line_number":681,"context_line":"              \"  SR %(uuid)s is of type %(type)s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARn%2F%2Fv1A%3D","line":678,"updated":"2013-08-22 11:15:01.000000000","message":"Should this not be moved about the other return statement too? I guess an LVM SR might provide a path. Even it it doesn\u0027t it could in the future, and it all seems a bit dodgy.","commit_id":"1471f5be2cbda97250b3946299378b6b048c2337"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"fa7be28360e83ab2df67dbd0a91f0f07dcb53f51","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    sr_rec \u003d session.call_xenapi(\"SR.get_record\", sr_ref)"},{"line_number":677,"context_line":"    sr_uuid \u003d sr_rec[\"uuid\"]"},{"line_number":678,"context_line":"    if sr_rec[\"type\"] not in [\"ext\", \"nfs\", \"ffs\"]:"},{"line_number":679,"context_line":"        raise exception.NovaException("},{"line_number":680,"context_line":"            _(\"Only file-based SRs (ext/NFS) are supported by this feature.\""},{"line_number":681,"context_line":"              \"  SR %(uuid)s is of type %(type)s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARn%2F%2FvyI%3D","line":678,"in_reply_to":"AAAARn%2F%2Fv1A%3D","updated":"2013-08-22 11:36:25.000000000","message":"No; but I have removed \"ffs\" from this check.  If an SR provides a path, get_sr_path should return it.  Ffs will always supply a path and it doesn\u0027t make sense to use the default path for it, so only using the default for ext/nfs makes sense.","commit_id":"1471f5be2cbda97250b3946299378b6b048c2337"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5f045ae06062e8f395be20418f025758ed157353","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"    if CONF.use_cow_images and sr_type \u003d\u003d \u0027ext\u0027:"},{"line_number":1047,"context_line":"        new_vdi_ref \u003d _clone_vdi(session, cache_vdi_ref)"},{"line_number":1048,"context_line":"    elif sr_type \u003d\u003d \u0027ext\u0027:"},{"line_number":1049,"context_line":"        new_vdi_ref \u003d _safe_copy_vdi(session, sr_ref, instance, cache_vdi_ref)"},{"line_number":1050,"context_line":"    else:"},{"line_number":1051,"context_line":"        new_vdi_ref \u003d session.call_xenapi(\"VDI.copy\", cache_vdi_ref, sr_ref)"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARn%2F%2Fv1Y%3D","line":1049,"updated":"2013-08-22 11:15:01.000000000","message":"Can we raise a bug to investigate removing this, if we don\u0027t have one already.","commit_id":"1471f5be2cbda97250b3946299378b6b048c2337"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"fa7be28360e83ab2df67dbd0a91f0f07dcb53f51","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"    if CONF.use_cow_images and sr_type \u003d\u003d \u0027ext\u0027:"},{"line_number":1047,"context_line":"        new_vdi_ref \u003d _clone_vdi(session, cache_vdi_ref)"},{"line_number":1048,"context_line":"    elif sr_type \u003d\u003d \u0027ext\u0027:"},{"line_number":1049,"context_line":"        new_vdi_ref \u003d _safe_copy_vdi(session, sr_ref, instance, cache_vdi_ref)"},{"line_number":1050,"context_line":"    else:"},{"line_number":1051,"context_line":"        new_vdi_ref \u003d session.call_xenapi(\"VDI.copy\", cache_vdi_ref, sr_ref)"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAARn%2F%2Fvx8%3D","line":1049,"in_reply_to":"AAAARn%2F%2Fv1Y%3D","updated":"2013-08-22 11:36:25.000000000","message":"https://bugs.launchpad.net/nova/+bug/1215383","commit_id":"1471f5be2cbda97250b3946299378b6b048c2337"}]}