)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8f497785303b992ea0e7cd92ff1f38392cabdf63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-22 03:29:30 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: ensure that the vnc_password does not to be configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the vnc_password was not configured in the \u0027vmware\u0027 section"},{"line_number":10,"context_line":"the user was unable to access the VNC console."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAARn%2F%2Fva4%3D","line":7,"updated":"2013-08-22 13:45:50.000000000","message":"This isn\u0027t proper english. Can you fix it up?","commit_id":"0fe0b400d4ec0ba04c9851adf0a623dd641a29a0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2a5cbaaec2b7916f6ba660e0fc28c138eb14dd80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-22 03:29:30 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: ensure that the vnc_password does not to be configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the vnc_password was not configured in the \u0027vmware\u0027 section"},{"line_number":10,"context_line":"the user was unable to access the VNC console."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAARn%2F%2FvXA%3D","line":7,"in_reply_to":"AAAARn%2F%2Fva4%3D","updated":"2013-08-22 14:00:48.000000000","message":"Done","commit_id":"0fe0b400d4ec0ba04c9851adf0a623dd641a29a0"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"46e8ab6f224454753665d3ced5bcc95155501e80","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the user was unable to access the VNC console. The user would be"},{"line_number":11,"context_line":"requested to enter a password but all attempts would fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The \u0027nvc_password\u0027 was added as a workaround to the problem above."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The fix ensures that the VMware driver behaves like all of the other"},{"line_number":16,"context_line":"virt drivers when it comes to the VNC access, that is, the user will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAASn%2F%2FrsY%3D","line":13,"updated":"2013-08-30 22:12:58.000000000","message":"nit: vnc","commit_id":"3f6d21b21b1ca4b32ddf79449aa6bcb13e09fdf9"}],"etc/nova/nova.conf.sample":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f0a2723b8afc89b1a9fff544afc4b4f58c4d354","unresolved":false,"context_lines":[{"line_number":3160,"context_line":"# Total number of VNC ports (integer value)"},{"line_number":3161,"context_line":"#vnc_port_total\u003d10000"},{"line_number":3162,"context_line":""},{"line_number":3163,"context_line":"# DEPRECATED. VNC password (string value)"},{"line_number":3164,"context_line":"#vnc_password\u003d\u003cNone\u003e"},{"line_number":3165,"context_line":""},{"line_number":3166,"context_line":"# Whether to use linked clone (boolean value)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAASX%2F%2F6fY%3D","line":3163,"updated":"2013-08-23 20:06:05.000000000","message":"I\u0027d add also that the option is marked for removal in Icehouse, where the password-required access to the VNC console is no longer available. To disable it now the variable should be left to its default.","commit_id":"a328d241476bb5be2cc8576ce547e5916f637be6"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"83d078774e1033c2ec00257307a867def3a65914","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        self._create_vm()"},{"line_number":595,"context_line":"        vnc_dict \u003d self.conn.get_vnc_console(self.instance)"},{"line_number":596,"context_line":"        self.assertEquals(vnc_dict[\u0027host\u0027], \"ha-host\")"},{"line_number":597,"context_line":"        self.assertEquals(vnc_dict[\u0027port\u0027], 5910)"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    def test_get_vnc_console(self):"},{"line_number":600,"context_line":"        self.flags(vnc_password\u003d\u0027vmware\u0027, group\u003d\u0027vmware\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAASn%2F%2Fi1k%3D","line":597,"updated":"2013-09-03 17:03:08.000000000","message":"Shouldn\u0027t this assert that there is no password in the vnc_dict?","commit_id":"3d7343d4aa785404b9cc14ac0f1139fcc2d35c57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"83d078774e1033c2ec00257307a867def3a65914","unresolved":false,"context_lines":[{"line_number":602,"context_line":"        self._create_vm()"},{"line_number":603,"context_line":"        vnc_dict \u003d self.conn.get_vnc_console(self.instance)"},{"line_number":604,"context_line":"        self.assertEquals(vnc_dict[\u0027host\u0027], \"ha-host\")"},{"line_number":605,"context_line":"        self.assertEquals(vnc_dict[\u0027port\u0027], 5910)"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    def test_host_ip_addr(self):"},{"line_number":608,"context_line":"        self.assertEquals(self.conn.get_host_ip_addr(), \"test_url\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAASn%2F%2Fi1w%3D","line":605,"updated":"2013-09-03 17:03:08.000000000","message":"Shouldn\u0027t this verify that it actually set the password?","commit_id":"3d7343d4aa785404b9cc14ac0f1139fcc2d35c57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"65697f8a22193ca528cac957e45feb536bd933e7","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        vnc_dict \u003d self.conn.get_vnc_console(self.instance)"},{"line_number":611,"context_line":"        self.assertEquals(vnc_dict[\u0027host\u0027], \"ha-host\")"},{"line_number":612,"context_line":"        self.assertEquals(vnc_dict[\u0027port\u0027], cfg.CONF.vmware.vnc_port +"},{"line_number":613,"context_line":"                          fake_vm_id % cfg.CONF.vmware.vnc_port_total)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def test_host_ip_addr(self):"},{"line_number":616,"context_line":"        self.assertEquals(self.conn.get_host_ip_addr(), \"test_url\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FhWI%3D","line":613,"updated":"2013-09-03 20:46:08.000000000","message":"These two tests totally duplicate themselves if you don\u0027t check some distinguishing difference. I know that right now they exercise slightly different code, but I could remove/change your new changes to vm_utils and these would both continue to pass. Can\u0027t we do a bit better?","commit_id":"2331e763af1a9a10971eecb5c4105ed0c487cb1f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"81db9d9cf5caee85117ff644bd4d1d0a46785f03","unresolved":false,"context_lines":[{"line_number":610,"context_line":"        vnc_dict \u003d self.conn.get_vnc_console(self.instance)"},{"line_number":611,"context_line":"        self.assertEquals(vnc_dict[\u0027host\u0027], \"ha-host\")"},{"line_number":612,"context_line":"        self.assertEquals(vnc_dict[\u0027port\u0027], cfg.CONF.vmware.vnc_port +"},{"line_number":613,"context_line":"                          fake_vm_id % cfg.CONF.vmware.vnc_port_total)"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    def test_host_ip_addr(self):"},{"line_number":616,"context_line":"        self.assertEquals(self.conn.get_host_ip_addr(), \"test_url\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FhRY%3D","line":613,"in_reply_to":"AAAASn%2F%2FhWI%3D","updated":"2013-09-03 21:00:42.000000000","message":"i hope that i have addressed them better now.\nthe point of these tests is to check the value that will be returned to the calling function. - more specifically the host and the port.\nThe tests in vm_utils are code that is pushed to the vCenter.","commit_id":"2331e763af1a9a10971eecb5c4105ed0c487cb1f"}],"nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"65697f8a22193ca528cac957e45feb536bd933e7","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        result \u003d re.sub(r\u0027\\s+\u0027, \u0027\u0027, repr(result))"},{"line_number":270,"context_line":"        self.assertEqual(expected, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_get_vnc_config_spec_pasaword(self):"},{"line_number":273,"context_line":"        result \u003d self._test_get_vnc_config_spec(7, \u0027password\u0027)"},{"line_number":274,"context_line":"        expected \u003d \"\"\"{\u0027extraConfig\u0027: ["},{"line_number":275,"context_line":"                          {\u0027value\u0027: \u0027true\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FhV0%3D","line":272,"updated":"2013-09-03 20:46:08.000000000","message":"\"password\" is misspelled.","commit_id":"2331e763af1a9a10971eecb5c4105ed0c487cb1f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"81db9d9cf5caee85117ff644bd4d1d0a46785f03","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        result \u003d re.sub(r\u0027\\s+\u0027, \u0027\u0027, repr(result))"},{"line_number":270,"context_line":"        self.assertEqual(expected, result)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def test_get_vnc_config_spec_pasaword(self):"},{"line_number":273,"context_line":"        result \u003d self._test_get_vnc_config_spec(7, \u0027password\u0027)"},{"line_number":274,"context_line":"        expected \u003d \"\"\"{\u0027extraConfig\u0027: ["},{"line_number":275,"context_line":"                          {\u0027value\u0027: \u0027true\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FhTE%3D","line":272,"in_reply_to":"AAAASn%2F%2FhV0%3D","updated":"2013-09-03 21:00:42.000000000","message":"Done","commit_id":"2331e763af1a9a10971eecb5c4105ed0c487cb1f"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"136112aa95c60fbe9129b95e5d4cb6abbf99e9ac","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               deprecated_name\u003d\u0027vnc_password\u0027,"},{"line_number":123,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"               help\u003d\u0027DEPRECATED. VNC password. The password-based access to \u0027"},{"line_number":125,"context_line":"                    \u0027VNC consoles will be removed in the next release. The \u0027"},{"line_number":126,"context_line":"                    \u0027default value will disable password protection on the \u0027"},{"line_number":127,"context_line":"                    \u0027VNC console.\u0027,"},{"line_number":128,"context_line":"               secret\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F3do%3D","line":125,"updated":"2013-08-28 17:05:41.000000000","message":"Can you add a comment here making it clear, at least in the code that this should be removed in Icehouse.  otherwise looking up what \u0027next release\u0027 means gets confusing.\n\nAs someone who has gone through and removed deprecated config options in the past,  this makes life easier.","commit_id":"7659058fad03201e41461418568797d1591067e7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ea1de841b9e62f470715e9032a7da1df1d2f1a7f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"               deprecated_name\u003d\u0027vnc_password\u0027,"},{"line_number":123,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":124,"context_line":"               help\u003d\u0027DEPRECATED. VNC password. The password-based access to \u0027"},{"line_number":125,"context_line":"                    \u0027VNC consoles will be removed in the next release. The \u0027"},{"line_number":126,"context_line":"                    \u0027default value will disable password protection on the \u0027"},{"line_number":127,"context_line":"                    \u0027VNC console.\u0027,"},{"line_number":128,"context_line":"               secret\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F24E%3D","line":125,"in_reply_to":"AAAASn%2F%2F3do%3D","updated":"2013-08-28 18:53:15.000000000","message":"Sure","commit_id":"7659058fad03201e41461418568797d1591067e7"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6f0a2723b8afc89b1a9fff544afc4b4f58c4d354","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    opt_port.value \u003d port"},{"line_number":497,"context_line":"    extras \u003d [opt_enabled, opt_port]"},{"line_number":498,"context_line":"    if password:"},{"line_number":499,"context_line":"        LOG.deprecated(_(\"The VNC password is now deprecated (vnc_password). \""},{"line_number":500,"context_line":"                         \"This will be removed in the next release.\"))"},{"line_number":501,"context_line":"        opt_pass \u003d client_factory.create(\u0027ns0:OptionValue\u0027)"},{"line_number":502,"context_line":"        opt_pass.key \u003d \"RemoteDisplay.vnc.password\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASX%2F%2F6do%3D","line":499,"updated":"2013-08-23 20:06:05.000000000","message":"I\u0027d tweak the wording by saying:\n\nThe password-based access to VNC consoles will be removed in the next release. Please, switch to using the default value (this will disable password protection on the VNC console).","commit_id":"a328d241476bb5be2cc8576ce547e5916f637be6"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"5653d036fa3e33ce98fa23ac1653186a57fd95d2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from nova.openstack.common import log as logging"},{"line_number":28,"context_line":"from nova.virt.vmwareapi import vim_util"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAS3%2F%2F2kA%3D","line":30,"updated":"2013-09-18 08:22:55.000000000","message":"dupe","commit_id":"68fb4123d5c6ec2b138376d9432189b4d9a6d9ce"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ab87e5cb7e0c741509b68d2c60f0ee7e2da78329","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from nova.openstack.common import log as logging"},{"line_number":28,"context_line":"from nova.virt.vmwareapi import vim_util"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAS3%2F%2F2Jw%3D","line":30,"in_reply_to":"AAAAS3%2F%2F2kA%3D","updated":"2013-09-18 10:14:03.000000000","message":"Done","commit_id":"68fb4123d5c6ec2b138376d9432189b4d9a6d9ce"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"b7ec37c3d92e82ecf0af8240c94bf7041212a2b1","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        # Set the vnc configuration of the instance, vnc port starts from 5900"},{"line_number":230,"context_line":"        if CONF.vnc_enabled:"},{"line_number":231,"context_line":"            vnc_port \u003d self._get_vnc_port(vm_ref)"},{"line_number":232,"context_line":"            vnc_pass \u003d CONF.vmware.vnc_password"},{"line_number":233,"context_line":"            self._set_vnc_config(client_factory, instance, vnc_port, vnc_pass)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def _create_virtual_disk():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASX%2F%2F7Q4%3D","line":232,"updated":"2013-08-23 16:54:10.000000000","message":"Consider:\n   vnc_pass \u003d CONF.vmware.vnc_password or \u0027password\u0027\n\nRationale:\n\nThe use of a global cloud-wide VNC password is not good practice. In fact, it is so bad practice it should be disabled. If the ESX host can\u0027t deal with a password, it should not present the illusion that a password can provide cloud-wide security.\n\nBetter to propose a change that allows some form of strong encryption between the proxy and the VNC host.","commit_id":"d64de6515e56f378db9c7a393e1c785d1902e8ef"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c54e7e7ef984581c8065b7dc83e726e3d42ed685","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        # Set the vnc configuration of the instance, vnc port starts from 5900"},{"line_number":230,"context_line":"        if CONF.vnc_enabled:"},{"line_number":231,"context_line":"            vnc_port \u003d self._get_vnc_port(vm_ref)"},{"line_number":232,"context_line":"            vnc_pass \u003d CONF.vmware.vnc_password"},{"line_number":233,"context_line":"            self._set_vnc_config(client_factory, instance, vnc_port, vnc_pass)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        def _create_virtual_disk():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASX%2F%2F69U%3D","line":232,"in_reply_to":"AAAASX%2F%2F7Q4%3D","updated":"2013-08-23 18:22:59.000000000","message":"the patch in nova/virt/vmwareapi/vmops.py ensures that this provides support for no password being required. that is actually the bug.","commit_id":"d64de6515e56f378db9c7a393e1c785d1902e8ef"}]}