)]}'
{"nova/tests/unit/virt/vmwareapi/test_configdrive.py":[{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"457d1863df7d3818d9d704e3f4e0e242a3f286d8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_4184315d","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"updated":"2017-02-14 00:05:31.000000000","message":"I think we can add return_value to mocked object in a function than passing it as an argument.\nSomething like:\n_create_config_drive.return_value \u003d \u0027[ds1] fake.iso\u0027","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3f7841329d944ac673b201be03143ad72e1a6909","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_27a26d9b","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"updated":"2017-02-16 12:08:53.000000000","message":"nit: alignment","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cd1a1394096c750a07de20584fd8842a9afb5660","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_584efe6f","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"in_reply_to":"ba2be162_dc25ed5c","updated":"2017-03-02 12:19:21.000000000","message":"I prefer it being in the body of the function, so you get patch decorators, setup phase, then function under test, then asserts.\n\nbut locally consistent is fine. I wouldn\u0027t ever block this style.","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd79e96a396d59ebcf2c56a0da88265b98f9ff7e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_dc25ed5c","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"in_reply_to":"fa31d9ce_4184315d","updated":"2017-02-28 14:46:23.000000000","message":"\u003e I think we can add return_value to mocked object in a function than passing it as an argument.\n\u003e Something like:\n\u003e _create_config_drive.return_value \u003d \u0027[ds1] fake.iso\u0027\n\nWhy would you want to do that? This is much easier to read :)","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"efa534be481b87c4a637eef456924de03a843308","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_5a30019f","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"in_reply_to":"fa31d9ce_4184315d","updated":"2017-02-16 22:27:01.000000000","message":"yea I prefer that, but this is consistent with other changes in this dir so I will leave as it is.","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"7038fe5234e8a31b9fad2007fb3589cec0be68bb","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                        block_device_info\u003dblock_device_info)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":140,"context_line":"                                 return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":141,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":142,"context_line":"    def test_create_vm_with_config_drive_verify_method_invocation(self,"},{"line_number":143,"context_line":"                            mock_attach_cdrom, mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_b5402e37","line":140,"range":{"start_line":140,"start_character":33,"end_line":140,"end_character":63},"in_reply_to":"fa31d9ce_5a30019f","updated":"2017-02-16 22:48:09.000000000","message":"I have seen suggestions in other mox patches in this BP to add return_value in the decorator. So I was following that.","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"457d1863df7d3818d9d704e3f4e0e242a3f286d8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                                                  mock.ANY, mock.ANY)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_create_config_drive\u0027,"},{"line_number":159,"context_line":"                       return_value\u003d(\u0027[ds1] fake.iso\u0027))"},{"line_number":160,"context_line":"    @mock.patch.object(vmops.VMwareVMOps, \u0027_attach_cdrom_to_vm\u0027)"},{"line_number":161,"context_line":"    def test_create_vm_without_config_drive(self, mock_attach_cdrom,"},{"line_number":162,"context_line":"                                            mock_create_config_drive):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_61893575","line":159,"range":{"start_line":159,"start_character":22,"end_line":159,"end_character":54},"updated":"2017-02-14 00:05:31.000000000","message":"Same as above.","commit_id":"4fd3825be6b1e897ac787b46b44c598601dfd412"}]}