)]}'
{"nova/cmd/consoleauth.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"70449f9ddf2f77f11278351263125dde7f891d48","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    gmr.TextGuruMeditation.setup_autorun(version)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    server \u003d service.Service.create(binary\u003d\u0027nova-consoleauth\u0027,"},{"line_number":41,"context_line":"                                    topic\u003drpc.RPC_TOPIC)"},{"line_number":42,"context_line":"    service.serve(server)"},{"line_number":43,"context_line":"    service.wait()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_62653845","line":41,"range":{"start_line":41,"start_character":42,"end_line":41,"end_character":45},"updated":"2017-07-03 02:31:02.000000000","message":"s/rpc/rpcapi/","commit_id":"c2e0a7f137baecce4b8a341d87c6998811e8eba6"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from nova import rpc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":34,"context_line":"COMPUTE_TOPIC \u003d \"compute\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"LAST_VERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_bc991922","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":13},"updated":"2017-02-28 14:57:40.000000000","message":"Wouldn\u0027t using RPC_TOPIC in all files have made your replacement much easier? :)","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from nova import rpc"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":34,"context_line":"COMPUTE_TOPIC \u003d \"compute\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":"LAST_VERSION \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_97214bb7","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":13},"in_reply_to":"ba2be162_bc991922","updated":"2017-03-01 20:27:58.000000000","message":"It would, but I found it a bit more confusing. But given that these variables are in separate modules maybe it is not as much as I thought that it is.","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"}],"nova/network/rpcapi.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":30,"context_line":"NETWORK_TOPIC \u003d \"network\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@profiler.trace_cls(\"rpc\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_dcb5ed7e","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":25},"updated":"2017-02-28 14:57:40.000000000","message":"femtonit: You keep switching between different quote styles","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":30,"context_line":"NETWORK_TOPIC \u003d \"network\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@profiler.trace_cls(\"rpc\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_b7e64fb2","line":30,"range":{"start_line":30,"start_character":16,"end_line":30,"end_character":25},"in_reply_to":"ba2be162_dcb5ed7e","updated":"2017-03-01 20:27:58.000000000","message":"Done","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"}],"releasenotes/notes/remove-topic-config-opts-336f72bebf4e9141.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_7ca7a14f","line":4,"updated":"2017-02-28 14:57:40.000000000","message":"...deprecated in past releases and are now...","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_f779a7fd","line":4,"in_reply_to":"ba2be162_7ca7a14f","updated":"2017-03-01 20:27:58.000000000","message":"Done","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_fc71d1e1","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":31},"updated":"2017-02-28 14:57:40.000000000","message":"nit: nova?","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_177d5be7","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":31},"in_reply_to":"ba2be162_fc71d1e1","updated":"2017-03-01 20:27:58.000000000","message":"Done","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_9c49b591","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":63},"updated":"2017-02-28 14:57:40.000000000","message":"gain to/benefit from","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Configuration options related to RPC topics were deprecated and now"},{"line_number":5,"context_line":"    completly removed from Nova. There was no need to let users choose"},{"line_number":6,"context_line":"    the RPC topics for all services. There was little gain from this and"},{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_37841fd3","line":6,"range":{"start_line":6,"start_character":59,"end_line":6,"end_character":63},"in_reply_to":"ba2be162_9c49b591","updated":"2017-03-01 20:27:58.000000000","message":"Done","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0281310f6a45779c7b90582b9676c17009e513fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Following are the removed options:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    - ``compute_topic``"},{"line_number":13,"context_line":"    - ``console_topic``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_bc675924","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":38},"updated":"2017-02-28 14:57:40.000000000","message":"The following options are removed:","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"9b09d9eec50ef185f41b399234afb005c689eff9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    it made it really easy to break Nova by changing the value of topic"},{"line_number":8,"context_line":"    options."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    Following are the removed options:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    - ``compute_topic``"},{"line_number":13,"context_line":"    - ``console_topic``"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba2be162_5787d3d6","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":38},"in_reply_to":"ba2be162_bc675924","updated":"2017-03-01 20:27:58.000000000","message":"Done","commit_id":"8013f8425bc8774ca7c8d600033f40081799e6ad"}]}