)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"336dc2d370d3d22aa30a4b502c2115a47656e7bb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable defaults for cell_v2 update_cell command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initialize optional parameters for update_cells() to None and"},{"line_number":10,"context_line":"enable getting the transport_url and db_connection from"},{"line_number":11,"context_line":"nova.conf if not specified as arguments."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa31d9ce_cc0711c8","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":47},"updated":"2017-02-15 22:21:01.000000000","message":"nit: update_cell()","commit_id":"58b0ade341d9b7ab3493172ab574a4c61c03efee"}],"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9506ea0241a40dd6d3415f73bcacce2fccd98423","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"    @args(\u0027--database_connection\u0027, metavar\u003d\u0027\u003cdatabase\u003e\u0027, dest\u003d\u0027db_connection\u0027,"},{"line_number":1507,"context_line":"          help\u003d_(\u0027Set the cell database_connection. NOTE that running nodes \u0027"},{"line_number":1508,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1509,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1510,"context_line":"                    db_connection\u003dNone):"},{"line_number":1511,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."},{"line_number":1512,"context_line":""},{"line_number":1513,"context_line":"        If the cell is not found by uuid, this command will return an exit"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_0a182cd2","line":1510,"range":{"start_line":1509,"start_character":4,"end_line":1510,"end_character":40},"updated":"2017-02-15 21:56:22.000000000","message":"This should be all you need for this bug.","commit_id":"37007d8251249d77cf5685cbf18e81498639e638"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9506ea0241a40dd6d3415f73bcacce2fccd98423","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"        if name:"},{"line_number":1529,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1530,"context_line":""},{"line_number":1531,"context_line":"        transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1532,"context_line":"        if not transport_url:"},{"line_number":1533,"context_line":"            print(_(\u0027Must specify --transport-url if [DEFAULT]/transport_url \u0027"},{"line_number":1534,"context_line":"                    \u0027is not set in the configuration file.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8a3dfc2c","line":1531,"updated":"2017-02-15 21:56:22.000000000","message":"This makes transport_url required, which we don\u0027t want.","commit_id":"37007d8251249d77cf5685cbf18e81498639e638"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9506ea0241a40dd6d3415f73bcacce2fccd98423","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"        if transport_url:"},{"line_number":1537,"context_line":"            cell_mapping.transport_url \u003d transport_url"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1540,"context_line":"        if not db_connection:"},{"line_number":1541,"context_line":"            print(_(\u0027Must specify --database_connection \u0027"},{"line_number":1542,"context_line":"                    \u0027if [database]/connection is not set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_aa4800cd","line":1539,"updated":"2017-02-15 21:56:22.000000000","message":"same","commit_id":"37007d8251249d77cf5685cbf18e81498639e638"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca63f5ad0000f52902f53219614d39aec0cdb454","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"        if transport_url:"},{"line_number":1537,"context_line":"            cell_mapping.transport_url \u003d transport_url"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1540,"context_line":"        if not db_connection:"},{"line_number":1541,"context_line":"            print(_(\u0027Must specify --database_connection \u0027"},{"line_number":1542,"context_line":"                    \u0027if [database]/connection is not set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_2a11705d","line":1539,"in_reply_to":"fa31d9ce_2a59708e","updated":"2017-02-15 22:08:13.000000000","message":"If you\u0027re going to add that capability, then please also update the man page here:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/doc/source/man/nova-manage.rst#n166\n\nSo that we have the same wording as in create_cell for the config options:\n\nhttp://git.openstack.org/cgit/openstack/nova/tree/doc/source/man/nova-manage.rst#n132\n\ni.e.\n\n\"If a database_connection is not specified, it will use\n    the one defined by ``[database]/connection`` in the configuration file\n    passed to nova-manage. If a transport_url is not specified, it will use\n    the one defined by ``[DEFAULT]/transport_url`` in the configuration file.\"","commit_id":"37007d8251249d77cf5685cbf18e81498639e638"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"55446be524d5b9b5d172ce5ccf616f0c1329171a","unresolved":false,"context_lines":[{"line_number":1536,"context_line":"        if transport_url:"},{"line_number":1537,"context_line":"            cell_mapping.transport_url \u003d transport_url"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1540,"context_line":"        if not db_connection:"},{"line_number":1541,"context_line":"            print(_(\u0027Must specify --database_connection \u0027"},{"line_number":1542,"context_line":"                    \u0027if [database]/connection is not set \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_2a59708e","line":1539,"in_reply_to":"fa31d9ce_aa4800cd","updated":"2017-02-15 21:59:26.000000000","message":"ok i\u0027ll drop the \u0027if not\u0027 blocks but keep the new assignments since we need to pick up from nova.conf if it\u0027s not specified as an argument (transport_url and db_connection)","commit_id":"37007d8251249d77cf5685cbf18e81498639e638"}]}