)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b4556555c17f5ed86d9947b4e4864a77d1fdb9e","unresolved":false,"context_lines":[{"line_number":654,"context_line":"]"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"libvirt_pxe_opts \u003d ["},{"line_number":657,"context_line":"    cfg.BoolOpt(\u0027enable_pxe_support\u0027,"},{"line_number":658,"context_line":"                default\u003dFalse,"},{"line_number":659,"context_line":"                help\u003d\"\"\""},{"line_number":660,"context_line":"Enable pxe boot support"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_6f529768","line":657,"updated":"2017-02-15 23:19:04.000000000","message":"I won\u0027t support config-driven behavior like this. This is where you\u0027d use flavor extra specs so that the admin can setup flavors that are related to host aggregates where you can do something like this and set it all up via scheduler filters so the server create request with the given flavor for pxe boot goes to a host in the related aggregate.","commit_id":"aa4caf32ab9c3521fff59d220d988a9a25e90b68"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2e291fa948deaada380293b9f0ecb5ee16d1efd","unresolved":false,"context_lines":[{"line_number":654,"context_line":"]"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":"libvirt_pxe_opts \u003d ["},{"line_number":657,"context_line":"    cfg.BoolOpt(\u0027enable_pxe_support\u0027,"},{"line_number":658,"context_line":"                default\u003dFalse,"},{"line_number":659,"context_line":"                help\u003d\"\"\""},{"line_number":660,"context_line":"Enable pxe boot support"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_2fea5f74","line":657,"in_reply_to":"fa31d9ce_6f529768","updated":"2017-02-15 23:23:19.000000000","message":"Seems overly complex, but I will look into this. Thanks.","commit_id":"aa4caf32ab9c3521fff59d220d988a9a25e90b68"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9b4556555c17f5ed86d9947b4e4864a77d1fdb9e","unresolved":false,"context_lines":[{"line_number":4698,"context_line":""},{"line_number":4699,"context_line":"        if (CONF.libvirt.enable_pxe_support and"},{"line_number":4700,"context_line":"                CONF.libvirt.virt_type in [\u0027qemu\u0027, \u0027kvm\u0027] and"},{"line_number":4701,"context_line":"                instance.metadata.get(\u0027libvirt:pxe-first\u0027)):"},{"line_number":4702,"context_line":"            guest.os_boot_dev \u003d [\u0027network\u0027] + guest.os_boot_dev"},{"line_number":4703,"context_line":""},{"line_number":4704,"context_line":"        self._set_features(guest, instance.os_type, caps, virt_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_af1acfc3","line":4701,"range":{"start_line":4701,"start_character":16,"end_line":4701,"end_character":60},"updated":"2017-02-15 23:19:04.000000000","message":"There is no way we\u0027re going to accept this as user-provided metadata. The normal way to handle a wrinkle like this is with flavor extra specs and/or image metadata.","commit_id":"aa4caf32ab9c3521fff59d220d988a9a25e90b68"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e18162c77ef0513c23fb5a94ee2c954f45f94d84","unresolved":false,"context_lines":[{"line_number":4698,"context_line":""},{"line_number":4699,"context_line":"        if (CONF.libvirt.enable_pxe_support and"},{"line_number":4700,"context_line":"                CONF.libvirt.virt_type in [\u0027qemu\u0027, \u0027kvm\u0027] and"},{"line_number":4701,"context_line":"                instance.metadata.get(\u0027libvirt:pxe-first\u0027)):"},{"line_number":4702,"context_line":"            guest.os_boot_dev \u003d [\u0027network\u0027] + guest.os_boot_dev"},{"line_number":4703,"context_line":""},{"line_number":4704,"context_line":"        self._set_features(guest, instance.os_type, caps, virt_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_e0793494","line":4701,"range":{"start_line":4701,"start_character":16,"end_line":4701,"end_character":60},"in_reply_to":"fa31d9ce_0f9e7b06","updated":"2017-02-16 00:55:29.000000000","message":"hw:watchdog_action is a flavor extra spec, and hw_watchdog_action is an image metadata property for the same thing. Explained here:\n\nhttps://docs.openstack.org/cli-reference/glance-property-keys.html\n\nExtra specs are described here:\n\nhttps://docs.openstack.org/admin-guide/compute-flavors.html#extra-specs","commit_id":"aa4caf32ab9c3521fff59d220d988a9a25e90b68"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c2e291fa948deaada380293b9f0ecb5ee16d1efd","unresolved":false,"context_lines":[{"line_number":4698,"context_line":""},{"line_number":4699,"context_line":"        if (CONF.libvirt.enable_pxe_support and"},{"line_number":4700,"context_line":"                CONF.libvirt.virt_type in [\u0027qemu\u0027, \u0027kvm\u0027] and"},{"line_number":4701,"context_line":"                instance.metadata.get(\u0027libvirt:pxe-first\u0027)):"},{"line_number":4702,"context_line":"            guest.os_boot_dev \u003d [\u0027network\u0027] + guest.os_boot_dev"},{"line_number":4703,"context_line":""},{"line_number":4704,"context_line":"        self._set_features(guest, instance.os_type, caps, virt_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_0f9e7b06","line":4701,"range":{"start_line":4701,"start_character":16,"end_line":4701,"end_character":60},"in_reply_to":"fa31d9ce_af1acfc3","updated":"2017-02-15 23:23:19.000000000","message":"Is there already an example of such a pattern that I can reference?","commit_id":"aa4caf32ab9c3521fff59d220d988a9a25e90b68"}]}