)]}'
{"nova/tests/unit/db/test_db_api.py":[{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"7625644c3303dd17c507bcd6815df1218c403f4b","unresolved":false,"context_lines":[{"line_number":929,"context_line":"            return get_query"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        get_query \u003d counted()"},{"line_number":932,"context_line":"        self.stubs.Set(sqlalchemy_api,"},{"line_number":933,"context_line":"                       \u0027_aggregate_metadata_get_query\u0027, get_query)"},{"line_number":934,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry, sqlalchemy_api."},{"line_number":935,"context_line":"                          aggregate_metadata_add, ctxt, result[\u0027id\u0027], {},"},{"line_number":936,"context_line":"                          max_retries\u003d5)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_8de125d3","side":"PARENT","line":933,"range":{"start_line":932,"start_character":8,"end_line":933,"end_character":66},"updated":"2017-02-21 23:16:48.000000000","message":"This should be changed to stub_out.","commit_id":"ec4eb72d6a7c87a410abaa378019c53fd6ffbd08"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"3f14e2ead7825be4dcf4c6df349f844e6f134a4e","unresolved":false,"context_lines":[{"line_number":929,"context_line":"            return get_query"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        get_query \u003d counted()"},{"line_number":932,"context_line":"        self.stubs.Set(sqlalchemy_api,"},{"line_number":933,"context_line":"                       \u0027_aggregate_metadata_get_query\u0027, get_query)"},{"line_number":934,"context_line":"        self.assertRaises(db_exc.DBDuplicateEntry, sqlalchemy_api."},{"line_number":935,"context_line":"                          aggregate_metadata_add, ctxt, result[\u0027id\u0027], {},"},{"line_number":936,"context_line":"                          max_retries\u003d5)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_db248ec6","side":"PARENT","line":933,"range":{"start_line":932,"start_character":8,"end_line":933,"end_character":66},"in_reply_to":"da36d5c6_8de125d3","updated":"2017-02-22 22:21:22.000000000","message":"Done","commit_id":"ec4eb72d6a7c87a410abaa378019c53fd6ffbd08"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"7625644c3303dd17c507bcd6815df1218c403f4b","unresolved":false,"context_lines":[{"line_number":4647,"context_line":"            return get_id"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"        get_id \u003d counted()"},{"line_number":4650,"context_line":"        self.stubs.Set(sqlalchemy_api, \u0027_flavor_get_id_from_flavor\u0027, get_id)"},{"line_number":4651,"context_line":"        self.assertRaises(exception.FlavorExtraSpecUpdateCreateFailed,"},{"line_number":4652,"context_line":"                          sqlalchemy_api.flavor_extra_specs_update_or_create,"},{"line_number":4653,"context_line":"                          self.ctxt, 1, {}, 5)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_6d05d178","side":"PARENT","line":4650,"range":{"start_line":4650,"start_character":8,"end_line":4650,"end_character":76},"updated":"2017-02-21 23:16:48.000000000","message":"This should be changed to stub_out.","commit_id":"ec4eb72d6a7c87a410abaa378019c53fd6ffbd08"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"3f14e2ead7825be4dcf4c6df349f844e6f134a4e","unresolved":false,"context_lines":[{"line_number":4647,"context_line":"            return get_id"},{"line_number":4648,"context_line":""},{"line_number":4649,"context_line":"        get_id \u003d counted()"},{"line_number":4650,"context_line":"        self.stubs.Set(sqlalchemy_api, \u0027_flavor_get_id_from_flavor\u0027, get_id)"},{"line_number":4651,"context_line":"        self.assertRaises(exception.FlavorExtraSpecUpdateCreateFailed,"},{"line_number":4652,"context_line":"                          sqlalchemy_api.flavor_extra_specs_update_or_create,"},{"line_number":4653,"context_line":"                          self.ctxt, 1, {}, 5)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_1b2b8695","side":"PARENT","line":4650,"range":{"start_line":4650,"start_character":8,"end_line":4650,"end_character":76},"in_reply_to":"da36d5c6_6d05d178","updated":"2017-02-22 22:21:22.000000000","message":"Done","commit_id":"ec4eb72d6a7c87a410abaa378019c53fd6ffbd08"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"7625644c3303dd17c507bcd6815df1218c403f4b","unresolved":false,"context_lines":[{"line_number":5452,"context_line":"                          db.floating_ip_get, self.ctxt, 100500)"},{"line_number":5453,"context_line":""},{"line_number":5454,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":5455,"context_line":"    def test_floating_ip_get_with_long_id_not_found(self, mock_query):"},{"line_number":5456,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":5457,"context_line":"        self.assertRaises(exception.InvalidID,"},{"line_number":5458,"context_line":"                          db.floating_ip_get, self.ctxt, 123456789101112)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_adffc965","line":5455,"range":{"start_line":5455,"start_character":58,"end_line":5455,"end_character":68},"updated":"2017-02-21 23:16:48.000000000","message":"shouldn\u0027t we check for mock_query.assert_called_once_with()?","commit_id":"f8959973a31b268be6554a5abd0f3f9b6a57d2a1"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"3f14e2ead7825be4dcf4c6df349f844e6f134a4e","unresolved":false,"context_lines":[{"line_number":5452,"context_line":"                          db.floating_ip_get, self.ctxt, 100500)"},{"line_number":5453,"context_line":""},{"line_number":5454,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":5455,"context_line":"    def test_floating_ip_get_with_long_id_not_found(self, mock_query):"},{"line_number":5456,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":5457,"context_line":"        self.assertRaises(exception.InvalidID,"},{"line_number":5458,"context_line":"                          db.floating_ip_get, self.ctxt, 123456789101112)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_96074d17","line":5455,"range":{"start_line":5455,"start_character":58,"end_line":5455,"end_character":68},"in_reply_to":"da36d5c6_adffc965","updated":"2017-02-22 22:21:22.000000000","message":"I think this is ok. InvalidID is raised only when mock_query is called. also there are no arguments for first(). so we can only check if its called.","commit_id":"f8959973a31b268be6554a5abd0f3f9b6a57d2a1"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"61dbd990fb9c7c6827afa2a3a71c4db84916b5f3","unresolved":false,"context_lines":[{"line_number":4260,"context_line":"        expected \u003d {uuid: []}"},{"line_number":4261,"context_line":"        self.assertEqual(expected, faults)"},{"line_number":4262,"context_line":""},{"line_number":4263,"context_line":"    def test_instance_faults_get_by_instance_uuids_no_uuids(self):"},{"line_number":4264,"context_line":"        faults \u003d db.instance_fault_get_by_instance_uuids(self.ctxt, [])"},{"line_number":4265,"context_line":"        self.assertEqual({}, faults)"},{"line_number":4266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_cf82c4c7","line":4263,"range":{"start_line":4263,"start_character":1,"end_line":4263,"end_character":66},"updated":"2017-02-24 16:24:40.000000000","message":"I am thinking if we want to add assert check here to confirm that query filter is not called.","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"a5a117a1f604873e13bc76f07f413da5195865dc","unresolved":false,"context_lines":[{"line_number":4260,"context_line":"        expected \u003d {uuid: []}"},{"line_number":4261,"context_line":"        self.assertEqual(expected, faults)"},{"line_number":4262,"context_line":""},{"line_number":4263,"context_line":"    def test_instance_faults_get_by_instance_uuids_no_uuids(self):"},{"line_number":4264,"context_line":"        faults \u003d db.instance_fault_get_by_instance_uuids(self.ctxt, [])"},{"line_number":4265,"context_line":"        self.assertEqual({}, faults)"},{"line_number":4266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_1db6958a","line":4263,"range":{"start_line":4263,"start_character":1,"end_line":4263,"end_character":66},"in_reply_to":"ba2be162_ceaa9785","updated":"2017-02-28 19:40:46.000000000","message":"Done","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb64a7bc535dee19bf5c21d43e7d80f98a6973ff","unresolved":false,"context_lines":[{"line_number":4260,"context_line":"        expected \u003d {uuid: []}"},{"line_number":4261,"context_line":"        self.assertEqual(expected, faults)"},{"line_number":4262,"context_line":""},{"line_number":4263,"context_line":"    def test_instance_faults_get_by_instance_uuids_no_uuids(self):"},{"line_number":4264,"context_line":"        faults \u003d db.instance_fault_get_by_instance_uuids(self.ctxt, [])"},{"line_number":4265,"context_line":"        self.assertEqual({}, faults)"},{"line_number":4266,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_ceaa9785","line":4263,"range":{"start_line":4263,"start_character":1,"end_line":4263,"end_character":66},"in_reply_to":"da36d5c6_cf82c4c7","updated":"2017-02-28 14:13:45.000000000","message":"Correct. There should be no calls to that function","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb64a7bc535dee19bf5c21d43e7d80f98a6973ff","unresolved":false,"context_lines":[{"line_number":5454,"context_line":""},{"line_number":5455,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":5456,"context_line":"    def test_floating_ip_get_with_long_id_not_found(self, mock_query):"},{"line_number":5457,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":5458,"context_line":"        self.assertRaises(exception.InvalidID,"},{"line_number":5459,"context_line":"                          db.floating_ip_get, self.ctxt, 123456789101112)"},{"line_number":5460,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_0ea3cf9f","line":5457,"range":{"start_line":5457,"start_character":0,"end_line":5457,"end_character":49},"updated":"2017-02-28 14:13:45.000000000","message":"See below","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb64a7bc535dee19bf5c21d43e7d80f98a6973ff","unresolved":false,"context_lines":[{"line_number":5879,"context_line":""},{"line_number":5880,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":5881,"context_line":"    def test_floating_ip_get_by_invalid_address(self, mock_query):"},{"line_number":5882,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":5883,"context_line":"        self.assertRaises(exception.InvalidIpAddressError,"},{"line_number":5884,"context_line":"                          db.floating_ip_get_by_address,"},{"line_number":5885,"context_line":"                          self.ctxt, \u0027non_exists_host\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_6e736b4e","line":5882,"range":{"start_line":5882,"start_character":8,"end_line":5882,"end_character":49},"updated":"2017-02-28 14:13:45.000000000","message":"could you pass this as an argument to the decorator?\n\n     @mock.patch.object(query.Query, \u0027first\u0027,\n                        side_effect\u003ddb_exc.DBError())\n\nAlso, you need to assert that the function was called once","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"a5a117a1f604873e13bc76f07f413da5195865dc","unresolved":false,"context_lines":[{"line_number":5879,"context_line":""},{"line_number":5880,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":5881,"context_line":"    def test_floating_ip_get_by_invalid_address(self, mock_query):"},{"line_number":5882,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":5883,"context_line":"        self.assertRaises(exception.InvalidIpAddressError,"},{"line_number":5884,"context_line":"                          db.floating_ip_get_by_address,"},{"line_number":5885,"context_line":"                          self.ctxt, \u0027non_exists_host\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_9d2fe5a0","line":5882,"range":{"start_line":5882,"start_character":8,"end_line":5882,"end_character":49},"in_reply_to":"ba2be162_6e736b4e","updated":"2017-02-28 19:40:46.000000000","message":"I think adding to decorator is a personal choice.\n\nAnd for assert I felt that it is redundant as the exception would be thrown only if the mock is called. Anyway, changed both.","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"eb64a7bc535dee19bf5c21d43e7d80f98a6973ff","unresolved":false,"context_lines":[{"line_number":6721,"context_line":"    @mock.patch.object(query.Query, \u0027first\u0027)"},{"line_number":6722,"context_line":"    def test_virtual_interface_get_by_address_data_error_exception(self,"},{"line_number":6723,"context_line":"                                                mock_query):"},{"line_number":6724,"context_line":"        mock_query.side_effect \u003d db_exc.DBError()"},{"line_number":6725,"context_line":"        self.assertRaises(exception.InvalidIpAddressError,"},{"line_number":6726,"context_line":"                          db.virtual_interface_get_by_address,"},{"line_number":6727,"context_line":"                          self.ctxt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_8edc1f1a","line":6724,"range":{"start_line":6724,"start_character":0,"end_line":6724,"end_character":49},"updated":"2017-02-28 14:13:45.000000000","message":"See above","commit_id":"81389cbfc3344535844a6af67fbd36b6912ec2e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b70e9f97922a7a17e0896ca1c856fec4957e198","unresolved":false,"context_lines":[{"line_number":2541,"context_line":""},{"line_number":2542,"context_line":"    @mock.patch.object(query.Query, \u0027filter\u0027)"},{"line_number":2543,"context_line":"    def test_instance_system_metadata_get_multi_no_uuids(self,"},{"line_number":2544,"context_line":"                                               mock_query_filter):"},{"line_number":2545,"context_line":"        sqlalchemy_api._instance_system_metadata_get_multi(self.ctxt, [])"},{"line_number":2546,"context_line":"        self.assertFalse(mock_query_filter.called)"},{"line_number":2547,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_4b6d9203","line":2544,"range":{"start_line":2544,"start_character":12,"end_line":2544,"end_character":47},"updated":"2017-03-01 09:11:23.000000000","message":"Why all this padding?","commit_id":"5ac78a114cc0e86b3cacfa7521f9040339ddb55f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9fc958ee8f27a8e45062ec95878dcdb19a17bbd2","unresolved":false,"context_lines":[{"line_number":2541,"context_line":""},{"line_number":2542,"context_line":"    @mock.patch.object(query.Query, \u0027filter\u0027)"},{"line_number":2543,"context_line":"    def test_instance_system_metadata_get_multi_no_uuids(self,"},{"line_number":2544,"context_line":"                                               mock_query_filter):"},{"line_number":2545,"context_line":"        sqlalchemy_api._instance_system_metadata_get_multi(self.ctxt, [])"},{"line_number":2546,"context_line":"        self.assertFalse(mock_query_filter.called)"},{"line_number":2547,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba2be162_e4e4b33c","line":2544,"range":{"start_line":2544,"start_character":12,"end_line":2544,"end_character":47},"in_reply_to":"ba2be162_4b6d9203","updated":"2017-03-01 09:51:50.000000000","message":"yea could have given short name to mock_query_filter","commit_id":"5ac78a114cc0e86b3cacfa7521f9040339ddb55f"}]}