)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8b5214472a0ab8d116f81938d591c694f81bc5c6","unresolved":false,"context_lines":[{"line_number":814,"context_line":"                context, objects.CellMapping.CELL0_UUID)"},{"line_number":815,"context_line":"        except exception.CellMappingNotFound:"},{"line_number":816,"context_line":"            # Not yet setup for cellsv2. Instances will need to be written"},{"line_number":817,"context_line":"            # to the configured database. This will become a deployment"},{"line_number":818,"context_line":"            # error in Ocata."},{"line_number":819,"context_line":"            LOG.error(_LE(\u0027No cell mapping found for cell0 while \u0027"},{"line_number":820,"context_line":"                          \u0027trying to record scheduling failure. \u0027"},{"line_number":821,"context_line":"                          \u0027Setup is incomplete.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_8aabf3d4","side":"PARENT","line":818,"range":{"start_line":817,"start_character":42,"end_line":818,"end_character":29},"updated":"2017-04-24 15:34:37.000000000","message":"This is what really had confused me about this from the start, and led me to believe we could remove this as transitional. I was thinking about the Ocata blocker migration for cells v2 but forgot about the no flavors check in there.","commit_id":"93bf6ba5186a3663606aa843a2f247709173f073"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6bb71f9292151b12e58b7127e8574542eb052dde","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        schedule_and_build_instances() below."},{"line_number":811,"context_line":"        \"\"\""},{"line_number":812,"context_line":"        cell0 \u003d objects.CellMapping.get_by_uuid("},{"line_number":813,"context_line":"            context, objects.CellMapping.CELL0_UUID)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        build_requests \u003d build_requests or []"},{"line_number":816,"context_line":"        instances \u003d instances or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_87f64e8f","line":813,"updated":"2017-04-24 15:16:04.000000000","message":"So, people who update from older versions can\u0027t get here without cell0 in the database. However, people that are setting up from scratch can, and they will get an unhelpful error message if they do. Right?","commit_id":"fa456d0acb96d130b926e6c477cd8df0c412086d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c8cc31152701bc901ffd6c55222c7cb372af108","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        schedule_and_build_instances() below."},{"line_number":811,"context_line":"        \"\"\""},{"line_number":812,"context_line":"        cell0 \u003d objects.CellMapping.get_by_uuid("},{"line_number":813,"context_line":"            context, objects.CellMapping.CELL0_UUID)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        build_requests \u003d build_requests or []"},{"line_number":816,"context_line":"        instances \u003d instances or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_478f26cc","line":813,"in_reply_to":"5ff73747_27141aa0","updated":"2017-04-24 15:24:04.000000000","message":"I forgot about the 0 flavors caveat for fresh installs in the db migration:\n\nhttps://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_migrations/migrate_repo/versions/030_require_cell_setup.py#L29\n\nSo for the part in the code that says \"This will become a deployment error in Ocata.\" - how do we make this a deployment error? We have nova-status upgrade check which would fail on not having cell0, but otherwise we don\u0027t have anything.\n\nI guess if we exit early, you still have the build request and can list instances from that, and when you delete the instance we\u0027d really be deleting the build request in the API.\n\nWe aren\u0027t putting the build request into ERROR state though...","commit_id":"fa456d0acb96d130b926e6c477cd8df0c412086d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bcb213cafea6a2724c310b12f76211b50846b701","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        schedule_and_build_instances() below."},{"line_number":811,"context_line":"        \"\"\""},{"line_number":812,"context_line":"        cell0 \u003d objects.CellMapping.get_by_uuid("},{"line_number":813,"context_line":"            context, objects.CellMapping.CELL0_UUID)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        build_requests \u003d build_requests or []"},{"line_number":816,"context_line":"        instances \u003d instances or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_875c0e4c","line":813,"in_reply_to":"5ff73747_478f26cc","updated":"2017-04-24 15:26:33.000000000","message":"Not only would the instance not show up as building forever, but we also don\u0027t send a notification in this case.","commit_id":"fa456d0acb96d130b926e6c477cd8df0c412086d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6e8a187792b4d1c77c6f0cfe97727aba28bddd9a","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        schedule_and_build_instances() below."},{"line_number":811,"context_line":"        \"\"\""},{"line_number":812,"context_line":"        cell0 \u003d objects.CellMapping.get_by_uuid("},{"line_number":813,"context_line":"            context, objects.CellMapping.CELL0_UUID)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        build_requests \u003d build_requests or []"},{"line_number":816,"context_line":"        instances \u003d instances or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_c718d682","line":813,"in_reply_to":"5ff73747_478f26cc","updated":"2017-04-24 15:27:33.000000000","message":"Regardless of whether we bail early here or continue below and make some changes, we still need to catch and log this in big red text.\n\nSince we can\u0027t mark the instance as error if we can\u0027t put it into cell0, I tend to think we should continue to bail and let them delete the instances after they find this error message in the logs, but I\u0027m not too opinionated on that detail.","commit_id":"fa456d0acb96d130b926e6c477cd8df0c412086d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0b5ed4718c161e5a612c2732bd77eda8b07a8579","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        schedule_and_build_instances() below."},{"line_number":811,"context_line":"        \"\"\""},{"line_number":812,"context_line":"        cell0 \u003d objects.CellMapping.get_by_uuid("},{"line_number":813,"context_line":"            context, objects.CellMapping.CELL0_UUID)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        build_requests \u003d build_requests or []"},{"line_number":816,"context_line":"        instances \u003d instances or []"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_27141aa0","line":813,"in_reply_to":"5ff73747_87f64e8f","updated":"2017-04-24 15:18:13.000000000","message":"No, it\u0027s also for new installs because in Ocata we have a DB schema migration that blocks you if you don\u0027t have cell0.","commit_id":"fa456d0acb96d130b926e6c477cd8df0c412086d"}]}