)]}'
{"nova/objects/diagnostics.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5e55eb842728097cc08b89972befeea2c55b9a05","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    fields \u003d {"},{"line_number":27,"context_line":"        \u0027id\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":28,"context_line":"        \u0027time\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":29,"context_line":"        \u0027utilisation\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_2c579e03","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":49},"updated":"2017-03-15 04:24:04.000000000","message":"this should be string field as per ?- https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/restore-vm-diagnostics.html","commit_id":"1973bd5302e950a7deae28fb14c47d1f205a3506"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"cb402c892df869558a40d3eca0c48a3c3dbf787c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    fields \u003d {"},{"line_number":27,"context_line":"        \u0027id\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":28,"context_line":"        \u0027time\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":29,"context_line":"        \u0027utilisation\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a1ff146_2f9a2615","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":49},"in_reply_to":"3a1ff146_2c579e03","updated":"2017-03-15 10:07:35.000000000","message":"Oops. I guess I forgot to update it in spec. I think that Integer IDs for CPUs looks more obvious. I updated the spec https://review.openstack.org/#/c/445855","commit_id":"1973bd5302e950a7deae28fb14c47d1f205a3506"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6981dc8983fba1c8e50a7f78e6b14d740c2580de","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    fields \u003d {"},{"line_number":27,"context_line":"        \u0027id\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":28,"context_line":"        \u0027time\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":29,"context_line":"        \u0027utilisation\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":30,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_af2c67ac","line":27,"range":{"start_line":27,"start_character":14,"end_line":27,"end_character":49},"in_reply_to":"3a1ff146_2f9a2615","updated":"2017-03-17 06:32:29.000000000","message":"+1 to update spec, so this looks fine now","commit_id":"1973bd5302e950a7deae28fb14c47d1f205a3506"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f0b2a699ef8e0a787d18985846e6c5d920252009","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \u0027hypervisor\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":91,"context_line":"        \u0027hypervisor_os\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":92,"context_line":"        \u0027uptime\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":93,"context_line":"        \u0027config_drive\u0027: fields.BooleanField(nullable\u003dTrue),"},{"line_number":94,"context_line":"        \u0027memory_details\u0027: fields.ObjectField(\u0027MemoryDiagnostics\u0027,"},{"line_number":95,"context_line":"                                             default\u003dMemoryDiagnostics()),"},{"line_number":96,"context_line":"        \u0027cpu_details\u0027: fields.ListOfObjectsField(\u0027CpuDiagnostics\u0027, default\u003d[]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_8fbecbfd","line":93,"range":{"start_line":93,"start_character":44,"end_line":93,"end_character":57},"updated":"2017-03-17 06:11:35.000000000","message":"this should not be nullable right?\n\ncurrently xen, libvirt, vmware add config drive always-\nhttps://github.com/openstack/nova/blob/02dc9a4a1fea3b17230a1bf2bc56748e52fa190a/nova/virt/xenapi/vm_utils.py#L1741\n\nhttps://github.com/openstack/nova/blob/27545305aa78b382e2aa86a54b359d48a6666f46/nova/virt/libvirt/driver.py#L7575\n\nhttps://github.com/openstack/nova/blob/e6e33dd6f757e6fa16ad74ec999f39fb804bba2b/nova/virt/vmwareapi/vmops.py#L1551","commit_id":"1973bd5302e950a7deae28fb14c47d1f205a3506"},{"author":{"_account_id":9569,"name":"Sergey Nikitin","email":"nikitinserv@gmail.com","username":"snikitin"},"change_message_id":"61b0145034193751b467fce50ef8c4470d71c775","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \u0027hypervisor\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":91,"context_line":"        \u0027hypervisor_os\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":92,"context_line":"        \u0027uptime\u0027: fields.IntegerField(nullable\u003dTrue),"},{"line_number":93,"context_line":"        \u0027config_drive\u0027: fields.BooleanField(nullable\u003dTrue),"},{"line_number":94,"context_line":"        \u0027memory_details\u0027: fields.ObjectField(\u0027MemoryDiagnostics\u0027,"},{"line_number":95,"context_line":"                                             default\u003dMemoryDiagnostics()),"},{"line_number":96,"context_line":"        \u0027cpu_details\u0027: fields.ListOfObjectsField(\u0027CpuDiagnostics\u0027, default\u003d[]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_f5550450","line":93,"range":{"start_line":93,"start_character":44,"end_line":93,"end_character":57},"in_reply_to":"1a1ced50_8fbecbfd","updated":"2017-03-20 15:22:13.000000000","message":"nice catch!","commit_id":"1973bd5302e950a7deae28fb14c47d1f205a3506"}]}