)]}'
{"nova/api/metadata/vendordata_dynamic.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"231415ea146d37389d2e54e83c5cd5839f475602","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_serialization import jsonutils"},{"line_number":24,"context_line":"import requests"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova.api.metadata import vendordata"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_e1f1216c","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":15},"updated":"2017-02-27 18:13:11.000000000","message":"Wait - this shouldn\u0027t be here","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d631d38134c3d874fe58f577307002fac081ebc1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":22,"context_line":"from oslo_log import log as logging"},{"line_number":23,"context_line":"from oslo_serialization import jsonutils"},{"line_number":24,"context_line":"import requests"},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova.api.metadata import vendordata"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7cb8782b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":15},"in_reply_to":"da36d5c6_e1f1216c","updated":"2017-02-27 18:21:22.000000000","message":"Darn. Rebase fail on my part :(","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"}],"nova/cmd/status.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46d2a077ca5afc5662863dcd4b10069a262640e9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_6150d15f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"updated":"2017-02-27 18:12:28.000000000","message":"Unrelated, but this could go in a follow up patch IMO","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"64fccaf93f2b656de0ed34f3e724be2239566b6e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_97734eb4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"ba2be162_bc62f9ab","updated":"2017-02-28 14:59:38.000000000","message":"I learn something new everyday :) nvm so","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"d631d38134c3d874fe58f577307002fac081ebc1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_9c8c4c81","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"da36d5c6_6150d15f","updated":"2017-02-27 18:21:22.000000000","message":"I don\u0027t understand. This didn\u0027t change.","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"135e59904491eac7c5d78e362a7b8c29f8df6d41","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_f1ee37b3","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"da36d5c6_7c54f8c9","updated":"2017-02-28 10:56:22.000000000","message":"That was badly worded. Let\u0027s try again\n\n\u003e While unrelated to this particular change, this line could be removed in a follow up patch as it\u0027s not necessary with Python 2.7+\n\nSorry for the confusion :)","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"396263cd43323a110cbe381175ede6790b1ed9a5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7c54f8c9","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"da36d5c6_9c8c4c81","updated":"2017-02-27 18:22:26.000000000","message":"As a note, this has to be at the top of the file. This is a special import. So that is why it is at the top.","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"fb246425882358f5822877370db0377c4c8cab61","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CLI interface for nova status commands."},{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_bc62f9ab","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":37},"in_reply_to":"da36d5c6_f1ee37b3","updated":"2017-02-28 14:45:02.000000000","message":"Sort of, but not quite as I have run into this issue before.\n\n Python 2.7.13 (default, Jan 13 2017, 10:15:16)\n [GCC 6.3.1 20161221 (Red Hat 6.3.1-1)] on linux2\n Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n \u003e\u003e\u003e print()\n ()\n \u003e\u003e\u003e from __future__ import print_function\n \u003e\u003e\u003e print() \n\n \u003e\u003e\u003e","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0fcb2f9f718b6215bf5a9c5d373867d11c3a1858","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"},{"line_number":23,"context_line":"import functools"},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import textwrap"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_01347548","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":11},"updated":"2017-02-27 18:11:30.000000000","message":"Isn\u0027t this going to vary depending on what environment you run the \u0027pep8\u0027 target under? Perhaps you should hardcode the environment (if you haven\u0027t already done so)","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"46d2a077ca5afc5662863dcd4b10069a262640e9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# enum comes from the enum34 package if python \u003c 3.4, else it\u0027s stdlib"},{"line_number":22,"context_line":"import enum"},{"line_number":23,"context_line":"import functools"},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import textwrap"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_0159d58e","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":11},"in_reply_to":"da36d5c6_01347548","updated":"2017-02-27 18:12:28.000000000","message":"Wait - nvm. I see it\u0027s already hardcoded and works anyway. Must be handled implicitly","commit_id":"7b164c212575f0dcdb575e6dc0b03edb4a97b5d8"}],"nova/test.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cd1f004518de5cc8b8b8cf34499136505bef63df","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import eventlet  # noqa"},{"line_number":25,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import contextlib"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_d7ecde94","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":23},"updated":"2017-02-27 19:26:47.000000000","message":"Why do we need to put noqa here?","commit_id":"27710a063096a63405887b5c3bef339f818635a0"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"c048fb79965c34da47d42364b4415eddc4b51e97","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import eventlet  # noqa"},{"line_number":25,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import contextlib"}],"source_content_type":"text/x-python","patch_set":3,"id":"da36d5c6_7d0f912e","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":23},"in_reply_to":"da36d5c6_d7ecde94","updated":"2017-02-27 20:14:19.000000000","message":"From what I read, this needs to be the very first import in the file.\n\nhttp://eventlet.net/doc/patching.html#monkey-patch\n\nt is important to call monkey_patch() as early in the lifetime of the application as possible. Try to do it as one of the first lines in the main module. The reason for this is that sometimes there is a class that inherits from a class that needs to be greened – e.g. a class that inherits from socket.socket – and inheritance is done at import time, so therefore the monkeypatching should happen before the derived class is defined. It’s safe to call monkey_patch multiple times.","commit_id":"27710a063096a63405887b5c3bef339f818635a0"}],"nova/tests/unit/test_metadata.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"69a1ebe5ef7025a0c7ef04970c4b5c59b27de003","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from oslo_serialization import jsonutils"},{"line_number":36,"context_line":"from oslo_utils import encodeutils"},{"line_number":37,"context_line":"import six"},{"line_number":38,"context_line":"import requests"},{"line_number":39,"context_line":"import webob"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from nova.api.metadata import base"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_86f6df8c","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"updated":"2017-03-06 08:02:38.000000000","message":"It should be just after line 36.","commit_id":"c65a21c04510deea3d0e4a4927d8b9649d01ca5f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"391113fa75ed4eb02d15fcc9264f0495b421dccf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from oslo_serialization import jsonutils"},{"line_number":36,"context_line":"from oslo_utils import encodeutils"},{"line_number":37,"context_line":"import six"},{"line_number":38,"context_line":"import requests"},{"line_number":39,"context_line":"import webob"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from nova.api.metadata import base"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_e96cbcd1","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":15},"in_reply_to":"ba2be162_86f6df8c","updated":"2017-03-06 14:50:17.000000000","message":"Done","commit_id":"c65a21c04510deea3d0e4a4927d8b9649d01ca5f"}],"test-requirements.txt":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"707dc84e6eba117f04dcfaa7f5f70b221983ad99","unresolved":false,"context_lines":[{"line_number":6,"context_line":"coverage\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":9,"context_line":"flake8-import-order\u003d\u003d0.11 # LGPLv3"},{"line_number":10,"context_line":"mock\u003e\u003d2.0 # BSD"},{"line_number":11,"context_line":"mox3!\u003d0.19.0,\u003e\u003d0.7.0 # Apache-2.0"},{"line_number":12,"context_line":"psycopg2\u003e\u003d2.5 # LGPL/ZPL"}],"source_content_type":"text/plain","patch_set":5,"id":"9a30ddce_9306f21e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":25},"updated":"2017-03-07 10:24:16.000000000","message":"matches global requirements it seems:\nhttps://github.com/openstack/requirements/blob/6d23ef71578d01fbc68aa79da902a66d62260383/global-requirements.txt#L423","commit_id":"66866b3ce663b3039d734eb457bbf60c147e5782"}]}