)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"11f06f07830057e7727f30b1ae24604145f3146e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerrit Code Review \u003creview@openstack.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-21 07:27:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle case when there are no hosts in cluster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there are no hosts defined in a cluster the host value will be an empty"},{"line_number":10,"context_line":"string. For example:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAS3%2F%2FjFc%3D","line":7,"updated":"2013-09-24 20:41:32.000000000","message":"Fixes problems in fake.py? Fixes problems with test objects not mimicking vSphere objects properly?\n\nI don\u0027t understand this patch.","commit_id":"73ae2b2ea0d4254513f1f46bbebc6980ee58424f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e42b55a8623faf5dec9223e1e6ed1ac79061a372","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerrit Code Review \u003creview@openstack.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-21 07:27:45 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Handle case when there are no hosts in cluster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When there are no hosts defined in a cluster the host value will be an empty"},{"line_number":10,"context_line":"string. For example:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAS3%2F%2FXOI%3D","line":7,"in_reply_to":"AAAAS3%2F%2FjFc%3D","updated":"2013-09-28 07:42:23.000000000","message":"Please see the bugs below hopefully that will help clarify the issues","commit_id":"73ae2b2ea0d4254513f1f46bbebc6980ee58424f"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"86231704a822b8b3a1d66731e3ed5ee121ed3a9f","unresolved":false,"context_lines":[{"line_number":817,"context_line":"        host_ret \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":818,"context_line":"                                        cluster, \"ClusterComputeResource\","},{"line_number":819,"context_line":"                                        \"host\")"},{"line_number":820,"context_line":"        if not host_ret:"},{"line_number":821,"context_line":"            return"},{"line_number":822,"context_line":"        if not host_ret.ManagedObjectReference:"},{"line_number":823,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FjF0%3D","line":820,"updated":"2013-09-24 20:39:33.000000000","message":"can you explain why \"if not host_ret\" versus \"if host_ret is None\" warrants a patch? I don\u0027t see much of a reason for this.","commit_id":"73ae2b2ea0d4254513f1f46bbebc6980ee58424f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fee829df5a4f61444b730472d6489a0a95bcc05b","unresolved":false,"context_lines":[{"line_number":817,"context_line":"        host_ret \u003d session._call_method(vim_util, \"get_dynamic_property\","},{"line_number":818,"context_line":"                                        cluster, \"ClusterComputeResource\","},{"line_number":819,"context_line":"                                        \"host\")"},{"line_number":820,"context_line":"        if not host_ret:"},{"line_number":821,"context_line":"            return"},{"line_number":822,"context_line":"        if not host_ret.ManagedObjectReference:"},{"line_number":823,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FXOc%3D","line":820,"in_reply_to":"AAAAS3%2F%2FjF0%3D","updated":"2013-09-28 07:38:41.000000000","message":"When there is no host in the cluster the value returned is \"\". So it you are checking if not None then this will not work.\nHence if not.","commit_id":"73ae2b2ea0d4254513f1f46bbebc6980ee58424f"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"922d5a871a00c853d62275f2c80cb50c34b3ef7a","unresolved":false,"context_lines":[{"line_number":827,"context_line":"                                        cluster, \"ClusterComputeResource\","},{"line_number":828,"context_line":"                                        \"host\")"},{"line_number":829,"context_line":"        if not host_ret or not host_ret.ManagedObjectReference:"},{"line_number":830,"context_line":"            msg \u003d _(\u0027No host no available on cluster\u0027)"},{"line_number":831,"context_line":"            raise exception.NoValidHost(reason\u003dmsg)"},{"line_number":832,"context_line":"        host_mor \u003d host_ret.ManagedObjectReference[0]"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FR8g%3D","line":830,"updated":"2013-09-30 23:27:20.000000000","message":"nit: \"host no\" -\u003e \"host\"","commit_id":"5a0b2738167aa533cf61fdff99f74709de662d71"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"271f67b15d1fc9298b7af0ef045e6e7d18f2496d","unresolved":false,"context_lines":[{"line_number":827,"context_line":"                                        cluster, \"ClusterComputeResource\","},{"line_number":828,"context_line":"                                        \"host\")"},{"line_number":829,"context_line":"        if not host_ret or not host_ret.ManagedObjectReference:"},{"line_number":830,"context_line":"            msg \u003d _(\u0027No host no available on cluster\u0027)"},{"line_number":831,"context_line":"            raise exception.NoValidHost(reason\u003dmsg)"},{"line_number":832,"context_line":"        host_mor \u003d host_ret.ManagedObjectReference[0]"},{"line_number":833,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAS3%2F%2FRe8%3D","line":830,"in_reply_to":"AAAAS3%2F%2FR8g%3D","updated":"2013-10-01 04:45:16.000000000","message":"Done","commit_id":"5a0b2738167aa533cf61fdff99f74709de662d71"}]}