)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"178917414165c9b6995c1f767809054b93451a60","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fix ensure_vlan_bridge to work properly with existing DVS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With Nova Flat Network, if the DVS exists, we should not try to"},{"line_number":10,"context_line":"worry about virtual switches or port groups. We should just return"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ensure_vlan_bridge was also missing the return at tne end of the"},{"line_number":13,"context_line":"method, added that as well"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2F%2Fdc%3D","line":10,"updated":"2013-08-27 04:55:54.000000000","message":"we should just return what? Perhaps add a period \"return the network_ref\"","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2282a666c47aa0605c02846d008417531b3bef73","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VMware: Fix ensure_vlan_bridge to work properly with existing DVS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With Nova Flat Network, if the DVS exists, we should not try to"},{"line_number":10,"context_line":"worry about virtual switches or port groups. We should just return"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ensure_vlan_bridge was also missing the return at tne end of the"},{"line_number":13,"context_line":"method, added that as well"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2F9EQ%3D","line":10,"in_reply_to":"AAAASn%2F%2F%2Fdc%3D","updated":"2013-08-27 15:50:32.000000000","message":"Done","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"178917414165c9b6995c1f767809054b93451a60","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With Nova Flat Network, if the DVS exists, we should not try to"},{"line_number":10,"context_line":"worry about virtual switches or port groups. We should just return"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ensure_vlan_bridge was also missing the return at tne end of the"},{"line_number":13,"context_line":"method, added that as well"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixes LP# 1194018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2F%2FdY%3D","line":12,"updated":"2013-08-27 04:55:54.000000000","message":"s/tne/the\n\nI\u0027m not entirely sure this was missing per se. No harm in returning it but where is the return value needed?","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2282a666c47aa0605c02846d008417531b3bef73","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With Nova Flat Network, if the DVS exists, we should not try to"},{"line_number":10,"context_line":"worry about virtual switches or port groups. We should just return"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ensure_vlan_bridge was also missing the return at tne end of the"},{"line_number":13,"context_line":"method, added that as well"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixes LP# 1194018"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2F9EM%3D","line":12,"in_reply_to":"AAAASn%2F%2F%2FdY%3D","updated":"2013-08-27 15:50:32.000000000","message":"Done","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"}],"nova/tests/virt/vmwareapi/test_vmwareapi_vif.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"178917414165c9b6995c1f767809054b93451a60","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.mox.StubOutWithMock(network_util, \u0027get_network_with_the_name\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        network_util.get_network_with_the_name(self.session, \u0027fa0\u0027,"},{"line_number":96,"context_line":"            self.cluster).AndReturn(network_ref)"},{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F%2FdE%3D","line":96,"updated":"2013-08-27 04:55:54.000000000","message":"Won\u0027t this return a network_ref even if the type isn\u0027t DistributedVirtualPortgroup? (with your return on the last line).\n\nAs such I\u0027m not sure this is strictly speaking testing the right thing.","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2282a666c47aa0605c02846d008417531b3bef73","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.mox.StubOutWithMock(network_util, \u0027get_network_with_the_name\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        network_util.get_network_with_the_name(self.session, \u0027fa0\u0027,"},{"line_number":96,"context_line":"            self.cluster).AndReturn(network_ref)"},{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Ec%3D","line":96,"in_reply_to":"AAAASn%2F%2F%2BAE%3D","updated":"2013-08-27 15:50:32.000000000","message":"right.","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dd08ff37a3a529b863b39cee8cd3d988d4a39406","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.mox.StubOutWithMock(network_util, \u0027get_network_with_the_name\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        network_util.get_network_with_the_name(self.session, \u0027fa0\u0027,"},{"line_number":96,"context_line":"            self.cluster).AndReturn(network_ref)"},{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F%2BAE%3D","line":96,"in_reply_to":"AAAASn%2F%2F%2FdE%3D","updated":"2013-08-27 12:35:14.000000000","message":"I think that this is testing the correct thing - that is, if the type is DistributedVirtualPortgroup the the function should return the network_ref","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"d54d9fcee5fe11a171f506827bf5d0fe7910ba4c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.mox.StubOutWithMock(network_util, \u0027get_network_with_the_name\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        network_util.get_network_with_the_name(self.session, \u0027fa0\u0027,"},{"line_number":96,"context_line":"            self.cluster).AndReturn(network_ref)"},{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F4j0%3D","line":96,"in_reply_to":"AAAASn%2F%2F7Ac%3D","updated":"2013-08-28 12:54:17.000000000","message":"I see what you are saying. I\u0027ve made changes such that if the other methods get called then we will log an error. see http://stylishtoupee.blogspot.com/2013/06/assert-method-is-not-called-using-mox.html for detail on setting up an assert to ensure that methods are not called using Mox","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"5f97e26b4a4f4fd1d4e03f8978c56fa3d65f11a7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        self.mox.StubOutWithMock(network_util, \u0027get_network_with_the_name\u0027)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        network_util.get_network_with_the_name(self.session, \u0027fa0\u0027,"},{"line_number":96,"context_line":"            self.cluster).AndReturn(network_ref)"},{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F7Ac%3D","line":96,"in_reply_to":"AAAASn%2F%2F9Ec%3D","updated":"2013-08-27 23:00:47.000000000","message":"I\u0027m still not convinced. ensure_vlan_bridge returns network_ref regardless of type. It is impossible to tell if it has been returned because of its type or because it has finished setting up the bridge. I feel like this test should ensure that the bridge is not set up incorrectly.","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"dd08ff37a3a529b863b39cee8cd3d988d4a39406","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"},{"line_number":100,"context_line":"                                     create_vlan\u003dFalse)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_get_network_ref_neutron(self):"},{"line_number":103,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_neutron_network\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F%2BAA%3D","line":100,"updated":"2013-08-27 12:35:14.000000000","message":"Maybe check here that the ref is what is expected","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"2282a666c47aa0605c02846d008417531b3bef73","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.mox.ReplayAll()"},{"line_number":98,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":99,"context_line":"                                     self.vif,"},{"line_number":100,"context_line":"                                     create_vlan\u003dFalse)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_get_network_ref_neutron(self):"},{"line_number":103,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_neutron_network\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAASn%2F%2F9Ew%3D","line":100,"in_reply_to":"AAAASn%2F%2F%2BAA%3D","updated":"2013-08-27 15:50:32.000000000","message":"Done","commit_id":"01cb55e472366db0c64094f666dc62201aa87b5e"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cf9d20edbc9a06bc5f582d04e5aa36a678233aca","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":105,"context_line":"                                     self.vif,"},{"line_number":106,"context_line":"                                     create_vlan\u003dFalse)"},{"line_number":107,"context_line":"        self.assertThat(ref, matchers.DictMatches(network_ref))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_get_network_ref_neutron(self):"},{"line_number":110,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_neutron_network\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2F0uA%3D","line":107,"updated":"2013-08-29 04:33:45.000000000","message":"I might be wrong here but according to that link you sent me (http://stylishtoupee.blogspot.com.au/2013/06/assert-method-is-not-called-using-mox.html) I think you still need your self.mox.VerifyAll()?","commit_id":"ab360f1dd5489227a300672e570c3551a3099fe7"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"df331778c672f000bfd5c6c1d36a754af73769d9","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":105,"context_line":"                                     self.vif,"},{"line_number":106,"context_line":"                                     create_vlan\u003dFalse)"},{"line_number":107,"context_line":"        self.assertThat(ref, matchers.DictMatches(network_ref))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_get_network_ref_neutron(self):"},{"line_number":110,"context_line":"        self.mox.StubOutWithMock(vif, \u0027get_neutron_network\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fzfo%3D","line":107,"in_reply_to":"AAAASn%2F%2F0uA%3D","updated":"2013-08-29 10:43:06.000000000","message":"@Joshua, it\u0027s already there in the tearDown - https://github.com/openstack/nova/blob/master/nova/test.py#L191","commit_id":"ab360f1dd5489227a300672e570c3551a3099fe7"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8680b968ec4b15774cba9795f189cd0478baf6ef","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    network_ref \u003d network_util.get_network_with_the_name(session, bridge,"},{"line_number":48,"context_line":"                                                         cluster)"},{"line_number":49,"context_line":"    if network_ref and network_ref[\u0027type\u0027] \u003d\u003d \u0027DistributedVirtualPortgroup\u0027:"},{"line_number":50,"context_line":"        return network_ref"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Get the vSwitch associated with the Physical Adapter"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwHw%3D","line":49,"updated":"2013-08-30 01:29:21.000000000","message":"You can also return (if network_ref and not create_vlan). Please consider adding this clause appropriately.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"38ca0fa75d6032f7d50361633d5a85ad85c6c93f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    network_ref \u003d network_util.get_network_with_the_name(session, bridge,"},{"line_number":48,"context_line":"                                                         cluster)"},{"line_number":49,"context_line":"    if network_ref and network_ref[\u0027type\u0027] \u003d\u003d \u0027DistributedVirtualPortgroup\u0027:"},{"line_number":50,"context_line":"        return network_ref"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Get the vSwitch associated with the Physical Adapter"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwFE%3D","line":49,"in_reply_to":"AAAASn%2F%2FwGQ%3D","updated":"2013-08-30 01:44:54.000000000","message":"No Issues. FYI logically speaking if network_ref is true \u0026 create_vlan is False, you will end up executing only the code path from L52 - L62 which is of no concern to nova-network on Flat mode if the network already exists. If you do not wish to make the change I am ok with it too.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6aede5a4cae214ff09c2347a902d0d8648ce3564","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    network_ref \u003d network_util.get_network_with_the_name(session, bridge,"},{"line_number":48,"context_line":"                                                         cluster)"},{"line_number":49,"context_line":"    if network_ref and network_ref[\u0027type\u0027] \u003d\u003d \u0027DistributedVirtualPortgroup\u0027:"},{"line_number":50,"context_line":"        return network_ref"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Get the vSwitch associated with the Physical Adapter"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwGQ%3D","line":49,"in_reply_to":"AAAASn%2F%2FwHw%3D","updated":"2013-08-30 01:38:14.000000000","message":"Sabari, i was using just Nova Network w/o vlans So i am not comfortable making this change. I don\u0027t want it to create stuff as everything i need is already set up.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8680b968ec4b15774cba9795f189cd0478baf6ef","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwHs%3D","line":69,"updated":"2013-08-30 01:29:21.000000000","message":"You also need to call network_util.get_network_with_name and assign value to network_ref. Else L92 will be None.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6aede5a4cae214ff09c2347a902d0d8648ce3564","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"},{"line_number":72,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwGI%3D","line":69,"in_reply_to":"AAAASn%2F%2FwHs%3D","updated":"2013-08-30 01:38:14.000000000","message":"will do","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8680b968ec4b15774cba9795f189cd0478baf6ef","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                           pgroup\u003dpg_vlanid)"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        if network_ref is None:"},{"line_number":89,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":90,"context_line":"                                       vswitch_associated, 0,"},{"line_number":91,"context_line":"                                       cluster)"},{"line_number":92,"context_line":"    return network_ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwHk%3D","line":89,"updated":"2013-08-30 01:29:21.000000000","message":"Same Here. You also need to call network_util.get_network_with_name again and assign value to network_ref. Else L92 will be None.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6aede5a4cae214ff09c2347a902d0d8648ce3564","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                           pgroup\u003dpg_vlanid)"},{"line_number":87,"context_line":"    else:"},{"line_number":88,"context_line":"        if network_ref is None:"},{"line_number":89,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":90,"context_line":"                                       vswitch_associated, 0,"},{"line_number":91,"context_line":"                                       cluster)"},{"line_number":92,"context_line":"    return network_ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwGE%3D","line":89,"in_reply_to":"AAAASn%2F%2FwHk%3D","updated":"2013-08-30 01:38:14.000000000","message":"will do","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8680b968ec4b15774cba9795f189cd0478baf6ef","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        CONF.vmware.integration_bridge)"},{"line_number":127,"context_line":"        network_ref \u003d get_neutron_network(session, network_name, cluster, vif)"},{"line_number":128,"context_line":"    else:"},{"line_number":129,"context_line":"        create_vlan \u003d vif[\u0027network\u0027].get_meta(\u0027should_create_vlan\u0027, False)"},{"line_number":130,"context_line":"        network_ref \u003d ensure_vlan_bridge(session, vif, cluster\u003dcluster,"},{"line_number":131,"context_line":"                                         create_vlan\u003dcreate_vlan)"},{"line_number":132,"context_line":"    return network_ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwHc%3D","line":129,"updated":"2013-08-30 01:29:21.000000000","message":"Ideally ensure_vlan_bridge should not return a network_ref. it should only ensure that the port-group has been setup properly depending on the network manager. Renaming the method is outside the scope of this patch. But please address some of the comments in ensure_vlan_bridge.","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6aede5a4cae214ff09c2347a902d0d8648ce3564","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                        CONF.vmware.integration_bridge)"},{"line_number":127,"context_line":"        network_ref \u003d get_neutron_network(session, network_name, cluster, vif)"},{"line_number":128,"context_line":"    else:"},{"line_number":129,"context_line":"        create_vlan \u003d vif[\u0027network\u0027].get_meta(\u0027should_create_vlan\u0027, False)"},{"line_number":130,"context_line":"        network_ref \u003d ensure_vlan_bridge(session, vif, cluster\u003dcluster,"},{"line_number":131,"context_line":"                                         create_vlan\u003dcreate_vlan)"},{"line_number":132,"context_line":"    return network_ref"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAASn%2F%2FwGA%3D","line":129,"in_reply_to":"AAAASn%2F%2FwHc%3D","updated":"2013-08-30 01:38:14.000000000","message":"agree to leave the name alone. yes, will add the the 2 get_network_with_name","commit_id":"eb6248562163ed907177506ef3dc12dd681faf3c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3c4545b8234e5d7a5fa41fb5612eda2ad183a805","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if network_ref is None:"},{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAASn%2F%2Fur0%3D","line":68,"updated":"2013-08-30 10:16:03.000000000","message":"lines 69-74 and 92-97 are the same and may be combined into a utility function.","commit_id":"4763948f2c6ef22ddb8edcb4372e62c911c5ab6a"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"5f4e2d57d79612c89a6f316c2e8f09af0b55b94d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if network_ref is None:"},{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAASn%2F%2FasM%3D","line":68,"in_reply_to":"AAAASn%2F%2FbJk%3D","updated":"2013-09-04 23:26:10.000000000","message":"Thanks guys, i\u0027ve restructured the if conditions to eliminate the duplicate code.","commit_id":"4763948f2c6ef22ddb8edcb4372e62c911c5ab6a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d18532894c3d9e35e0e489c26cf7322f78cb17f0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if network_ref is None:"},{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAASn%2F%2FbJk%3D","line":68,"in_reply_to":"AAAASn%2F%2FssM%3D","updated":"2013-09-04 21:47:27.000000000","message":"Agreed","commit_id":"4763948f2c6ef22ddb8edcb4372e62c911c5ab6a"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"ac48feef3d3eb574e461fcdc1e411d1e368031db","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if network_ref is None:"},{"line_number":66,"context_line":"        # Create a port group on the vSwitch associated with the"},{"line_number":67,"context_line":"        # vlan_interface corresponding physical network adapter on the ESX"},{"line_number":68,"context_line":"        # host."},{"line_number":69,"context_line":"            network_util.create_port_group(session, bridge,"},{"line_number":70,"context_line":"                                       vswitch_associated, vlan_num,"},{"line_number":71,"context_line":"                                       cluster)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAASn%2F%2FssM%3D","line":68,"in_reply_to":"AAAASn%2F%2Fur0%3D","updated":"2013-08-30 18:32:02.000000000","message":"Yup, if possible.","commit_id":"4763948f2c6ef22ddb8edcb4372e62c911c5ab6a"}]}
