)]}'
{"nova/tests/unit/virt/vmwareapi/test_vif.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"43ea849dbee5f8fe0dfcc4dfe47670dac6d3ab29","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                             mock_get_network_with_name"},{"line_number":118,"context_line":"                                             ):"},{"line_number":119,"context_line":"        vm_network \u003d {\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027}"},{"line_number":120,"context_line":"        mock_get_network_with_name.return_value \u003d vm_network"},{"line_number":121,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":122,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":123,"context_line":"                                                           \u0027fa0\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_a8320a0e","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":47},"updated":"2017-02-23 19:20:54.000000000","message":"So this is inconsistent with other return value that you used above in the decorators. I personally like this way. Anyways either others or this one to be consistent.","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"56050a958535d8b18160a96f819a278f680ef328","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                             mock_get_network_with_name"},{"line_number":118,"context_line":"                                             ):"},{"line_number":119,"context_line":"        vm_network \u003d {\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027}"},{"line_number":120,"context_line":"        mock_get_network_with_name.return_value \u003d vm_network"},{"line_number":121,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":122,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":123,"context_line":"                                                           \u0027fa0\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_bbc73644","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":47},"in_reply_to":"da36d5c6_085f230f","updated":"2017-03-07 17:09:13.000000000","message":"This is too big for a decorator really. Honestly my preference is for always assigning the return_value in the body of the code.","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"6b8053c234d50fdb85d4b0a4962d90d1abf0e4ea","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                             mock_get_network_with_name"},{"line_number":118,"context_line":"                                             ):"},{"line_number":119,"context_line":"        vm_network \u003d {\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027}"},{"line_number":120,"context_line":"        mock_get_network_with_name.return_value \u003d vm_network"},{"line_number":121,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":122,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":123,"context_line":"                                                           \u0027fa0\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_ecefac84","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":47},"in_reply_to":"da36d5c6_a8320a0e","updated":"2017-02-23 22:49:04.000000000","message":"vm_network is assigned a value in the method, so i can\u0027t return the value in the decorator. That\u0027s why added this line in here.","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3afcf1144a815e53845ac10cfb837087052ebdd3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                             mock_get_network_with_name"},{"line_number":118,"context_line":"                                             ):"},{"line_number":119,"context_line":"        vm_network \u003d {\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027}"},{"line_number":120,"context_line":"        mock_get_network_with_name.return_value \u003d vm_network"},{"line_number":121,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":122,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":123,"context_line":"                                                           \u0027fa0\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_085f230f","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":47},"in_reply_to":"da36d5c6_e3e969b8","updated":"2017-02-28 07:13:30.000000000","message":"For example,\n\n    @mock.patch.object(network_util, \u0027get_network_with_the_name\u0027,\n                       return_value\u003d{\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027})\n    @mock.patch.object(network_util, \u0027get_vswitch_for_vlan_interface\u0027)\n    @mock.patch.object(network_util, \u0027check_if_vlan_interface_exists\u0027)\n    @mock.patch.object(network_util, \u0027create_port_group\u0027)\n    def test_ensure_vlan_bridge_with_network(self,\n...","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"9ec554e6754fda1166b50d721712a2be69fcdf8c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                             mock_get_network_with_name"},{"line_number":118,"context_line":"                                             ):"},{"line_number":119,"context_line":"        vm_network \u003d {\u0027name\u0027: \u0027VM Network\u0027, \u0027type\u0027: \u0027Network\u0027}"},{"line_number":120,"context_line":"        mock_get_network_with_name.return_value \u003d vm_network"},{"line_number":121,"context_line":"        vif.ensure_vlan_bridge(self.session, self.vif, create_vlan\u003dFalse)"},{"line_number":122,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":123,"context_line":"                                                           \u0027fa0\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_e3e969b8","line":120,"range":{"start_line":120,"start_character":35,"end_line":120,"end_character":47},"in_reply_to":"da36d5c6_ecefac84","updated":"2017-02-24 15:02:09.000000000","message":"So just to be consistent why not change other methods to like this, return value within method and not in decorator?","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"43ea849dbee5f8fe0dfcc4dfe47670dac6d3ab29","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                             ):"},{"line_number":140,"context_line":"        network_ref \u003d {\u0027dvpg\u0027: \u0027dvportgroup-2062\u0027,"},{"line_number":141,"context_line":"                       \u0027type\u0027: \u0027DistributedVirtualPortgroup\u0027}"},{"line_number":142,"context_line":"        mock_get_network_with_name.return_value \u003d network_ref"},{"line_number":143,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":144,"context_line":"                                     self.vif,"},{"line_number":145,"context_line":"                                     create_vlan\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_48242ec4","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":47},"updated":"2017-02-23 19:20:54.000000000","message":"same","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3afcf1144a815e53845ac10cfb837087052ebdd3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                             ):"},{"line_number":140,"context_line":"        network_ref \u003d {\u0027dvpg\u0027: \u0027dvportgroup-2062\u0027,"},{"line_number":141,"context_line":"                       \u0027type\u0027: \u0027DistributedVirtualPortgroup\u0027}"},{"line_number":142,"context_line":"        mock_get_network_with_name.return_value \u003d network_ref"},{"line_number":143,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":144,"context_line":"                                     self.vif,"},{"line_number":145,"context_line":"                                     create_vlan\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_a8c37789","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":47},"in_reply_to":"da36d5c6_2ce624b0","updated":"2017-02-28 07:13:30.000000000","message":"IMO, it need not be changed.\nBecause \u0027network_ref\u0027 is used in line 147.","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"6b8053c234d50fdb85d4b0a4962d90d1abf0e4ea","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                                             ):"},{"line_number":140,"context_line":"        network_ref \u003d {\u0027dvpg\u0027: \u0027dvportgroup-2062\u0027,"},{"line_number":141,"context_line":"                       \u0027type\u0027: \u0027DistributedVirtualPortgroup\u0027}"},{"line_number":142,"context_line":"        mock_get_network_with_name.return_value \u003d network_ref"},{"line_number":143,"context_line":"        ref \u003d vif.ensure_vlan_bridge(self.session,"},{"line_number":144,"context_line":"                                     self.vif,"},{"line_number":145,"context_line":"                                     create_vlan\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_2ce624b0","line":142,"range":{"start_line":142,"start_character":35,"end_line":142,"end_character":47},"in_reply_to":"da36d5c6_48242ec4","updated":"2017-02-23 22:49:04.000000000","message":"same comment as above","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"3afcf1144a815e53845ac10cfb837087052ebdd3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                                     self.vif,"},{"line_number":145,"context_line":"                                     create_vlan\u003dFalse)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertThat(ref, matchers.DictMatches(network_ref))"},{"line_number":148,"context_line":"        mock_get_network_with_name.assert_called_once_with(self.session,"},{"line_number":149,"context_line":"                                                           \u0027fa0\u0027,"},{"line_number":150,"context_line":"                                                           self.cluster)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_48d4bb46","line":147,"range":{"start_line":147,"start_character":50,"end_line":147,"end_character":61},"updated":"2017-02-28 07:13:30.000000000","message":"\u0027network_ref\u0027 is used here.","commit_id":"87b881c019eb985313f7c4e323c8da6934beb4b9"}]}