)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"8ebe30e39d43421b0c2e2a70fa9a0a5880fad968","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-30 03:20:14 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Validate the returned object data prior to accessing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There may be cases when the call to RetrievePropertiesEx may have missing"},{"line_number":10,"context_line":"data. That is, the propSet field may be missing. In this case the missing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2FTVg%3D","line":7,"updated":"2013-09-06 18:23:17.000000000","message":"Nit: bug/1215958 title says \"vim_util get_dynamic_property propSet need not be set\" \n\nConsider:\nObjectContent attribute propSet need not be set.\n\nOr:\nCheck for the propSet attribute\u0027s existence before using.\n\nThe propSet attribute is marked as optional in the API documentation so this should have been anticipated and this can be interpreted as a bug in the client code.\n\nhttp://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vmodl.query.PropertyCollector.ObjectContent.html","commit_id":"c756a289b6c194d0e7c77cd6f4138f72c99b12a0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"18c76f091fc28c7335138e5a788cba01901fd327","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-30 03:20:14 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Validate the returned object data prior to accessing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There may be cases when the call to RetrievePropertiesEx may have missing"},{"line_number":10,"context_line":"data. That is, the propSet field may be missing. In this case the missing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2FRa0%3D","line":7,"in_reply_to":"AAAASn%2F%2FTVg%3D","updated":"2013-09-08 09:55:59.000000000","message":"Done","commit_id":"c756a289b6c194d0e7c77cd6f4138f72c99b12a0"}],"nova/tests/virt/vmwareapi/test_vmwareapi_vim_util.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"92d1d982d971ab03826baeb8ac177200d561cb82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2013 Canonical Corp."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2Fs6M%3D","line":4,"updated":"2013-09-20 23:44:44.000000000","message":"I don\u0027t understand these copyright lines. You work for vmware, right?","commit_id":"34923237df1537f460a528cce0919abc4721df7e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"759145068b08e3813a6d83198d577dec5d991fbc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2013 Canonical Corp."},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2Fsg8%3D","line":4,"in_reply_to":"AAAAS3%2F%2Fs6M%3D","updated":"2013-09-21 07:37:59.000000000","message":":) Copy paste.","commit_id":"34923237df1537f460a528cce0919abc4721df7e"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"32eb365c3357fff71aba5368a46a16ebf91a94fa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mox"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from nova import test"},{"line_number":20,"context_line":"from nova.virt.vmwareapi import fake"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FjGs%3D","line":17,"updated":"2013-09-24 20:37:15.000000000","message":"aren\u0027t we supposed to be using mock now?\n\nhttp://openstack.10931.n7.nabble.com/Usage-of-mox-through-out-the-Openstack-project-td16223.html","commit_id":"459e565d6a8bf68596ad5e472b01f89319fbd222"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"b00ff5f4f6d590519da597de7a140383e60a3668","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mox"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from nova import test"},{"line_number":20,"context_line":"from nova.virt.vmwareapi import fake"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAS3%2F%2FdYk%3D","line":17,"in_reply_to":"AAAAS3%2F%2FjGs%3D","updated":"2013-09-26 11:32:07.000000000","message":"I\u0027d much rather fixtures to be honest...","commit_id":"459e565d6a8bf68596ad5e472b01f89319fbd222"}],"nova/virt/vmwareapi/vim_util.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"e546465b68570a03fb2a5ea28a6aa7ac0ce37c25","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        vim.CancelRetrievePropertiesEx(token\u003dobj_content.token)"},{"line_number":176,"context_line":"    property_value \u003d None"},{"line_number":177,"context_line":"    if obj_content.objects:"},{"line_number":178,"context_line":"        if hasattr(obj_content.objects[0], \u0027propSet\u0027):"},{"line_number":179,"context_line":"            dynamic_property \u003d obj_content.objects[0].propSet"},{"line_number":180,"context_line":"            if dynamic_property:"},{"line_number":181,"context_line":"                property_value \u003d dynamic_property[0].val"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2F8qw%3D","line":178,"updated":"2013-08-27 16:57:42.000000000","message":"minor nit: (non-blocking)\n\nhere is the old [0] again. This keeps biting us in other places. So much so that I have to insist that when you use it that you justify why [0] is okay.\n\nIn this case, it\u0027s okay because there will only be 1 object in the result set... but you won\u0027t know that unless you read the documentation then infer that the doc at the top of this method is slightly wrong.\n\nPlease tell us why [0] is okay here.","commit_id":"4194a148af888cf94c3a3bd183e547a24b0e5a88"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c4f249e991965cca61e4dc68d36b51ffd0515ba0","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        vim.CancelRetrievePropertiesEx(token\u003dobj_content.token)"},{"line_number":176,"context_line":"    property_value \u003d None"},{"line_number":177,"context_line":"    if obj_content.objects:"},{"line_number":178,"context_line":"        if hasattr(obj_content.objects[0], \u0027propSet\u0027):"},{"line_number":179,"context_line":"            dynamic_property \u003d obj_content.objects[0].propSet"},{"line_number":180,"context_line":"            if dynamic_property:"},{"line_number":181,"context_line":"                property_value \u003d dynamic_property[0].val"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2F46o%3D","line":178,"in_reply_to":"AAAASn%2F%2F8qw%3D","updated":"2013-08-28 11:33:01.000000000","message":"The object.contents is an array. Line 177 checks that the array is not empty. So accessing the first entry in the array is legitimate. I am not really sure that I understand your comment here. I think that when we are accessing the first and only element in an array the we can use [0].","commit_id":"4194a148af888cf94c3a3bd183e547a24b0e5a88"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"e546465b68570a03fb2a5ea28a6aa7ac0ce37c25","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                property_value \u003d dynamic_property[0].val"},{"line_number":182,"context_line":"        else:"},{"line_number":183,"context_line":"            # The object may have information useful for logging"},{"line_number":184,"context_line":"            if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":185,"context_line":"                paths \u003d []"},{"line_number":186,"context_line":"                for missing_elem in obj_content.objects[0].missingSet:"},{"line_number":187,"context_line":"                    paths.append(missing_elem.path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2F8qY%3D","line":184,"updated":"2013-08-27 16:57:42.000000000","message":"missingSet and propSet are not mutually exclusive. You should probably log this no matter what. (remove the \u0027else\u0027 statement)","commit_id":"4194a148af888cf94c3a3bd183e547a24b0e5a88"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c4f249e991965cca61e4dc68d36b51ffd0515ba0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                property_value \u003d dynamic_property[0].val"},{"line_number":182,"context_line":"        else:"},{"line_number":183,"context_line":"            # The object may have information useful for logging"},{"line_number":184,"context_line":"            if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":185,"context_line":"                paths \u003d []"},{"line_number":186,"context_line":"                for missing_elem in obj_content.objects[0].missingSet:"},{"line_number":187,"context_line":"                    paths.append(missing_elem.path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2F46g%3D","line":184,"in_reply_to":"AAAASn%2F%2F8qY%3D","updated":"2013-08-28 11:33:01.000000000","message":"Done","commit_id":"4194a148af888cf94c3a3bd183e547a24b0e5a88"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"57dd9fb1352ecd2e49153af8f39bc842ba9daaef","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # The object may have information useful for logging"},{"line_number":183,"context_line":"        if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":184,"context_line":"            paths \u003d []"},{"line_number":185,"context_line":"            for missing_elem in obj_content.objects[0].missingSet:"},{"line_number":186,"context_line":"                paths.append(missing_elem.path)"},{"line_number":187,"context_line":"            LOG.warning(_(\"Unable to retrieve value for the following \""},{"line_number":188,"context_line":"                          \"properties: %s\"), paths)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2Fz%2BY%3D","line":185,"updated":"2013-08-29 08:59:36.000000000","message":"IMO list comprehension will be better here","commit_id":"a632cbf7f8242d9ac250bf206f39f17c24905a65"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"66f5b8283231c6e850820e90ddc2b505355e4287","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # The object may have information useful for logging"},{"line_number":183,"context_line":"        if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":184,"context_line":"            paths \u003d []"},{"line_number":185,"context_line":"            for missing_elem in obj_content.objects[0].missingSet:"},{"line_number":186,"context_line":"                paths.append(missing_elem.path)"},{"line_number":187,"context_line":"            LOG.warning(_(\"Unable to retrieve value for the following \""},{"line_number":188,"context_line":"                          \"properties: %s\"), paths)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2Futk%3D","line":185,"in_reply_to":"AAAASn%2F%2Fz%2BY%3D","updated":"2013-08-30 10:06:55.000000000","message":"Done","commit_id":"a632cbf7f8242d9ac250bf206f39f17c24905a65"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"d8b27fd05bd8425c72bb730796557bcc56f8a0a7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":191,"context_line":"            paths \u003d [m.path for m in obj_content.objects[0].missingSet]"},{"line_number":192,"context_line":"            LOG.warning(_(\"Unable to retrieve value for the following \""},{"line_number":193,"context_line":"                          \"properties: %s\"), paths)"},{"line_number":194,"context_line":"    return property_dict"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAS3%2F%2FXwA%3D","line":193,"updated":"2013-09-27 22:51:31.000000000","message":"Suggestion :- m.fault.fault if exists can also be logged for more specific reason\nhttp://pubs.vmware.com/vsphere-51/index.jsp#com.vmware.wssdk.apiref.doc/vmodl.LocalizedMethodFault.html","commit_id":"54a30c11c5367db7fb2862c62a9f61b66ab46bc7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9e642308d00b7887559065f38c28b8e4e219322d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        if hasattr(obj_content.objects[0], \u0027missingSet\u0027):"},{"line_number":191,"context_line":"            paths \u003d [m.path for m in obj_content.objects[0].missingSet]"},{"line_number":192,"context_line":"            LOG.warning(_(\"Unable to retrieve value for the following \""},{"line_number":193,"context_line":"                          \"properties: %s\"), paths)"},{"line_number":194,"context_line":"    return property_dict"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAS3%2F%2FV%2FQ%3D","line":193,"in_reply_to":"AAAAS3%2F%2FXwA%3D","updated":"2013-09-29 09:48:28.000000000","message":"Done","commit_id":"54a30c11c5367db7fb2862c62a9f61b66ab46bc7"}]}
