)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0d020b7564cb3a8f2adeef5aa42f1733ff99b280","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pushkar Umaranikar \u003cpushkar.umaranikar@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-20 13:35:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Placement api: add tox check for webob wsgify decorator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we have added wrapper for webob wsgify in placement api in"},{"line_number":10,"context_line":"order to set custom json error formatter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_a32fd6f4","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":22},"updated":"2017-03-20 16:09:26.000000000","message":"It\u0027s rather a local hacking check than tox check.","commit_id":"286151857f7c8e6a104c7a46ece250d3c778323b"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0d020b7564cb3a8f2adeef5aa42f1733ff99b280","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Placement api: add tox check for webob wsgify decorator"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"we have added wrapper for webob wsgify in placement api in"},{"line_number":10,"context_line":"order to set custom json error formatter."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Hence, placement api resource handlers should use wsgi_wrapper.PlacementWsgify"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_03418aa9","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2017-03-20 16:09:26.000000000","message":"nit: W","commit_id":"286151857f7c8e6a104c7a46ece250d3c778323b"}],"HACKING.rst":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0d020b7564cb3a8f2adeef5aa42f1733ff99b280","unresolved":false,"context_lines":[{"line_number":66,"context_line":"- [N357] Use oslo_utils.uuidutils or uuidsentinel(in case of test cases) to"},{"line_number":67,"context_line":"  generate UUID instead of uuid4()."},{"line_number":68,"context_line":"- [N358] Return must always be followed by a space when returning a value."},{"line_number":69,"context_line":"- [N359] Ensure that wsgi_wrapper.PlacementWsgify decorator must be used instead of"},{"line_number":70,"context_line":"  webob.dec.wsgify for placement API handlers."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Creating Unit Tests"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a1ced50_a3cb561d","line":69,"range":{"start_line":69,"start_character":60,"end_line":69,"end_character":72},"updated":"2017-03-20 16:09:26.000000000","message":"\"is used\" is the correct form of this sentence.","commit_id":"286151857f7c8e6a104c7a46ece250d3c778323b"}],"nova/hacking/checks.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0d020b7564cb3a8f2adeef5aa42f1733ff99b280","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"def check_webob_wsgify_decorator(logical_line, filename):"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    msg \u003d (\"N359: Ensure that wsgi_wrapper.PlacementWsgify decorator must be\""},{"line_number":375,"context_line":"           \" used instead of webob.dec.wsgify for placement API handlers.\")"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    if \"nova/api/openstack/placement/handlers/\" in filename:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_83649a22","line":374,"range":{"start_line":374,"start_character":18,"end_line":374,"end_character":30},"updated":"2017-03-20 16:09:26.000000000","message":"I think you can delete \"Ensure that\" in this place.","commit_id":"286151857f7c8e6a104c7a46ece250d3c778323b"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0d020b7564cb3a8f2adeef5aa42f1733ff99b280","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    msg \u003d (\"N359: Ensure that wsgi_wrapper.PlacementWsgify decorator must be\""},{"line_number":375,"context_line":"           \" used instead of webob.dec.wsgify for placement API handlers.\")"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    if \"nova/api/openstack/placement/handlers/\" in filename:"},{"line_number":378,"context_line":"        res \u003d webob_wsgify_dec_re.match(logical_line)"},{"line_number":379,"context_line":"        if res:"},{"line_number":380,"context_line":"            yield(0, msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_3e4db96c","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":60},"updated":"2017-03-20 16:09:26.000000000","message":"I think you can negate this expression in if and return. It will lead to a better nesting level (even in this small function).","commit_id":"286151857f7c8e6a104c7a46ece250d3c778323b"}]}