)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0153a6bef7784410edcbf813678a522476f9b47","unresolved":false,"context_lines":[{"line_number":5340,"context_line":"            if ((caps.host.cpu.arch in archs) and"},{"line_number":5341,"context_line":"                    self._host.has_min_version(libvirt_ver,"},{"line_number":5342,"context_line":"                                               hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5343,"context_line":"                is_supported \u003d True"},{"line_number":5344,"context_line":"        return is_supported"},{"line_number":5345,"context_line":""},{"line_number":5346,"context_line":"    def _has_hugepage_support(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_f4288e97","side":"PARENT","line":5343,"updated":"2017-04-20 21:24:06.000000000","message":"Funny we didn\u0027t break the loop before.","commit_id":"68486deed2008fd99bb676ec890446422b9dc0b0"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"ce3bbf1aeeba67e4263482498c416cbc32665bd8","unresolved":false,"context_lines":[{"line_number":5327,"context_line":"        if (caps.host.cpu.arch in (fields.Architecture.I686,"},{"line_number":5328,"context_line":"                                   fields.Architecture.X86_64,"},{"line_number":5329,"context_line":"                                   fields.Architecture.AARCH64) and"},{"line_number":5330,"context_line":"                self._host.has_min_version(hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5331,"context_line":"            return True"},{"line_number":5332,"context_line":"        elif (caps.host.cpu.arch in (fields.Architecture.PPC64,"},{"line_number":5333,"context_line":"                                     fields.Architecture.PPC64LE) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_31cc4cbb","line":5330,"updated":"2017-04-06 12:17:08.000000000","message":"It looks like we don\u0027t need to call has_min_version here because of guaranty for MIN_LIBVIRT_VERSION.\nSo if it\u0027s I686, X86_64, AARCH64 than numa is supported.","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"33d8f97017df0ca55efaa1072eaa2410ce6af6fa","unresolved":false,"context_lines":[{"line_number":5327,"context_line":"        if (caps.host.cpu.arch in (fields.Architecture.I686,"},{"line_number":5328,"context_line":"                                   fields.Architecture.X86_64,"},{"line_number":5329,"context_line":"                                   fields.Architecture.AARCH64) and"},{"line_number":5330,"context_line":"                self._host.has_min_version(hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5331,"context_line":"            return True"},{"line_number":5332,"context_line":"        elif (caps.host.cpu.arch in (fields.Architecture.PPC64,"},{"line_number":5333,"context_line":"                                     fields.Architecture.PPC64LE) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_a7c30557","line":5330,"in_reply_to":"bff0334d_31cc4cbb","updated":"2017-04-10 22:59:14.000000000","message":"This is actually a flaw in the name of the function - we\u0027re not checking any version here. Rather. we\u0027re checking what hypervisor type we use. I can rename the function, but that\u0027d be a separate change","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d0153a6bef7784410edcbf813678a522476f9b47","unresolved":false,"context_lines":[{"line_number":5327,"context_line":"        if (caps.host.cpu.arch in (fields.Architecture.I686,"},{"line_number":5328,"context_line":"                                   fields.Architecture.X86_64,"},{"line_number":5329,"context_line":"                                   fields.Architecture.AARCH64) and"},{"line_number":5330,"context_line":"                self._host.has_min_version(hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5331,"context_line":"            return True"},{"line_number":5332,"context_line":"        elif (caps.host.cpu.arch in (fields.Architecture.PPC64,"},{"line_number":5333,"context_line":"                                     fields.Architecture.PPC64LE) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_cf005b04","line":5330,"in_reply_to":"bff0334d_a7c30557","updated":"2017-04-20 21:24:06.000000000","message":"Could have also left a code comment inline here, but I won\u0027t hold this up on it.","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"49393cdb5c7a0396671461902e583291748d9056","unresolved":false,"context_lines":[{"line_number":5327,"context_line":"        if (caps.host.cpu.arch in (fields.Architecture.I686,"},{"line_number":5328,"context_line":"                                   fields.Architecture.X86_64,"},{"line_number":5329,"context_line":"                                   fields.Architecture.AARCH64) and"},{"line_number":5330,"context_line":"                self._host.has_min_version(hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5331,"context_line":"            return True"},{"line_number":5332,"context_line":"        elif (caps.host.cpu.arch in (fields.Architecture.PPC64,"},{"line_number":5333,"context_line":"                                     fields.Architecture.PPC64LE) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_32cf2a57","line":5330,"in_reply_to":"bff0334d_a7c30557","updated":"2017-04-11 06:49:42.000000000","message":"Oh, I see. Probably some clarification in function naming would be good.","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"}]}