)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e28cfc2718fd5dee7d9a72f136acbbd9e5db8e6","unresolved":false,"context_lines":[{"line_number":5324,"context_line":""},{"line_number":5325,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"        if (caps.host.cpu.arch in (fields.Architecture.I686,"},{"line_number":5328,"context_line":"                                   fields.Architecture.X86_64,"},{"line_number":5329,"context_line":"                                   fields.Architecture.AARCH64) and"},{"line_number":5330,"context_line":"                self._host.has_min_version(hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5331,"context_line":"            return True"},{"line_number":5332,"context_line":"        elif (caps.host.cpu.arch in (fields.Architecture.PPC64,"},{"line_number":5333,"context_line":"                                     fields.Architecture.PPC64LE) and"},{"line_number":5334,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_NUMA_VERSION_PPC,"},{"line_number":5335,"context_line":"                                           hv_type\u003dhost.HV_DRIVER_QEMU)):"},{"line_number":5336,"context_line":"            return True"},{"line_number":5337,"context_line":""},{"line_number":5338,"context_line":"        return False"},{"line_number":5339,"context_line":""},{"line_number":5340,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5341,"context_line":"        # This means that the host can support multiple values for the size"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_a375cd98","side":"PARENT","line":5338,"range":{"start_line":5327,"start_character":0,"end_line":5338,"end_character":20},"updated":"2017-02-23 19:23:54.000000000","message":"This evaluates to:\n\n    HV type \u003d QEMU\n    LV type in [Intel, ARM64, PPC]\n\nand, for LV \u003d PPC only:\n\n    LV version \u003d something specific","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2e28cfc2718fd5dee7d9a72f136acbbd9e5db8e6","unresolved":false,"context_lines":[{"line_number":5337,"context_line":""},{"line_number":5338,"context_line":"        return False"},{"line_number":5339,"context_line":""},{"line_number":5340,"context_line":"    def _has_hugepage_support(self):"},{"line_number":5341,"context_line":"        # This means that the host can support multiple values for the size"},{"line_number":5342,"context_line":"        # field in LibvirtConfigGuestMemoryBackingPage"},{"line_number":5343,"context_line":"        supported_archs \u003d [fields.Architecture.I686,"},{"line_number":5344,"context_line":"                           fields.Architecture.X86_64,"},{"line_number":5345,"context_line":"                           fields.Architecture.AARCH64,"},{"line_number":5346,"context_line":"                           fields.Architecture.PPC64LE,"},{"line_number":5347,"context_line":"                           fields.Architecture.PPC64]"},{"line_number":5348,"context_line":"        caps \u003d self._host.get_capabilities()"},{"line_number":5349,"context_line":"        return ((caps.host.cpu.arch in supported_archs) and"},{"line_number":5350,"context_line":"                self._host.has_min_version(MIN_LIBVIRT_HUGEPAGE_VERSION,"},{"line_number":5351,"context_line":"                                           hv_type\u003dhost.HV_DRIVER_QEMU))"},{"line_number":5352,"context_line":""},{"line_number":5353,"context_line":"    def _get_host_numa_topology(self):"},{"line_number":5354,"context_line":"        if not self._has_numa_support():"}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_a3278db4","side":"PARENT","line":5351,"range":{"start_line":5340,"start_character":0,"end_line":5351,"end_character":72},"updated":"2017-02-23 19:23:54.000000000","message":"While this evaluated to:\n\n   HV type \u003d\u003d QEMU\n   LV type in [Intel, ARM, PPC]\n\nwhich is exactly the same minus the libvirt version check for PPC. Seeing as this was called on code paths that are only reachable if you have NUMA support, this could go","commit_id":"a0a0c554256cf49df2cc398e6b619d4609262423"}]}