)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c96dbdb7469490f6fe256e2c1a2eb014c513ae27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for cinderclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added unit tests for cinderclient in test_cinder.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1667447"},{"line_number":12,"context_line":"Change-Id: I3684d63cf787dd4b8087bb3901a7b98962878130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_fda541b5","line":9,"updated":"2017-02-28 19:25:44.000000000","message":"Why should we test cinderclient in *nova*?\n\nThe special thing is only nova.context._ContextAuthPlugin is used in these tests, is that the main purpose of this patch?","commit_id":"e94b81c7300223d2c2095b38b9150fbb1c014ed4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"540222b5084414649033ef6c6459d8601b41d72e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for cinderclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added unit tests for cinderclient in test_cinder.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1667447"},{"line_number":12,"context_line":"Change-Id: I3684d63cf787dd4b8087bb3901a7b98962878130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_b474befd","line":9,"in_reply_to":"ba2be162_29eddb8b","updated":"2017-02-28 22:07:05.000000000","message":"Ah, I see.\nBut couldn\u0027t BaseCinderTestCase cover the client code?\n\nThe create_client returns the cinderclient instance and CinderV2TestCase tests some client code.\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/test_cinder.py#L89","commit_id":"e94b81c7300223d2c2095b38b9150fbb1c014ed4"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"20838e20a44e164de53c0da1726cd09c9cd6a25e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for cinderclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added unit tests for cinderclient in test_cinder.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1667447"},{"line_number":12,"context_line":"Change-Id: I3684d63cf787dd4b8087bb3901a7b98962878130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_41b4a3f1","line":9,"in_reply_to":"ba2be162_b474befd","updated":"2017-02-28 23:12:29.000000000","message":"Yes you are right. My bad, I didn\u0027t notice there are two test_cinder.py files. I checked one and it doesn\u0027t have tests for client code and I thought they are missing. My patch is redundant.\n\nIn this patch may be I\u0027ll update https://github.com/openstack/nova/blob/master/nova/tests/unit/test_cinder.py with tests that cover admin context and service token(which is recently added https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L69 and haven\u0027t been tested at client side).\n\nThanks.","commit_id":"e94b81c7300223d2c2095b38b9150fbb1c014ed4"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"ac82991286e4b6bde7b4d74594a0ace7df21de5e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add unit tests for cinderclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added unit tests for cinderclient in test_cinder.py"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1667447"},{"line_number":12,"context_line":"Change-Id: I3684d63cf787dd4b8087bb3901a7b98962878130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_29eddb8b","line":9,"in_reply_to":"ba2be162_fda541b5","updated":"2017-02-28 21:41:17.000000000","message":"I am testing this part of code https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L59-L96\nThis part is not tested. May be my commit message is confusing. I meant to say the method cinderclient in cinder.py.\n\nI am working on this bug https://review.openstack.org/#/c/384799/\nand I wanted to add unit test for that change. Then I saw no tests for that particular part of code.","commit_id":"e94b81c7300223d2c2095b38b9150fbb1c014ed4"}],"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"3e7ac76df98bd8d82f124524c645b7ff7ad88b88","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.project_id \u003d \u0027fake_project\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class TestCinderClient(test.NoDBTestCase):"},{"line_number":70,"context_line":"    URL \u003d \"http://anyhost/v2/project_id\""},{"line_number":71,"context_line":"    SERVICE_TYPE \u003d \"volumev2\""},{"line_number":72,"context_line":"    SERVICE_NAME \u003d \"cinderv2\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da36d5c6_e5009f03","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":22},"updated":"2017-02-24 00:21:08.000000000","message":"The \u0027UnsupportedCinderAPIVersion\u0027 exception should be tested.","commit_id":"e94b81c7300223d2c2095b38b9150fbb1c014ed4"}]}