)]}'
{"nova/api/openstack/identity.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"52d084691a77c9aa342b3bae59dffb186c5d91cf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        LOG.exception(_LE(\"Unable to contact keystone to verify project_id\"))"},{"line_number":41,"context_line":"        return True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if resp.ok:"},{"line_number":44,"context_line":"        # All is good with this 20x status"},{"line_number":45,"context_line":"        return True"},{"line_number":46,"context_line":"    elif resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_a09f205e","line":43,"updated":"2017-02-28 19:55:50.000000000","message":"We have the same resp.__bool__ pattern in a few other places in nova, like in nova/scheduler/report/client.py, there might be others too for how we\u0027re interfacing with the placement service just using ksa - seems we should be consistent about this, but honestly I\u0027ve grown used to the resp.__bool__ wrinkle and we adjust for it in the unit tests.","commit_id":"39422687dbe7398089b15a152cca9a9c24c55853"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c86a2b707a07bef6ea726c1e7e7f42c18400f9ab","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        LOG.exception(_LE(\"Unable to contact keystone to verify project_id\"))"},{"line_number":41,"context_line":"        return True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if resp.ok:"},{"line_number":44,"context_line":"        # All is good with this 20x status"},{"line_number":45,"context_line":"        return True"},{"line_number":46,"context_line":"    elif resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ff179850","line":43,"in_reply_to":"ba2be162_6449b58b","updated":"2018-05-19 22:38:36.000000000","message":"How about just adding a comment about the behavior rather than the explicit change which makes this inconsistent with the other places in nova that we do this?","commit_id":"39422687dbe7398089b15a152cca9a9c24c55853"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"9c0e0dcf545428480cec6ed3fab923d6a90cbd93","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        LOG.exception(_LE(\"Unable to contact keystone to verify project_id\"))"},{"line_number":41,"context_line":"        return True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if resp.ok:"},{"line_number":44,"context_line":"        # All is good with this 20x status"},{"line_number":45,"context_line":"        return True"},{"line_number":46,"context_line":"    elif resp.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_6449b58b","line":43,"in_reply_to":"ba2be162_a09f205e","updated":"2017-03-01 00:08:46.000000000","message":"Nod. It\u0027s not an _important_ patch- it was just really unexpected code behavior to my dumb brain.","commit_id":"39422687dbe7398089b15a152cca9a9c24c55853"}]}