)]}'
{"nova/api/metadata/base.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c518537202e547dfa30bf24ab835e66d8893f171","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        if self.userdata_raw is not None:"},{"line_number":319,"context_line":"            data[\u0027user-data\u0027] \u003d self.userdata_raw"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        return data"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def get_ec2_item(self, path_tokens):"},{"line_number":324,"context_line":"        # get_ec2_metadata returns dict without top level version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_9936f901","line":321,"updated":"2017-03-01 12:31:16.000000000","message":"how about we LOG debug this before return?","commit_id":"a1f9d14f7000e746780d7e3f02d88fbee71151f2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5036ca514e07a916f595b622ce2a16ea484aaae5","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        if self.userdata_raw is not None:"},{"line_number":319,"context_line":"            data[\u0027user-data\u0027] \u003d self.userdata_raw"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        return data"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def get_ec2_item(self, path_tokens):"},{"line_number":324,"context_line":"        # get_ec2_metadata returns dict without top level version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_59048116","line":321,"in_reply_to":"ba2be162_9936f901","updated":"2017-03-01 12:32:06.000000000","message":"Done","commit_id":"a1f9d14f7000e746780d7e3f02d88fbee71151f2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f9f2acc7489902ced040b136ddbf483c146525d","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            data[\u0027user-data\u0027] \u003d self.userdata_raw"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":314,"context_line":"        LOG.debug(\"Instance %s metadata: %s\","},{"line_number":315,"context_line":"                  self.instance.ec2_ids.instance_id, data)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_79acd335","line":314,"updated":"2017-03-01 18:22:57.000000000","message":"Example of this:\n\nhttp://logs.openstack.org/60/439560/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/eee4e7a/logs/screen-n-api.txt.gz#_2017-03-01_15_16_38_959\n\n2017-03-01 15:16:38.959 1425 DEBUG nova.api.metadata.base [req-f4c7dfe2-cb31-4849-a9b4-1da84904b161 - -] Instance i-00000003 metadata: {\u0027meta-data\u0027: {\u0027reservation-id\u0027: u\u0027r-cj26q1cq\u0027, \u0027security-groups\u0027: [u\u0027default\u0027], \u0027public-ipv4\u0027: \u0027\u0027, \u0027ami-manifest-path\u0027: \u0027FIXME\u0027, \u0027instance-type\u0027: u\u0027m1.nano\u0027, \u0027instance-id\u0027: u\u0027i-00000003\u0027, \u0027local-ipv4\u0027: u\u002710.1.0.134\u0027, \u0027local-hostname\u0027: u\u0027tempest-tempest.common.compute-instance-446592352-1.novalocal\u0027, \u0027placement\u0027: {\u0027availability-zone\u0027: \u0027nova\u0027}, \u0027ami-launch-index\u0027: 0, \u0027public-hostname\u0027: u\u0027tempest-tempest.common.compute-instance-446592352-1.novalocal\u0027, \u0027hostname\u0027: u\u0027tempest-tempest.common.compute-instance-446592352-1.novalocal\u0027, \u0027ami-id\u0027: u\u0027ami-00000001\u0027, \u0027instance-action\u0027: \u0027none\u0027, \u0027block-device-mapping\u0027: {\u0027ami\u0027: u\u0027vda\u0027, \u0027root\u0027: u\u0027/dev/vda\u0027}}} get_ec2_metadata /opt/stack/new/nova/nova/api/metadata/base.py:315\n\nI\u0027m not sure what you want to use the ec2 id though, don\u0027t you want the instance uuid?\n\nAlternatively, add the instance\u003dself.instance kwarg to the debug log statement for context highlighting on this instance.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"de95bb62318d225e5413df66132f7dfb1ab6fd61","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            data[\u0027user-data\u0027] \u003d self.userdata_raw"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":314,"context_line":"        LOG.debug(\"Instance %s metadata: %s\","},{"line_number":315,"context_line":"                  self.instance.ec2_ids.instance_id, data)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_0478ce8e","line":314,"in_reply_to":"ba2be162_79acd335","updated":"2017-03-01 18:28:23.000000000","message":"The ec2 ID actually made it really simple to correlate with the output statement from the console of the failed cirros node (it prints this ID).\n\nI can add the instance thing to help though.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be7407d7ef7dca9ccc6a7d0d6e0f34822516bbfe","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            data[\u0027user-data\u0027] \u003d self.userdata_raw"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":314,"context_line":"        LOG.debug(\"Instance %s metadata: %s\","},{"line_number":315,"context_line":"                  self.instance.ec2_ids.instance_id, data)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_a43542db","line":314,"in_reply_to":"ba2be162_79acd335","updated":"2017-03-01 18:25:52.000000000","message":"Well, the URL is accessed via ec2 by cloud-init, so that makes some sense.\n\n+1 on adding instance into the log message though, so we get that included.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"}],"nova/api/metadata/handler.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f9f2acc7489902ced040b136ddbf483c146525d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        req.response.body \u003d encodeutils.to_utf8(resp)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":129,"context_line":"        LOG.debug(\"Metadata response body %s\", req.response.body)"},{"line_number":130,"context_line":"        req.response.content_type \u003d meta_data.get_mimetype()"},{"line_number":131,"context_line":"        return req.response"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_59262fcf","line":129,"updated":"2017-03-01 18:22:57.000000000","message":"Here is an example response:\n\nhttp://logs.openstack.org/60/439560/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/eee4e7a/logs/screen-n-api.txt.gz#_2017-03-01_15_16_38_960\n\n2017-03-01 15:16:38.960 1425 DEBUG nova.api.metadata.handler [req-f4c7dfe2-cb31-4849-a9b4-1da84904b161 - -] Metadata response body i-00000003 __call__ /opt/stack/new/nova/nova/api/metadata/handler.py:129\n\nIt seems like it would be more useful to also be logging the request for context.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f545e54cfa0aabee791a8a8b186ffeded46215a1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        req.response.body \u003d encodeutils.to_utf8(resp)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":129,"context_line":"        LOG.debug(\"Metadata response body %s\", req.response.body)"},{"line_number":130,"context_line":"        req.response.content_type \u003d meta_data.get_mimetype()"},{"line_number":131,"context_line":"        return req.response"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_247dd26e","line":129,"in_reply_to":"ba2be162_049feeb4","updated":"2017-03-01 18:28:35.000000000","message":"Oh yeah I see right after it:\n\n2017-03-01 15:16:38.960 1425 INFO nova.metadata.wsgi.server [req-f4c7dfe2-cb31-4849-a9b4-1da84904b161 - -] 10.1.0.134,10.28.170.116 \"GET /2009-04-04/meta-data/instance-id HTTP/1.1\" status: 200 len: 127 time: 0.9150050","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"be7407d7ef7dca9ccc6a7d0d6e0f34822516bbfe","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        req.response.body \u003d encodeutils.to_utf8(resp)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":129,"context_line":"        LOG.debug(\"Metadata response body %s\", req.response.body)"},{"line_number":130,"context_line":"        req.response.content_type \u003d meta_data.get_mimetype()"},{"line_number":131,"context_line":"        return req.response"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_049feeb4","line":129,"in_reply_to":"ba2be162_59262fcf","updated":"2017-03-01 18:25:52.000000000","message":"I guess the URL is covered in the logs already, but maybe.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"de95bb62318d225e5413df66132f7dfb1ab6fd61","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        req.response.body \u003d encodeutils.to_utf8(resp)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        # TODO(kevinbenton): remove after bug/1668958 is resolved"},{"line_number":129,"context_line":"        LOG.debug(\"Metadata response body %s\", req.response.body)"},{"line_number":130,"context_line":"        req.response.content_type \u003d meta_data.get_mimetype()"},{"line_number":131,"context_line":"        return req.response"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_a491c29b","line":129,"in_reply_to":"ba2be162_59262fcf","updated":"2017-03-01 18:28:23.000000000","message":"The request is logged right after it after this returns.","commit_id":"867e266217dec0edf9dd26a9c7250f41d9f35434"}]}