)]}'
{"nova/tests/unit/virt/xenapi/test_vmops.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"3dd70123d726952d20a4f0dfb682a0e55d843a05","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    rescue\u003dFalse, include_root_vdi\u003dTrue, throw_exception\u003dNone,"},{"line_number":292,"context_line":"                    attach_pci_dev\u003dFalse, neutron_exception\u003dFalse):"},{"line_number":293,"context_line":"        with test.nested("},{"line_number":294,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_instance_name_unique\u0027),"},{"line_number":295,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_enough_free_mem\u0027),"},{"line_number":296,"context_line":"            mock.patch.object(self.vmops, \u0027_update_instance_progress\u0027),"},{"line_number":297,"context_line":"            mock.patch.object(vm_utils, \u0027determine_disk_image_type\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_9672497b","line":294,"range":{"start_line":294,"start_character":30,"end_line":294,"end_character":40},"updated":"2017-03-07 17:23:19.000000000","message":"I think we should instead mock vmops.VMOps rather than using self.vmops.\n\nThat way we could do this as a decorator.\n\nI wouldn\u0027t say that, but there are loads of tests to do in here, and its good to try follow a pattern the rest of the code is using.","commit_id":"6a1f93712bb69acb26a10545bc6ae777ee10508d"},{"author":{"_account_id":21363,"name":"Gao Yuan","email":"yuan.gao@easystack.cn","username":"gaoyuan"},"change_message_id":"c98c190151942cfe162ff2d0153b4b42f1823b6c","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    rescue\u003dFalse, include_root_vdi\u003dTrue, throw_exception\u003dNone,"},{"line_number":292,"context_line":"                    attach_pci_dev\u003dFalse, neutron_exception\u003dFalse):"},{"line_number":293,"context_line":"        with test.nested("},{"line_number":294,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_instance_name_unique\u0027),"},{"line_number":295,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_enough_free_mem\u0027),"},{"line_number":296,"context_line":"            mock.patch.object(self.vmops, \u0027_update_instance_progress\u0027),"},{"line_number":297,"context_line":"            mock.patch.object(vm_utils, \u0027determine_disk_image_type\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_6b86d315","line":294,"range":{"start_line":294,"start_character":30,"end_line":294,"end_character":40},"in_reply_to":"9a30ddce_2ef4b384","updated":"2017-06-27 05:51:59.000000000","message":"I have a patch here waiting to be reviewed, https://review.openstack.org/#/c/451614/. It pretty much doing the same thing, in a different way. Any comment?","commit_id":"6a1f93712bb69acb26a10545bc6ae777ee10508d"},{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"a5209132fc20c251701c42e1589e2443784f42df","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    rescue\u003dFalse, include_root_vdi\u003dTrue, throw_exception\u003dNone,"},{"line_number":292,"context_line":"                    attach_pci_dev\u003dFalse, neutron_exception\u003dFalse):"},{"line_number":293,"context_line":"        with test.nested("},{"line_number":294,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_instance_name_unique\u0027),"},{"line_number":295,"context_line":"            mock.patch.object(self.vmops, \u0027_ensure_enough_free_mem\u0027),"},{"line_number":296,"context_line":"            mock.patch.object(self.vmops, \u0027_update_instance_progress\u0027),"},{"line_number":297,"context_line":"            mock.patch.object(vm_utils, \u0027determine_disk_image_type\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_2ef4b384","line":294,"range":{"start_line":294,"start_character":30,"end_line":294,"end_character":40},"in_reply_to":"9a30ddce_9672497b","updated":"2017-03-08 17:50:11.000000000","message":"John Garbutt, adding decorator to _test_spawn adds 30 arguments to the method which I think looks bad. Also there are some attributes used that can\u0027t be used without initializing the class. So I think self.vmops is the better way to do.","commit_id":"6a1f93712bb69acb26a10545bc6ae777ee10508d"}]}