)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"9d51e998bbc2fd3bfaaccb8076f5af3207f71b1d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the dsvm gates, ConfKeyManager (the fixed_key key manager) should"},{"line_number":15,"context_line":"be set in DevStack (see dependent patch)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I733279864ee1a4aaffc9c8eed81b5e12f8d8821b"},{"line_number":18,"context_line":"Change-Id: I82ee74f3d2629281dc8116af55f6a7b5398fc473"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_3649405f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":53},"updated":"2017-04-28 21:01:27.000000000","message":"This has now merged.","commit_id":"93438c7713719cd15cf5bf04f905b10f75341e38"}],"nova/conf/key_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29e9f09109716e17615a13ebe2b585dbe3c39c43","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"key_manager_opts \u003d ["},{"line_number":24,"context_line":"    # TODO(raj_singh): Deprecate or move this option to The Castellan library"},{"line_number":25,"context_line":"    # NOTE(kfarr): The ability to use fixed_key should be deprecated and"},{"line_number":26,"context_line":"    # removed and Barbican should be tested in the gate instead"},{"line_number":27,"context_line":"    cfg.StrOpt("},{"line_number":28,"context_line":"        \u0027fixed_key\u0027,"},{"line_number":29,"context_line":"        deprecated_group\u003d\u0027keymgr\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_075e3975","line":26,"range":{"start_line":25,"start_character":4,"end_line":26,"end_character":63},"updated":"2017-06-02 19:59:02.000000000","message":"I\u0027d think the gate-barbican-simple-crypto-dsvm-tempest-nova-ubuntu-xenial-nv job in the nova experimental queue should be able to test this...","commit_id":"e658d50b992be48ebc1488aa02bc95668ed1b2b1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50aa5d4d624793f9d722c997172dc8b72acd137a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"key_manager_opts \u003d ["},{"line_number":24,"context_line":"    # TODO(raj_singh): Deprecate or move this option to The Castellan library"},{"line_number":25,"context_line":"    # NOTE(kfarr): The ability to use fixed_key should be deprecated and"},{"line_number":26,"context_line":"    # removed and Barbican should be tested in the gate instead"},{"line_number":27,"context_line":"    cfg.StrOpt("},{"line_number":28,"context_line":"        \u0027fixed_key\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f436f4f_82b83ac8","line":25,"updated":"2017-08-10 13:05:47.000000000","message":"Why not deprecate it now then? Or we can\u0027t because barbican isn\u0027t part of default devstack?","commit_id":"4844aa76398fde81817cd917a409e367ab45bc98"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"56716cc660e1d1fd262758eee89d1b1b517a066b","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"key_manager_opts \u003d ["},{"line_number":24,"context_line":"    # TODO(raj_singh): Deprecate or move this option to The Castellan library"},{"line_number":25,"context_line":"    # NOTE(kfarr): The ability to use fixed_key should be deprecated and"},{"line_number":26,"context_line":"    # removed and Barbican should be tested in the gate instead"},{"line_number":27,"context_line":"    cfg.StrOpt("},{"line_number":28,"context_line":"        \u0027fixed_key\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f2577a7_333587db","line":25,"in_reply_to":"9f436f4f_82b83ac8","updated":"2017-09-11 19:48:04.000000000","message":"Barbican isn\u0027t part of default DevStack, otherwise we could remove confkeymgr","commit_id":"4844aa76398fde81817cd917a409e367ab45bc98"}],"nova/keymgr/__init__.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29e9f09109716e17615a13ebe2b585dbe3c39c43","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF.set_default(\u0027api_class\u0027, \u0027nova.keymgr.conf_key_mgr.ConfKeyManager\u0027,"},{"line_number":30,"context_line":"                 group\u003d\u0027key_manager\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(kfarr): For backwards compatibility, everything below this comment"},{"line_number":33,"context_line":"# is deprecated for removal"},{"line_number":34,"context_line":"api_class \u003d None"},{"line_number":35,"context_line":"try:"},{"line_number":36,"context_line":"    api_class \u003d CONF.key_manager.api_class"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_87dec9d7","side":"PARENT","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":27},"updated":"2017-06-02 19:59:02.000000000","message":"For whatever backward compatible straddle behavior is being removed, we should have an upgrade impact release note:\n\nhttps://docs.openstack.org/developer/nova/releasenotes.html","commit_id":"81e5ff58fe23b60e65686f5312096a6c5b3f8eba"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"087e62e6c141fb9a9165ad947a1fb7e0781e15f8","unresolved":false,"context_lines":[{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"    def _get_volume_encryptor(self, connection_info, encryption):"},{"line_number":1168,"context_line":"        root_helper \u003d utils.get_root_helper()"},{"line_number":1169,"context_line":"        key_manager \u003d keymgr.API(CONF)"},{"line_number":1170,"context_line":"        return encryptors.get_volume_encryptor(root_helper\u003droot_helper,"},{"line_number":1171,"context_line":"                                               keymgr\u003dkey_manager,"},{"line_number":1172,"context_line":"                                               connection_info\u003dconnection_info,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_4b2bc42f","line":1169,"range":{"start_line":1169,"start_character":8,"end_line":1169,"end_character":38},"updated":"2017-05-02 18:23:14.000000000","message":"It would be good to rename this as well, as you have done elsewhere, to be consistent.","commit_id":"4cfe23f2bc40ed412c129e950522e728d3c4a9fa"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"4f28a43dd0267d4260631c79142de8ffa3c602ff","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        self.ephemeral_key_uuid \u003d instance.get(\u0027ephemeral_key_uuid\u0027)"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"        if self.ephemeral_key_uuid is not None:"},{"line_number":633,"context_line":"            self.key_manager \u003d key_manager.API()"},{"line_number":634,"context_line":"        else:"},{"line_number":635,"context_line":"            self.key_manager \u003d None"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_9cbdb8b8","line":633,"range":{"start_line":633,"start_character":43,"end_line":633,"end_character":48},"updated":"2017-05-01 20:33:58.000000000","message":"Is there a reason why the CONF value is no longer being passed on?","commit_id":"4cfe23f2bc40ed412c129e950522e728d3c4a9fa"}],"releasenotes/notes/remove-deprecated-keymgr-db807dc76c83263e.yaml":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"813ee91bf43448a8fd430e49b72f398cfa2d2550","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      use ``castellan.key_manager.barbican_key_manager.BarbicanKeyManager``"},{"line_number":12,"context_line":"    - Instead of ``api_class`` option ``nova.tests.unit.keymgr.mock_key_mgr.MockKeyManager``,"},{"line_number":13,"context_line":"      use ``castellan.tests.unit.key_manager.mock_key_manager.MockKeyManager``"},{"line_number":14,"context_line":"    - ``nova.keymgr.conf_key_mgr.ConfKeyManager`` still remains, but the ``fixed_key`` configuration options should be moved to the ``[key_manager]`` section"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f201791_9625ca0b","line":14,"updated":"2017-06-27 12:54:26.000000000","message":"Any reason this line is not wrapped like the others?","commit_id":"03e4bbba069897f55ffb9f08429fdb264896b18f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"50aa5d4d624793f9d722c997172dc8b72acd137a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The old deprecated ``keymgr`` options have been removed."},{"line_number":5,"context_line":"    Configuration options using the ``[keymgr]`` group will not be"},{"line_number":6,"context_line":"    applied anymore. Use the ``[key_manager]`` group from Castellan instead."},{"line_number":7,"context_line":"    The Castellan ``api_class`` options should also be used instead, as most"},{"line_number":8,"context_line":"    of the options that lived in Nova have migrated to Castellan."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f436f4f_42b81275","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":76},"updated":"2017-08-10 13:05:47.000000000","message":"I was a bit confused by this since the nova.conf sample doesn\u0027t mention castellan, or that these come from castellan, but I guess that\u0027s because they are duplicated with Nova options - which we\u0027re doing for the fixed_key option?\n\nI was looking at the generated conf sample here:\n\nhttp://docs-draft.openstack.org/55/439855/10/check/gate-nova-docs-ubuntu-xenial/3e48a82//doc/build/html/sample_config.html","commit_id":"4844aa76398fde81817cd917a409e367ab45bc98"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"56716cc660e1d1fd262758eee89d1b1b517a066b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The old deprecated ``keymgr`` options have been removed."},{"line_number":5,"context_line":"    Configuration options using the ``[keymgr]`` group will not be"},{"line_number":6,"context_line":"    applied anymore. Use the ``[key_manager]`` group from Castellan instead."},{"line_number":7,"context_line":"    The Castellan ``api_class`` options should also be used instead, as most"},{"line_number":8,"context_line":"    of the options that lived in Nova have migrated to Castellan."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5f2577a7_13472b4e","line":6,"range":{"start_line":6,"start_character":21,"end_line":6,"end_character":76},"in_reply_to":"9f436f4f_42b81275","updated":"2017-09-11 19:48:04.000000000","message":"Right, the castellan options are in the \"key_manager\" group, there isn\u0027t a group called \"castellan\".  The nova \"fixed_key\" option is also in the \"key_manager\" group","commit_id":"4844aa76398fde81817cd917a409e367ab45bc98"}]}