)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"1bd338d23de61ed66ccaf4d101748eb609446247","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tracy Jones \u003ctjones@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-04 19:52:48 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMwareVCDriver: Fix instance create with sparse disk image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same approach of calling VirtualDiskManager.CopyVirtualDisk"},{"line_number":10,"context_line":"without destination disk spec in the cluster driver for fixing 1184807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAASn%2F%2FTXQ%3D","line":7,"updated":"2013-09-06 18:09:07.000000000","message":"Nit: title in bug/1171226 says \"CopyVirtualDisk returns a \"not implemented by server\" msg\" ... huh? Maybe say:\n\nVMwareVCDriver: Fix CopyVirtualDisk returns a \"not implemented by server\" msg\n\nFix instance create with sparse disk image, the same approach of calling VirtualDiskManager.CopyVirtualDisk ... \u003cand so on\u003e","commit_id":"db564af688565d8b1e20a18f6d1f749b7296d666"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"7e5c694f181c6fd97298d52ee7e87cee7f2a4f2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tracy Jones \u003ctjones@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-04 19:52:48 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMwareVCDriver: Fix instance create with sparse disk image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The same approach of calling VirtualDiskManager.CopyVirtualDisk"},{"line_number":10,"context_line":"without destination disk spec in the cluster driver for fixing 1184807"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAASn%2F%2FTAI%3D","line":7,"in_reply_to":"AAAASn%2F%2FTXQ%3D","updated":"2013-09-06 23:32:45.000000000","message":"Good call. Will update in next rev","commit_id":"db564af688565d8b1e20a18f6d1f749b7296d666"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"1bd338d23de61ed66ccaf4d101748eb609446247","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                        \"data_store_name\": data_store_name,"},{"line_number":337,"context_line":"                        \"disk_type\": disk_type},"},{"line_number":338,"context_line":"                      instance\u003dinstance)"},{"line_number":339,"context_line":"            vmdk_copy_spec \u003d self._get_copy_virtual_disk_spec(client_factory,"},{"line_number":340,"context_line":"                                    vmdk_file_size_in_kb, adapter_type,"},{"line_number":341,"context_line":"                                    disk_type)"},{"line_number":342,"context_line":"            vmdk_copy_task \u003d self._session._call_method("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FTWs%3D","line":339,"updated":"2013-09-06 18:09:07.000000000","message":"The method is static, so instead of self. it\u0027s usually good form to use:\n\n    VMwareVMOps._get_copy_virtual_disk_spec","commit_id":"db564af688565d8b1e20a18f6d1f749b7296d666"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"7e5c694f181c6fd97298d52ee7e87cee7f2a4f2c","unresolved":false,"context_lines":[{"line_number":336,"context_line":"                        \"data_store_name\": data_store_name,"},{"line_number":337,"context_line":"                        \"disk_type\": disk_type},"},{"line_number":338,"context_line":"                      instance\u003dinstance)"},{"line_number":339,"context_line":"            vmdk_copy_spec \u003d self._get_copy_virtual_disk_spec(client_factory,"},{"line_number":340,"context_line":"                                    vmdk_file_size_in_kb, adapter_type,"},{"line_number":341,"context_line":"                                    disk_type)"},{"line_number":342,"context_line":"            vmdk_copy_task \u003d self._session._call_method("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAASn%2F%2FSm0%3D","line":339,"in_reply_to":"AAAASn%2F%2FTWs%3D","updated":"2013-09-06 23:32:45.000000000","message":"In this case, we need self because we want to call the static method that is bound to the class of the instance, which can be\nVMwareVMOps or VMwareVCVMOps.","commit_id":"db564af688565d8b1e20a18f6d1f749b7296d666"}]}
