)]}'
{"nova/tests/functional/test_list_servers_ip_filter.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"52510a3be77b413b4afb625513a608ce7910e7f2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.image_id \u003d self.api.get_images()[0][\u0027id\u0027]"},{"line_number":51,"context_line":"        self.flavor_id \u003d self.api.get_flavors()[0][\u0027id\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def wait_until_active_or_timeout(self, server_id):"},{"line_number":54,"context_line":"        timeout \u003d 0.0"},{"line_number":55,"context_line":"        server \u003d self.api.get_server(server_id)"},{"line_number":56,"context_line":"        while server[\u0027status\u0027] !\u003d \"ACTIVE\" and timeout \u003c 10.0:"},{"line_number":57,"context_line":"            time.sleep(.1)"},{"line_number":58,"context_line":"            timeout +\u003d .1"},{"line_number":59,"context_line":"            server \u003d self.api.get_server(server_id)"},{"line_number":60,"context_line":"        if server[\u0027status\u0027] !\u003d \"ACTIVE\":"},{"line_number":61,"context_line":"            self.fail("},{"line_number":62,"context_line":"                \u0027Timed out waiting for server %s to be ACTIVE.\u0027 % server_id)"},{"line_number":63,"context_line":"        return server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_servers_with_ip_filters_regex(self):"},{"line_number":66,"context_line":"        \"\"\"Tests listing servers with IP filter regex."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_bfdd3616","line":63,"range":{"start_line":53,"start_character":0,"end_line":63,"end_character":21},"updated":"2017-03-02 05:23:52.000000000","message":"we can have such logic in base or helper to reuse, but let\u0027s do when needed in other tests.","commit_id":"b6a99a390caf2c143f3211c40f2ac7f5d51c9c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d810bd2e2b3f230c6021a9f53d2482b09656869","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.image_id \u003d self.api.get_images()[0][\u0027id\u0027]"},{"line_number":51,"context_line":"        self.flavor_id \u003d self.api.get_flavors()[0][\u0027id\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def wait_until_active_or_timeout(self, server_id):"},{"line_number":54,"context_line":"        timeout \u003d 0.0"},{"line_number":55,"context_line":"        server \u003d self.api.get_server(server_id)"},{"line_number":56,"context_line":"        while server[\u0027status\u0027] !\u003d \"ACTIVE\" and timeout \u003c 10.0:"},{"line_number":57,"context_line":"            time.sleep(.1)"},{"line_number":58,"context_line":"            timeout +\u003d .1"},{"line_number":59,"context_line":"            server \u003d self.api.get_server(server_id)"},{"line_number":60,"context_line":"        if server[\u0027status\u0027] !\u003d \"ACTIVE\":"},{"line_number":61,"context_line":"            self.fail("},{"line_number":62,"context_line":"                \u0027Timed out waiting for server %s to be ACTIVE.\u0027 % server_id)"},{"line_number":63,"context_line":"        return server"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def test_list_servers_with_ip_filters_regex(self):"},{"line_number":66,"context_line":"        \"\"\"Tests listing servers with IP filter regex."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_6f63331b","line":63,"range":{"start_line":53,"start_character":0,"end_line":63,"end_character":21},"in_reply_to":"ba2be162_bfdd3616","updated":"2017-03-07 20:07:37.000000000","message":"Yeah I thought about the same redundant code in several functional tests but would rather clean those all up in a single refactor.","commit_id":"b6a99a390caf2c143f3211c40f2ac7f5d51c9c1d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"96871131e6d742448f62620c247c5707fc5a102b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        all servers that have fixed IPs which match the filter."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        For example, consider we have two servers. The first server has IP"},{"line_number":72,"context_line":"        10.1.1.1 and the second server has IP 10.1.1.10. If we list servers"},{"line_number":73,"context_line":"        with filter ip\u003d10.1.1.1 we should get back both servers because"},{"line_number":74,"context_line":"        10.1.1.1 is a prefix of 10.1.1.10. If we list servers with filter"},{"line_number":75,"context_line":"        ip\u003d10.1.1.10 then we should only get back the second server."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_570424bf","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":16},"updated":"2017-03-02 03:48:32.000000000","message":"It is better to write 192.168.1.3 and 192.168.1.30 to understand this behavior easily for fitting to the fixture.","commit_id":"b6a99a390caf2c143f3211c40f2ac7f5d51c9c1d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"52510a3be77b413b4afb625513a608ce7910e7f2","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        all servers that have fixed IPs which match the filter."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        For example, consider we have two servers. The first server has IP"},{"line_number":72,"context_line":"        10.1.1.1 and the second server has IP 10.1.1.10. If we list servers"},{"line_number":73,"context_line":"        with filter ip\u003d10.1.1.1 we should get back both servers because"},{"line_number":74,"context_line":"        10.1.1.1 is a prefix of 10.1.1.10. If we list servers with filter"},{"line_number":75,"context_line":"        ip\u003d10.1.1.10 then we should only get back the second server."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_9f1cf2c2","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":16},"in_reply_to":"ba2be162_570424bf","updated":"2017-03-02 05:23:52.000000000","message":"yea. as example it should be fine.","commit_id":"b6a99a390caf2c143f3211c40f2ac7f5d51c9c1d"}]}