)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"87258d0b15b87b33b0b4291f142f2edffc908695","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The flavor objects stored in the instance object should not be used"},{"line_number":10,"context_line":"to lazy load any data from the db as they are not connected to real"},{"line_number":11,"context_line":"flavors in the db. These flavor objects are orphaned when created"},{"line_number":12,"context_line":"but durin rpc deserialization every deserialized nova object"},{"line_number":13,"context_line":"automatically gets a valid context. This can lead to unintended"},{"line_number":14,"context_line":"lazy loading of the projects field of such flavor objects during"},{"line_number":15,"context_line":"notification payload generation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_3362f8d8","line":12,"updated":"2017-03-10 17:11:20.000000000","message":"s/durin/during/","commit_id":"0082c47896475e968840a5f6c4e0f194523e10e8"}],"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e321e7ee29129a45812446bf17dcbd9f2e0fccdc","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # real flavor objects in the db. However during RPC deserialization"},{"line_number":279,"context_line":"        # every object gets a valid context so we have to orphan the flavors"},{"line_number":280,"context_line":"        # again."},{"line_number":281,"context_line":"        if self.obj_attr_is_set(\u0027flavor\u0027):"},{"line_number":282,"context_line":"            self.flavor._context \u003d None"},{"line_number":283,"context_line":"        if self.obj_attr_is_set(\u0027old_flavor\u0027) and self.old_flavor:"},{"line_number":284,"context_line":"            self.old_flavor._context \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_53f76c58","line":281,"updated":"2017-03-10 17:17:40.000000000","message":"The modern way to do this is:\n\n if \"flavor\" in self:\n     ...\n\nbut this is fine too.","commit_id":"0082c47896475e968840a5f6c4e0f194523e10e8"}]}
