)]}'
{"nova/tests/unit/api/openstack/compute/test_block_device_mapping.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4bdb3d36002fa6090ae07db4bdc5237c1755e8ab","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        self._test_create_instance_with_destination_type_error(\u0027fake\u0027)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    @mock.patch.object(compute_api.API, \u0027_validate_bdm\u0027)"},{"line_number":355,"context_line":"    def test_create_instance_bdm(self, _validate_bdm):"},{"line_number":356,"context_line":"        bdm \u003d [{"},{"line_number":357,"context_line":"            \u0027source_type\u0027: \u0027volume\u0027,"},{"line_number":358,"context_line":"            \u0027device_name\u0027: \u0027fake_dev\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_71dfe639","line":355,"range":{"start_line":355,"start_character":39,"end_line":355,"end_character":52},"updated":"2017-03-06 06:04:03.000000000","message":"-\u003e mock_validate_bdm\n\nalso check its call with assert_called_once_with","commit_id":"3b28833e8d77fd7037b592ca4bbb13b6928f5029"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4bdb3d36002fa6090ae07db4bdc5237c1755e8ab","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        self._test_create(params, no_image\u003dTrue)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    @mock.patch.object(compute_api.API, \u0027_validate_bdm\u0027)"},{"line_number":383,"context_line":"    def test_create_instance_bdm_missing_device_name(self, _validate_bdm):"},{"line_number":384,"context_line":"        del self.bdm[0][\u0027device_name\u0027]"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"        old_create \u003d compute_api.API.create"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_91ea9ad9","line":383,"range":{"start_line":383,"start_character":59,"end_line":383,"end_character":72},"updated":"2017-03-06 06:04:03.000000000","message":"ditto, also check with assert_called_once_with","commit_id":"3b28833e8d77fd7037b592ca4bbb13b6928f5029"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4bdb3d36002fa6090ae07db4bdc5237c1755e8ab","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    @mock.patch.object("},{"line_number":400,"context_line":"        block_device.BlockDeviceDict, \u0027_validate\u0027,"},{"line_number":401,"context_line":"        side_effect\u003dexception.InvalidBDMFormat(details\u003d\u0027Wrong BDM\u0027))"},{"line_number":402,"context_line":"    def test_create_instance_bdm_validation_error(self, _validate):"},{"line_number":403,"context_line":"        params \u003d {block_device_mapping.ATTRIBUTE_NAME: self.bdm}"},{"line_number":404,"context_line":"        self.assertRaises(exc.HTTPBadRequest,"},{"line_number":405,"context_line":"                          self._test_create, params, no_image\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_11bdcad7","line":402,"range":{"start_line":402,"start_character":56,"end_line":402,"end_character":65},"updated":"2017-03-06 06:04:03.000000000","message":"mock_validate for better readability","commit_id":"3b28833e8d77fd7037b592ca4bbb13b6928f5029"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7bb34a9c4312c99a0cc8ca5c0786d7986a7b462","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    @mock.patch.object(compute_api.API, \u0027_get_bdm_image_metadata\u0027)"},{"line_number":127,"context_line":"    def test_create_instance_with_bdms_and_no_image("},{"line_number":128,"context_line":"            self, mock_bdm_image_metadata, mock_validate_bdm):"},{"line_number":129,"context_line":"        mock_bdm_image_metadata.return_value \u003d {}"},{"line_number":130,"context_line":"        mock_validate_bdm.return_value \u003d True"},{"line_number":131,"context_line":"        old_create \u003d compute_api.API.create"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        def create(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_30c6dc49","line":130,"range":{"start_line":129,"start_character":8,"end_line":130,"end_character":45},"updated":"2017-03-08 12:17:54.000000000","message":"nit: I tend to prefer these in the decorator, but that\u0027s not a blocker\n\n    @mock.patch.object(compute_api.API, \u0027_validate_bdm\u0027,\n                       return_value\u003dTrue)","commit_id":"4089faef858dc4e537eb54cb5f07a01522b26ccb"}]}