)]}'
{"nova/conf/netconf.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"13a295f233b9592a48cba51b04cb818361cce358","unresolved":false,"context_lines":[{"line_number":24,"context_line":"netconf_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\"my_ip\","},{"line_number":26,"context_line":"               default\u003dnetutils.get_my_ipv4(),"},{"line_number":27,"context_line":"               sample_default\u003d\u002710.0.0.1\u0027,"},{"line_number":28,"context_line":"               help\u003d\"\"\""},{"line_number":29,"context_line":"The IP address which the host is using to connect to the management network."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_5801dbad","line":27,"updated":"2017-03-07 18:19:30.000000000","message":"I think we need to make it clear the default is actually to auto detect the IP address.\n\nMaybe \"netutils.get_my_ipv4()\" is the best way to describe the default?","commit_id":"3320c8273209e3ffb8bcc7e985c188ada9d2ea93"},{"author":{"_account_id":14511,"name":"Maciej Szankin","email":"maciej+review@szankin.pl","username":"mszankin"},"change_message_id":"1ed3fe804cd256aa8c6e6965028187df674cb165","unresolved":false,"context_lines":[{"line_number":24,"context_line":"netconf_opts \u003d ["},{"line_number":25,"context_line":"    cfg.StrOpt(\"my_ip\","},{"line_number":26,"context_line":"               default\u003dnetutils.get_my_ipv4(),"},{"line_number":27,"context_line":"               sample_default\u003d\u002710.0.0.1\u0027,"},{"line_number":28,"context_line":"               help\u003d\"\"\""},{"line_number":29,"context_line":"The IP address which the host is using to connect to the management network."},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_fea5ee03","line":27,"in_reply_to":"9a30ddce_5801dbad","updated":"2017-03-08 15:31:00.000000000","message":"Or maybe a tag like \u003cIPV4_ADDRESS\u003e would be more readable?","commit_id":"3320c8273209e3ffb8bcc7e985c188ada9d2ea93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"13a295f233b9592a48cba51b04cb818361cce358","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\"\"\"),"},{"line_number":55,"context_line":"    cfg.StrOpt(\"host\","},{"line_number":56,"context_line":"               default\u003dsocket.gethostname(),"},{"line_number":57,"context_line":"               sample_default\u003d\u0027host.example\u0027,"},{"line_number":58,"context_line":"               help\u003d\"\"\""},{"line_number":59,"context_line":"Hostname, FQDN or IP address of this host. "},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_b8265766","line":57,"updated":"2017-03-07 18:19:30.000000000","message":"as above really","commit_id":"3320c8273209e3ffb8bcc7e985c188ada9d2ea93"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"13a295f233b9592a48cba51b04cb818361cce358","unresolved":false,"context_lines":[{"line_number":61,"context_line":"Used as:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"* the oslo.messaging queue name for nova-compute worker"},{"line_number":64,"context_line":"* neutron bind host - should match the host config of the neutron agent"},{"line_number":65,"context_line":"* cinder host attachment information"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Must be valid within AMQP key."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_38f267d3","line":64,"updated":"2017-03-07 18:19:30.000000000","message":"Maybe need a few more words here, like:\n\nWe use this value for the binding_host sent to neutron. This means if you use a neutron agent, it should have the same value for host.","commit_id":"3320c8273209e3ffb8bcc7e985c188ada9d2ea93"}]}