)]}'
{"nova/image/glance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ba738ab87a3c5d37efec7b84b8feeb597b4d9381","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _glanceclient_from_endpoint(context, endpoint, version\u003d1):"},{"line_number":87,"context_line":"    \"\"\"Instantiate a new glanceclient.Client object.\"\"\""},{"line_number":88,"context_line":"    params \u003d {}"},{"line_number":89,"context_line":"    # NOTE(sdague): even if we aren\u0027t using keystone, it doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_c3c39755","line":86,"range":{"start_line":86,"start_character":51,"end_line":86,"end_character":60},"updated":"2017-03-03 17:27:15.000000000","message":"We shouldn\u0027t allow this to change anymore as it should always be v2 now. I guess it\u0027s just hard-coded in the single glanceclient wrapper that we have now, but this could be changed to default to 2 probably.","commit_id":"50d702eaa6e2c981ff133959c0a79155aa32d231"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6d88074cb39610856f23894f6a3b82142e793603","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _glanceclient_from_endpoint(context, endpoint, version\u003d1):"},{"line_number":87,"context_line":"    \"\"\"Instantiate a new glanceclient.Client object.\"\"\""},{"line_number":88,"context_line":"    params \u003d {}"},{"line_number":89,"context_line":"    # NOTE(sdague): even if we aren\u0027t using keystone, it doesn\u0027t"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_261e415f","line":86,"range":{"start_line":86,"start_character":51,"end_line":86,"end_character":60},"in_reply_to":"ba2be162_c3c39755","updated":"2017-03-03 17:48:16.000000000","message":"It only has 2 callers, and they both pass version explicitly.\nIncidentally, there are only 2 callers of those callers:\n\n_create_static_client will always be passed version 2 because it\u0027s hardcoded in __init__.\n\n_create_onetime_client is only called by call(), and all callers of call() seem to explicitly pass version 2.\n\nIt\u0027s not strictly necessary for this patch, which just removes a class which can\u0027t be instantiated, but I\u0027m happy to remove the default if you\u0027d like.","commit_id":"50d702eaa6e2c981ff133959c0a79155aa32d231"}]}