)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2140fcff2be177c4d40e83bb973c2ca7c07eb8d8","unresolved":false,"context_lines":[{"line_number":4401,"context_line":"        if virt_type \u003d\u003d \u0027parallels\u0027:"},{"line_number":4402,"context_line":"            pass"},{"line_number":4403,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4404,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4405,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4406,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4407,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4408,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4409,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4410,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_d72208b9","line":4407,"range":{"start_line":4404,"start_character":12,"end_line":4407,"end_character":54},"updated":"2017-03-07 14:50:51.000000000","message":"nit: it makes sense to me to add a \u0027_create_consoles_xen\u0027 now that we\u0027re doing more than one thing. Future cleanup?","commit_id":"ac61abb7c74f1a8e3e9134bc045455fd9fdac0fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c2c8f1497e0143f01623ebaf45b20061f3765ad","unresolved":false,"context_lines":[{"line_number":4401,"context_line":"        if virt_type \u003d\u003d \u0027parallels\u0027:"},{"line_number":4402,"context_line":"            pass"},{"line_number":4403,"context_line":"        elif virt_type not in (\"qemu\", \"kvm\"):"},{"line_number":4404,"context_line":"            log_path \u003d self._get_console_log_path(instance)"},{"line_number":4405,"context_line":"            self._create_pty_device(guest_cfg,"},{"line_number":4406,"context_line":"                                    vconfig.LibvirtConfigGuestConsole,"},{"line_number":4407,"context_line":"                                    log_path\u003dlog_path)"},{"line_number":4408,"context_line":"        elif (virt_type in (\"qemu\", \"kvm\") and"},{"line_number":4409,"context_line":"                  self._is_s390x_guest(image_meta)):"},{"line_number":4410,"context_line":"            self._create_consoles_s390x(guest_cfg, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_f2e71a3e","line":4407,"range":{"start_line":4404,"start_character":12,"end_line":4407,"end_character":54},"in_reply_to":"9a30ddce_d72208b9","updated":"2017-03-07 14:54:34.000000000","message":"There are more than just xen for the non-kvm/qemu cases though so I wouldn\u0027t create a xen-specific version of this.\n\nIdeally what I\u0027d do is pass the instance to _create_pty_device and if log_path is not set and we need it in there, then use the instance to get the log_path. I wanted to keep this change small since I knew I was going to be backporting to stable/ocata so I didn\u0027t do the refactor.","commit_id":"ac61abb7c74f1a8e3e9134bc045455fd9fdac0fa"}]}