)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b51f6b9c7ddcd4df71b04c6b3ecbae60e658ae4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Using max api version in notificationt sample test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notification payloads always reflect the data needed for every"},{"line_number":10,"context_line":"supported API microversion so we can safe to use the latest"},{"line_number":11,"context_line":"API version in the notification sample tests. This helps the test"},{"line_number":12,"context_line":"to use the new API features too."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ffe62b97_327e40af","line":10,"updated":"2017-03-27 19:57:43.000000000","message":"s/we can safe to use/we can safely use/","commit_id":"bfdd087f881b0ad858b07e6f4e71375701f4f6a9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ea28d65dd83e74b6d25e002be29cea84853a8802","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Béla Vancsics \u003cvancsics@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-28 07:30:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using max api version in notificationt sample test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notification payloads always reflect the data needed for every"},{"line_number":10,"context_line":"supported API microversion so we can safe to use the latest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_28b0eb42","line":7,"updated":"2017-03-28 13:58:30.000000000","message":"s/notificationt/notification/ :)","commit_id":"06d92ba4072de1db0e6d551d0079ae160653e505"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c8db1441d2452adc8fb6d30320ef08c3e0fb040","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Béla Vancsics \u003cvancsics@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-28 07:30:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Using max api version in notificationt sample test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notification payloads always reflect the data needed for every"},{"line_number":10,"context_line":"supported API microversion so we can safe to use the latest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7ffa3b31_8f425eaa","line":7,"in_reply_to":"ffe62b97_28b0eb42","updated":"2017-04-20 16:15:27.000000000","message":"Done","commit_id":"06d92ba4072de1db0e6d551d0079ae160653e505"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"ea28d65dd83e74b6d25e002be29cea84853a8802","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Using max api version in notificationt sample test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notification payloads always reflect the data needed for every"},{"line_number":10,"context_line":"supported API microversion so we can safe to use the latest"},{"line_number":11,"context_line":"API version in the notification sample tests. This helps the test"},{"line_number":12,"context_line":"to use the new API features too."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_c8b29f49","line":10,"updated":"2017-03-28 13:58:30.000000000","message":"s/we can safe to use/we can safely use/","commit_id":"06d92ba4072de1db0e6d551d0079ae160653e505"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c8db1441d2452adc8fb6d30320ef08c3e0fb040","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Using max api version in notificationt sample test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Notification payloads always reflect the data needed for every"},{"line_number":10,"context_line":"supported API microversion so we can safe to use the latest"},{"line_number":11,"context_line":"API version in the notification sample tests. This helps the test"},{"line_number":12,"context_line":"to use the new API features too."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7ffa3b31_6f15d29b","line":10,"in_reply_to":"ffe62b97_c8b29f49","updated":"2017-04-20 16:15:27.000000000","message":"Done","commit_id":"06d92ba4072de1db0e6d551d0079ae160653e505"}],"nova/tests/functional/notification_sample_tests/notification_sample_base.py":[{"author":{"_account_id":18337,"name":"Sujitha","email":"sujitha.neti@intel.com","username":"Sujitha"},"change_message_id":"c4cc6bb47f8e73ac6ddb469eb19508649d456b52","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE(gibi): Notification payloads always reflect the data needed"},{"line_number":67,"context_line":"        # for every supported API microversion so we can safe to use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request.max_api_version().get_string()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_c9292339","line":67,"range":{"start_line":67,"start_character":57,"end_line":67,"end_character":64},"updated":"2017-03-09 17:36:33.000000000","message":"nit: safely","commit_id":"b75230641839fb987043bbe421ddf676dc8cae07"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84612aee0f4ca7953870eaebce7937cb2c81762e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # for every supported API microversion so we can safe to use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request.max_api_version().get_string()"},{"line_number":71,"context_line":"        self.api.microversion \u003d max_version"},{"line_number":72,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_531479f4","line":70,"range":{"start_line":70,"start_character":42,"end_line":70,"end_character":72},"updated":"2017-03-15 02:25:50.000000000","message":"you can use _MAX_API_VERSION directly.\n\nmax_api_version().get_string() will make API version object from string and then convert that to string.","commit_id":"060baa4a03b634190f88e8b0325df51effb0908f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b51f6b9c7ddcd4df71b04c6b3ecbae60e658ae4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # NOTE(gibi): Notification payloads always reflect the data needed"},{"line_number":67,"context_line":"        # for every supported API microversion so we can safe to use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request._MAX_API_VERSION"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_b243706c","line":67,"updated":"2017-03-27 19:57:43.000000000","message":"s/we can safe to use/we can safely use/","commit_id":"bfdd087f881b0ad858b07e6f4e71375701f4f6a9"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7b51f6b9c7ddcd4df71b04c6b3ecbae60e658ae4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # for every supported API microversion so we can safe to use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request._MAX_API_VERSION"},{"line_number":71,"context_line":"        self.api.microversion \u003d max_version"},{"line_number":72,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_d52ede90","line":70,"updated":"2017-03-27 19:57:43.000000000","message":"femto-nit: might be good to make api_version_request._MAX_API_VERSION a \"public\" constant and remove the _ prefix now that it\u0027s used outside of the module.","commit_id":"bfdd087f881b0ad858b07e6f4e71375701f4f6a9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1c4d34282c737435d3f7b7714a44006dea50adbf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # for every supported API microversion so we can safely use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request.MAX_API_VERSION"},{"line_number":71,"context_line":"        self.api.microversion \u003d max_version"},{"line_number":72,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_127dfc1b","line":70,"updated":"2017-04-13 22:38:57.000000000","message":"Why not just hardcode to \u00272.latest\u0027 here? That would make this a lot simpler and a smaller change.","commit_id":"833524eb50c0bf265e45edc487b678c659d919ae"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"afba91cb6cddf533c84c54fc9a7b50c85c4c44de","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # for every supported API microversion so we can safely use the latest"},{"line_number":68,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":69,"context_line":"        # features too."},{"line_number":70,"context_line":"        max_version \u003d api_version_request.MAX_API_VERSION"},{"line_number":71,"context_line":"        self.api.microversion \u003d max_version"},{"line_number":72,"context_line":"        self.admin_api.microversion \u003d max_version"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_52f63d65","line":70,"in_reply_to":"7ffa3b31_127dfc1b","updated":"2017-04-20 16:15:19.000000000","message":"Good idea.\nActually it is just \u0027latest\u0027 what we need here. It took me a while to figure this out why \u00272.latest\u0027 doesn\u0027t work. :)","commit_id":"833524eb50c0bf265e45edc487b678c659d919ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1e6575b37ab89aa4feea2036cf4884ad71dd670","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        # NOTE(gibi): Notification payloads always reflect the data needed"},{"line_number":66,"context_line":"        # for every supported API microversion so we can safe to use the latest"},{"line_number":67,"context_line":"        # API version in the tests. This helps the test to use the new API"},{"line_number":68,"context_line":"        # features too."},{"line_number":69,"context_line":"        max_version \u003d \u0027latest\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ffa3b31_5ab3eb98","line":66,"range":{"start_line":66,"start_character":57,"end_line":66,"end_character":64},"updated":"2017-04-20 22:39:22.000000000","message":"safely","commit_id":"c8812b026dd0bb7f962d0ba15f5114d2faef26bd"}],"nova/tests/functional/notification_sample_tests/test_service_update.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b73f9ec489eb8ef44530c42de3978cdf3d1e8790","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d {\u0027host\u0027: \u0027host1\u0027,"},{"line_number":57,"context_line":"                \u0027binary\u0027: \u0027nova-compute\u0027,"},{"line_number":58,"context_line":"                \u0027forced_down\u0027: True}"},{"line_number":59,"context_line":"        self.admin_api.microversion \u003d \u00272.12\u0027"},{"line_number":60,"context_line":"        self.admin_api.api_put(\u0027os-services/force-down\u0027, body)"},{"line_number":61,"context_line":"        self._verify_notification(\u0027service-update\u0027,"},{"line_number":62,"context_line":"                                  replacements\u003d{\u0027forced_down\u0027: True,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ffa3b31_a6952389","side":"PARENT","line":59,"updated":"2017-04-21 14:24:07.000000000","message":"so we assume the behaviour is not changed in between 2.12 and the latest ? Fine by me.","commit_id":"6103ec7c113121866344cdca2fbbbf7b80dfa975"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f0f499e715e3a82bcc0df18c69076e364b4a8dca","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        body \u003d {\u0027host\u0027: \u0027host1\u0027,"},{"line_number":57,"context_line":"                \u0027binary\u0027: \u0027nova-compute\u0027,"},{"line_number":58,"context_line":"                \u0027forced_down\u0027: True}"},{"line_number":59,"context_line":"        self.admin_api.microversion \u003d \u00272.12\u0027"},{"line_number":60,"context_line":"        self.admin_api.api_put(\u0027os-services/force-down\u0027, body)"},{"line_number":61,"context_line":"        self._verify_notification(\u0027service-update\u0027,"},{"line_number":62,"context_line":"                                  replacements\u003d{\u0027forced_down\u0027: True,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ffa3b31_e610cb02","side":"PARENT","line":59,"in_reply_to":"7ffa3b31_a6952389","updated":"2017-04-21 14:28:26.000000000","message":"We need 2.12 to have force_down as an action available. As the test shows behavior does not changed after 2.12","commit_id":"6103ec7c113121866344cdca2fbbbf7b80dfa975"}]}