)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"965a602a3a60f91a90a25e399679966a28bbb5d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa458680_492407e3","updated":"2023-07-13 18:14:24.000000000","message":"this has been restored not because the code is nessisarly correct but because we discussed a while ago that the approch fo disabling post-copy when its paused is a valid one.\n\ntl;dr becuase the vm is paused it is not writing to memroy so there shoudl be no delete between postcopy enabeld or disabled in this case and we shoudl just allow the migration to proceed instead of leaving it fail","commit_id":"26dd49e3a13929f713817999d8db5217de349950"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"09e0587af8ff30fd13232374215dd08909945f18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e8d8e643_fb2ac067","updated":"2023-11-22 04:03:31.000000000","message":"Couple of random failures, one of which is a failure to shelve. Feels like https://review.opendev.org/c/openstack/tempest/+/901087/1/tempest/common/compute.py would make debugging those much easier...","commit_id":"495f39f49be5679c94c7b3bf44dfe9f0be7f292d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"74afa044f58fe449dbdf667703766dcb36a8cfe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fa7c01a3_af009e35","updated":"2023-12-18 14:13:09.000000000","message":"Looks good. I will make an attempt to verify this in https://github.com/openstack-k8s-operators/nova-operator/pull/621#issuecomment-1859848726 where I see this happening recently.","commit_id":"33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"da2b8a1168938de874bc525f71f0cee31b0869de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"80b340ab_0a8a2fca","updated":"2023-12-18 16:27:44.000000000","message":"Verified. This fix works for me in Antelope in the openstack-k8s-operators CI to live-migrate pause VMs with post-copy configured.","commit_id":"33fa92b6cb1dfeb88a4188c0e4e4ce51be1f7a4b"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"47e37fcd0d5bd0926d08d4a34f5d40766c1c4122","unresolved":false,"context_lines":[{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"},{"line_number":6077,"context_line":""},{"line_number":6078,"context_line":"            serial_listen_addr \u003d libvirt_migrate.serial_listen_addr("},{"line_number":6079,"context_line":"                migrate_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_cd9e5006","line":6076,"range":{"start_line":6076,"start_character":16,"end_line":6076,"end_character":63},"updated":"2017-03-10 23:07:56.000000000","message":"How about you do this in _handle_live_migration_post_copy?","commit_id":"21f874c94cd0c89b8fcac111aa8726d7c0f6b1fd"},{"author":{"_account_id":18339,"name":"Sivasathurappan Radhakrishnan","email":"siva.radhakrishnan@intel.com","username":"sivakrishnan"},"change_message_id":"e4f58d8097d601161a87c88048befe619499b956","unresolved":false,"context_lines":[{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"},{"line_number":6077,"context_line":""},{"line_number":6078,"context_line":"            serial_listen_addr \u003d libvirt_migrate.serial_listen_addr("},{"line_number":6079,"context_line":"                migrate_data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_1e315d5a","line":6076,"range":{"start_line":6076,"start_character":16,"end_line":6076,"end_character":63},"in_reply_to":"9a30ddce_cd9e5006","updated":"2017-03-13 04:43:35.000000000","message":"If we do it there, we are removing it for all live migration which might use post copy. This has to be done only for paused instance.","commit_id":"21f874c94cd0c89b8fcac111aa8726d7c0f6b1fd"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"cf91717f50576e2d3f6b41f0aeb6ce756a0cdaf6","unresolved":false,"context_lines":[{"line_number":6070,"context_line":"            # Note(siva_krishnan): live migrating paused instance fails"},{"line_number":6071,"context_line":"            # when VIR_MIGRATE_POSTCOPY flag is set. It is unset here"},{"line_number":6072,"context_line":"            # to permit live migration of paused instance."},{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_d8b61ffb","line":6073,"updated":"2017-04-04 08:07:44.000000000","message":"Did you check vm_states other than PAUSED, i.e. SUSPENDED?","commit_id":"26dd49e3a13929f713817999d8db5217de349950"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"739203b08cfa58166731ff27689d9adcdf3350c7","unresolved":false,"context_lines":[{"line_number":6070,"context_line":"            # Note(siva_krishnan): live migrating paused instance fails"},{"line_number":6071,"context_line":"            # when VIR_MIGRATE_POSTCOPY flag is set. It is unset here"},{"line_number":6072,"context_line":"            # to permit live migration of paused instance."},{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"}],"source_content_type":"text/x-python","patch_set":2,"id":"f2761671_6d5b05e5","line":6073,"in_reply_to":"dfeb2761_d8b61ffb","updated":"2023-11-21 21:06:05.000000000","message":"No, but on the basis that something is better than nothing, fixing the situation with PAUSED is a good start, and if someone reports an issue with SUSPENDED, we can address it then.","commit_id":"26dd49e3a13929f713817999d8db5217de349950"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"cf91717f50576e2d3f6b41f0aeb6ce756a0cdaf6","unresolved":false,"context_lines":[{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"},{"line_number":6077,"context_line":""},{"line_number":6078,"context_line":"            serial_listen_addr \u003d libvirt_migrate.serial_listen_addr("},{"line_number":6079,"context_line":"                migrate_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_18a247af","line":6076,"updated":"2017-04-04 08:07:44.000000000","message":"Log message describing migration flags change would be good here.","commit_id":"26dd49e3a13929f713817999d8db5217de349950"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"739203b08cfa58166731ff27689d9adcdf3350c7","unresolved":false,"context_lines":[{"line_number":6073,"context_line":"            if (instance.vm_state \u003d\u003d vm_states.PAUSED and"},{"line_number":6074,"context_line":"                CONF.libvirt.live_migration_permit_post_copy and"},{"line_number":6075,"context_line":"                self._is_post_copy_enabled(migration_flags)):"},{"line_number":6076,"context_line":"                migration_flags ^\u003d libvirt.VIR_MIGRATE_POSTCOPY"},{"line_number":6077,"context_line":""},{"line_number":6078,"context_line":"            serial_listen_addr \u003d libvirt_migrate.serial_listen_addr("},{"line_number":6079,"context_line":"                migrate_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"78c9a407_83da1355","line":6076,"in_reply_to":"dfeb2761_18a247af","updated":"2023-11-21 21:06:05.000000000","message":"Good idea, done.","commit_id":"26dd49e3a13929f713817999d8db5217de349950"}]}