)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"81fb6daa6666268ca00ec32da28d5e998fade69c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some services (such as telemetry) actually consume the notifications. So"},{"line_number":10,"context_line":"if one deploys a service that listens on the same queue as telemetry,"},{"line_number":11,"context_line":"there will be race-conditions with these services and one will not get"},{"line_number":12,"context_line":"the notifications that are expected at points."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To address this, one sets a different topic and consumes from there."},{"line_number":15,"context_line":"This is not possible with versioned notifications at the moment. And, as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_9970f041","line":12,"updated":"2017-03-13 15:58:55.000000000","message":"Does telemetry really consumes versioned_notifications topic today? I thought they just consume the legacy notifications. Just out of curiosity, do you have some reference to the telemetry code that actually consumes versioned_notifications?\n\nSearchlight is planning to consume the versioned_notifications https://blueprints.launchpad.net/searchlight/+spec/nova-versioned-notifications so the use case you described above is valid.","commit_id":"43e107e21516e049be09ec0f23f968a86efc6cc0"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"01142f3a0452992ef2b97e65622fe5cfabfdbebc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some services (such as telemetry) actually consume the notifications. So"},{"line_number":10,"context_line":"if one deploys a service that listens on the same queue as telemetry,"},{"line_number":11,"context_line":"there will be race-conditions with these services and one will not get"},{"line_number":12,"context_line":"the notifications that are expected at points."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To address this, one sets a different topic and consumes from there."},{"line_number":15,"context_line":"This is not possible with versioned notifications at the moment. And, as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a30ddce_6c61bcd2","line":12,"in_reply_to":"9a30ddce_9970f041","updated":"2017-03-13 16:06:44.000000000","message":"I\u0027m honestly not sure if they consume versioned notifications. However, I do know that they consume notifications (so they don\u0027t requeue them once they get them).\n\nWe have a service that uses notifications, and we used to just look at them and requeue them, but we noticed that if telemetry got them first, we wouldn\u0027t get them. And this is because once they get the notification they don\u0027t requeue. And not requeuing is fine, but to have applications that use notifications to coexist, we then need to have configurable topics. So we decided to start consuming (without requeuing) notifications as well, and rely on having an exclusive topic.","commit_id":"43e107e21516e049be09ec0f23f968a86efc6cc0"}],"nova/conf/notifications.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5875873b1e1b0a8ad6d36e733657629e310d8984","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\"\"\"),"},{"line_number":105,"context_line":"    cfg.ListOpt("},{"line_number":106,"context_line":"        \u0027versioned_notifications_topics\u0027,"},{"line_number":107,"context_line":"        default\u003d[\u0027versioned_notifications\u0027],"},{"line_number":108,"context_line":"        help\u003d\"\"\""},{"line_number":109,"context_line":"Specifies the topics for the versioned notifications issued by nova."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_64553fc5","line":107,"updated":"2017-03-14 17:35:44.000000000","message":"I\u0027m not sure why this is a ListOpt? Does a list of \u003e1 topic mean that the notification system will send versioned notification objects to multiple topic queues?\n\nIf so, it would be good to add to the description something like \"Nova will send a message containing a versioned notification payload to each topic queue in this list\".","commit_id":"5d8b70bbff4838f64746d3993c619369e6e43422"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"fa115d718f10c57fc53f0241af617f4c9097bbb8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\"\"\"),"},{"line_number":105,"context_line":"    cfg.ListOpt("},{"line_number":106,"context_line":"        \u0027versioned_notifications_topics\u0027,"},{"line_number":107,"context_line":"        default\u003d[\u0027versioned_notifications\u0027],"},{"line_number":108,"context_line":"        help\u003d\"\"\""},{"line_number":109,"context_line":"Specifies the topics for the versioned notifications issued by nova."},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_04d64bc5","line":107,"in_reply_to":"3a1ff146_64553fc5","updated":"2017-03-14 17:39:26.000000000","message":"that\u0027s correct. It will send it to several queues. I can add the extended description.","commit_id":"5d8b70bbff4838f64746d3993c619369e6e43422"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c62c87da739ca6b8eb517c4e11d999875a7f5bc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"http://docs.openstack.org/developer/nova/notifications.html"},{"line_number":104,"context_line":"\"\"\"),"},{"line_number":105,"context_line":"    cfg.ListOpt("},{"line_number":106,"context_line":"        \u0027versioned_notifications_topics\u0027,"},{"line_number":107,"context_line":"        default\u003d[\u0027versioned_notifications\u0027],"},{"line_number":108,"context_line":"        help\u003d\"\"\""},{"line_number":109,"context_line":"Specifies the topics for the versioned notifications issued by nova."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_ca515eda","line":106,"updated":"2017-03-20 00:14:13.000000000","message":"Should probably mention this in our docs on versioned notifications:\n\nhttps://docs.openstack.org/developer/nova/notifications.html","commit_id":"5bc5e8440e7354b78caea37e077509695067bff5"}],"nova/rpc.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5875873b1e1b0a8ad6d36e733657629e310d8984","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        NOTIFIER \u003d messaging.Notifier("},{"line_number":97,"context_line":"            NOTIFICATION_TRANSPORT,"},{"line_number":98,"context_line":"            serializer\u003dserializer,"},{"line_number":99,"context_line":"            topics\u003dconf.notifications.versioned_notifications_topics)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"def cleanup():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a1ff146_e4b3ef08","line":99,"updated":"2017-03-14 17:35:44.000000000","message":"hmm, I didn\u0027t know there were multiple topic queues that could be configured for notifications. Learn something new every day ... :)","commit_id":"5d8b70bbff4838f64746d3993c619369e6e43422"}]}