)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"361ecb86211069b40c57551491c1d52a5c84250c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"users who still need to limit to one v2 cell. If using the"},{"line_number":14,"context_line":"FilterScheduler, this is handled more efficiently. Care was taken here"},{"line_number":15,"context_line":"(at the potential expense of readability) to be as efficient as possible"},{"line_number":16,"context_line":"when considering the requested cell.the"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related to cells-aware-api"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a25e98e_0c3afbcd","line":16,"range":{"start_line":16,"start_character":36,"end_line":16,"end_character":39},"updated":"2017-03-13 18:52:00.000000000","message":"?","commit_id":"9bc506d37b65c4b34c28cb8984ad63ed03e77af5"}],"nova/scheduler/filters/same_cell_filter.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"361ecb86211069b40c57551491c1d52a5c84250c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            LOG.warning(_LW(\u0027Cell %(cell)s requested, but not found\u0027),"},{"line_number":41,"context_line":"                        {\u0027cell\u0027: cell_uuid})"},{"line_number":42,"context_line":"            return"},{"line_number":43,"context_line":"        self._hosts_by_cell[cell_uuid] \u003d ["},{"line_number":44,"context_line":"            hm.host for hm in objects.HostMappingList.get_by_cell_id("},{"line_number":45,"context_line":"                ctxt, cell.id)]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":48,"context_line":"        if (spec_obj and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a25e98e_4c0313b9","line":45,"range":{"start_line":43,"start_character":41,"end_line":45,"end_character":31},"updated":"2017-03-13 18:52:00.000000000","message":"I looks like this should be a set, more suited for lookups, rather than a linear search? (L71 and L84) I don\u0027t see that we need to iterate over the values here.","commit_id":"9bc506d37b65c4b34c28cb8984ad63ed03e77af5"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6333cd7291932dfe80562b5c112a6ad8bbc96ed7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            LOG.warning(_LW(\u0027Cell %(cell)s requested, but not found\u0027),"},{"line_number":41,"context_line":"                        {\u0027cell\u0027: cell_uuid})"},{"line_number":42,"context_line":"            return"},{"line_number":43,"context_line":"        self._hosts_by_cell[cell_uuid] \u003d ["},{"line_number":44,"context_line":"            hm.host for hm in objects.HostMappingList.get_by_cell_id("},{"line_number":45,"context_line":"                ctxt, cell.id)]"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":48,"context_line":"        if (spec_obj and"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a25e98e_7546d2c0","line":45,"range":{"start_line":43,"start_character":41,"end_line":45,"end_character":31},"in_reply_to":"7a25e98e_4c0313b9","updated":"2017-03-13 19:56:56.000000000","message":"Yep, good call.","commit_id":"9bc506d37b65c4b34c28cb8984ad63ed03e77af5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"323a61ecdc5de767140c160ec22b6df1b0e88065","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._hosts_by_cell \u003d {}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _get_host_mappings_for_cell(self, cell_uuid):"},{"line_number":35,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            cell \u003d objects.CellMapping.get_by_uuid(ctxt, cell_uuid)"},{"line_number":38,"context_line":"        except exception.CellMappingNotFound:"},{"line_number":39,"context_line":"            LOG.warning(_LW(\u0027Cell %(cell)s requested, but not found\u0027),"},{"line_number":40,"context_line":"                        {\u0027cell\u0027: cell_uuid})"},{"line_number":41,"context_line":"            return"},{"line_number":42,"context_line":"        self._hosts_by_cell[cell_uuid] \u003d set(["},{"line_number":43,"context_line":"            hm.host for hm in objects.HostMappingList.get_by_cell_id("},{"line_number":44,"context_line":"                ctxt, cell.id)])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def host_passes(self, host_state, spec_obj):"},{"line_number":47,"context_line":"        if (spec_obj and"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a22e58a_53ac87ed","line":44,"range":{"start_line":35,"start_character":7,"end_line":44,"end_character":32},"updated":"2017-03-14 11:51:27.000000000","message":"how about we build a same cache in the Cachingscheduler https://github.com/openstack/nova/blob/master/nova/scheduler/caching_scheduler.py#L75","commit_id":"ad166bbf90fb83db079f5dda9da8322f25adfd73"}],"releasenotes/notes/caching_scheduler_users_require_same_cell_filter-be0b4028834135a0.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"361ecb86211069b40c57551491c1d52a5c84250c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - Users of the CachingScheduler which wish to have multiple"},{"line_number":4,"context_line":"    cellsv2 cells will need to enable the SameCellFilter to"},{"line_number":5,"context_line":"    ensure that instance migrations limit movement to the same"},{"line_number":6,"context_line":"    cell. Users of the FilterScheduler do not need this as"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a25e98e_6c9c4f6a","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":39},"updated":"2017-03-13 18:52:00.000000000","message":"Suggestion: s/which/who/","commit_id":"9bc506d37b65c4b34c28cb8984ad63ed03e77af5"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"361ecb86211069b40c57551491c1d52a5c84250c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Users of the CachingScheduler which wish to have multiple"},{"line_number":4,"context_line":"    cellsv2 cells will need to enable the SameCellFilter to"},{"line_number":5,"context_line":"    ensure that instance migrations limit movement to the same"},{"line_number":6,"context_line":"    cell. Users of the FilterScheduler do not need this as"},{"line_number":7,"context_line":"    the restriction is handled in a more efficient way."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a25e98e_ac93a74e","line":7,"range":{"start_line":6,"start_character":56,"end_line":7,"end_character":55},"updated":"2017-03-13 18:52:00.000000000","message":"May want to have more words here on why FilterScheduler users don\u0027t need this, for example, \"as the restriction is handled in a more efficient way inside the FilterScheduler.\"\n\nI might be being too paranoid but I was thinking it might not be abundantly clear from this sentence that for FilterScheduler, the behavior is built-in, whereas for CachingScheduler, an additional filter is needed if migration limiting is wanted.","commit_id":"9bc506d37b65c4b34c28cb8984ad63ed03e77af5"}]}