)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"07683afb63794ed4320de3c214cef1c0e1ca4e28","unresolved":false,"context_lines":[{"line_number":1380,"context_line":"                                                   columns_to_join\u003d[])"},{"line_number":1381,"context_line":"        return [inst[\u0027uuid\u0027] for inst in db_instances]"},{"line_number":1382,"context_line":""},{"line_number":1383,"context_line":"    @base.remotable_classmethod"},{"line_number":1384,"context_line":"    def get_by_instance_mapping_list(cls, context, instance_mapping_list,"},{"line_number":1385,"context_line":"                                     expected_attrs\u003dNone):"},{"line_number":1386,"context_line":"        # Group instance mappings by cell"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_23c0617b","line":1383,"updated":"2017-04-25 17:01:28.000000000","message":"This shouldn\u0027t be remotable. It\u0027s not something that can (nor needs to) be called by computes in a cell because there will be no access to the api database from down there.\n\nAlso, I don\u0027t like the idea of this being a classmethod as it\u0027s not something that should or would be override-able. It should just be a module-level function, if it\u0027s in this file at all.","commit_id":"8cc04b5a82dfdb42df4127cb79a02fed65bfb153"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"07683afb63794ed4320de3c214cef1c0e1ca4e28","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"            cell_id \u003d im.cell_mapping.id"},{"line_number":1394,"context_line":"            instances_by_cell[cell_id].append(im.instance_uuid)"},{"line_number":1395,"context_line":"            if cell_id not in contexts_by_cell:"},{"line_number":1396,"context_line":"                contexts_by_cell[cell_id] \u003d context.for_cell(im.cell_mapping)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        # Fetch instances from each cell in batches"},{"line_number":1399,"context_line":"        instance_objs \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ff73747_a30fd1df","line":1396,"updated":"2017-04-25 17:01:28.000000000","message":"In the past we\u0027ve had one method on context that behaved like this (elevated) and it has been the bane of many people\u0027s existence for quite some time. I\u0027ve had a patch in my stash for quite a while to finish target_cell() to behave the way it was intended and I recently uncovered that as we got far enough down the stack. You could use it to collect the  context in much the same way.\n\nhttps://review.openstack.org/#/c/458634","commit_id":"8cc04b5a82dfdb42df4127cb79a02fed65bfb153"}]}