)]}'
{"nova/policies/aggregates.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af0730f11832be702deb7e40a722adf28e6d47f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action\u0027,"},{"line_number":32,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":"        ]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_6d6f76c5","line":31,"range":{"start_line":31,"start_character":61,"end_line":31,"end_character":62},"updated":"2017-03-21 01:38:48.000000000","message":"i think we need to add action name here like \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027","commit_id":"4c97bf9298ec23532599a6dfe529d3c79fdd4c9e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af0730f11832be702deb7e40a722adf28e6d47f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        \"Add a host to an aggregate.\","},{"line_number":39,"context_line":"        ["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action\u0027,"},{"line_number":42,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":43,"context_line":"            }"},{"line_number":44,"context_line":"        ]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_cd64eae6","line":41,"range":{"start_line":41,"start_character":61,"end_line":41,"end_character":62},"updated":"2017-03-21 01:38:48.000000000","message":"(add_host)\u0027","commit_id":"4c97bf9298ec23532599a6dfe529d3c79fdd4c9e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9af0730f11832be702deb7e40a722adf28e6d47f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \"Remove a host from an aggregate\","},{"line_number":62,"context_line":"        ["},{"line_number":63,"context_line":"            {"},{"line_number":64,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action\u0027,"},{"line_number":65,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        ]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_2d9c9ebf","line":64,"range":{"start_line":64,"start_character":60,"end_line":64,"end_character":62},"updated":"2017-03-21 01:38:48.000000000","message":"(remove_host)\u0027","commit_id":"4c97bf9298ec23532599a6dfe529d3c79fdd4c9e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"95013c944c221c8700aa432966edbeb39092f9d5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027,"},{"line_number":32,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":"        ]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_54fd8538","line":31,"range":{"start_line":31,"start_character":63,"end_line":31,"end_character":75},"updated":"2017-03-24 17:07:38.000000000","message":"It annoys me that these are underscore_separated while others are camelCase","commit_id":"e07438be33df46e6ad822887a2bf051d36849bb6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"950f060586c2b9fce54b1cfa8c91d931c8d1405f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027,"},{"line_number":32,"context_line":"                \u0027method\u0027: \u0027POST\u0027"},{"line_number":33,"context_line":"            }"},{"line_number":34,"context_line":"        ]),"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_7473e9e8","line":31,"range":{"start_line":31,"start_character":63,"end_line":31,"end_character":75},"in_reply_to":"ffe62b97_54fd8538","updated":"2017-03-24 17:08:00.000000000","message":"^ general observation - not something you can fix here, I know :)","commit_id":"e07438be33df46e6ad822887a2bf051d36849bb6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"95013c944c221c8700aa432966edbeb39092f9d5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    base.create_rule_default("},{"line_number":69,"context_line":"        POLICY_ROOT % \u0027update\u0027,"},{"line_number":70,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":71,"context_line":"        \"Update either or both the name and availability zone \\"},{"line_number":72,"context_line":"        for an aggregate\","},{"line_number":73,"context_line":"        ["},{"line_number":74,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":6,"id":"ffe62b97_f4c259e9","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":61},"updated":"2017-03-24 17:07:38.000000000","message":"this doesn\u0027t read right. How about\n\n   the name and/or availability zone","commit_id":"e07438be33df46e6ad822887a2bf051d36849bb6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2aab0838387effc9a6e4ae798aaebffc3a4b0441","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027set_metadata\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_8f870fb6","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":26},"updated":"2017-03-28 08:24:42.000000000","message":"Are you sure? That sounds like a PATCH operation","commit_id":"14dda6136922d953494e3988c38d30ad9fd58e60"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"71f72e1f24b0dd65faa99691007c703ed6e2c18b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027set_metadata\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_9554c054","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":26},"in_reply_to":"ffe62b97_8f870fb6","updated":"2017-03-28 09:06:37.000000000","message":"https://github.com/openstack/nova/blob/master/nova/objects/aggregate.py#L428\n\nyes...","commit_id":"14dda6136922d953494e3988c38d30ad9fd58e60"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1abb231f1573c6bd61e74c055b1c92500add2811","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    base.create_rule_default("},{"line_number":26,"context_line":"        POLICY_ROOT % \u0027set_metadata\u0027,"},{"line_number":27,"context_line":"        base.RULE_ADMIN_API,"},{"line_number":28,"context_line":"        \"Create or replace metadata for an aggregate\","},{"line_number":29,"context_line":"        ["},{"line_number":30,"context_line":"            {"},{"line_number":31,"context_line":"                \u0027path\u0027: \u0027/os-aggregates/{aggregate_id}/action (set_metadata)\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_a77437ff","line":28,"range":{"start_line":28,"start_character":16,"end_line":28,"end_character":26},"in_reply_to":"ffe62b97_9554c054","updated":"2017-03-28 09:21:23.000000000","message":"Ah, cheers","commit_id":"14dda6136922d953494e3988c38d30ad9fd58e60"}]}
