)]}'
{"nova/tests/unit/network/test_linux_net.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            self.assertEqual(expected, rule)"},{"line_number":407,"context_line":"            self.called \u003d True"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        with mock.patch.object(linux_net.iptables_manager.ipv4[\u0027nat\u0027],"},{"line_number":410,"context_line":"                               \u0027add_rule\u0027, side_effect\u003dverify_add_rule):"},{"line_number":411,"context_line":"            self.called \u003d False"},{"line_number":412,"context_line":"            linux_net.add_snat_rule(\u002710.0.0.0/24\u0027, is_external)"},{"line_number":413,"context_line":"            if expected:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_3fba00de","line":410,"range":{"start_line":409,"start_character":0,"end_line":410,"end_character":72},"updated":"2017-03-24 01:46:01.000000000","message":"can we use stub_out or decorator which is much better readable.","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    @mock.patch.object(fileutils, \u0027ensure_tree\u0027)"},{"line_number":442,"context_line":"    @mock.patch.object(os, \u0027chmod\u0027)"},{"line_number":443,"context_line":"    def test_update_dhcp_for_nw00(self, mock_chmod, mock_ensure_tree):"},{"line_number":444,"context_line":"        with mock.patch.object(self.driver, \u0027write_to_file\u0027) \\"},{"line_number":445,"context_line":"                as mock_write_to_file:"},{"line_number":446,"context_line":"            self.flags(use_single_default_gateway\u003dTrue)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"            self.driver.update_dhcp(self.context, \"eth0\", networks[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_1f6cdc34","line":445,"range":{"start_line":444,"start_character":0,"end_line":445,"end_character":38},"updated":"2017-03-24 01:46:01.000000000","message":"can we make this too as decorator","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":25050,"name":"Danfly","email":"910290847@qq.com","username":"Danfly"},"change_message_id":"def0429744e59d99966aedc49710dcf080e9b812","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    @mock.patch.object(fileutils, \u0027ensure_tree\u0027)"},{"line_number":442,"context_line":"    @mock.patch.object(os, \u0027chmod\u0027)"},{"line_number":443,"context_line":"    def test_update_dhcp_for_nw00(self, mock_chmod, mock_ensure_tree):"},{"line_number":444,"context_line":"        with mock.patch.object(self.driver, \u0027write_to_file\u0027) \\"},{"line_number":445,"context_line":"                as mock_write_to_file:"},{"line_number":446,"context_line":"            self.flags(use_single_default_gateway\u003dTrue)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"            self.driver.update_dhcp(self.context, \"eth0\", networks[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_52949444","line":445,"range":{"start_line":444,"start_character":0,"end_line":445,"end_character":38},"in_reply_to":"ffe62b97_1f6cdc34","updated":"2017-03-31 05:50:01.000000000","message":"thanks for your review.I tried, I write like this:\n@ mock.patch.object(self.driver, \u0027write_to_file\u0027) \nand this is an error. the \"self.driver\" depends on config file. Could you give me an example, thanks.","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":454,"context_line":"    @mock.patch.object(fileutils, \u0027ensure_tree\u0027)"},{"line_number":455,"context_line":"    @mock.patch.object(os, \u0027chmod\u0027)"},{"line_number":456,"context_line":"    def test_update_dhcp_for_nw01(self, mock_chmod, mock_ensure_tree):"},{"line_number":457,"context_line":"        with mock.patch.object(self.driver, \u0027write_to_file\u0027) \\"},{"line_number":458,"context_line":"                as mock_write_to_file:"},{"line_number":459,"context_line":"            self.flags(use_single_default_gateway\u003dTrue)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"            self.driver.update_dhcp(self.context, \"eth0\", networks[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_bf729010","line":458,"range":{"start_line":457,"start_character":0,"end_line":458,"end_character":38},"updated":"2017-03-24 01:46:01.000000000","message":"ditto","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":625,"context_line":"            self.assertEqual(\u0027FORWARD\u0027, chain)"},{"line_number":626,"context_line":"            self.assertIn(\u0027ACCEPT\u0027, rule)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        with mock.patch.object(utils, \u0027execute\u0027, fake_execute), \\"},{"line_number":629,"context_line":"                mock.patch.object(linux_net.iptables_manager.ipv4[\u0027filter\u0027],"},{"line_number":630,"context_line":"                                  \u0027add_rule\u0027, verify_add_rule):"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"            driver \u003d linux_net.LinuxBridgeInterfaceDriver()"},{"line_number":633,"context_line":"            driver.plug({\"bridge\": \"br100\", \"bridge_interface\": \"eth0\","}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_df4e74c0","line":630,"range":{"start_line":628,"start_character":0,"end_line":630,"end_character":63},"updated":"2017-03-24 01:46:01.000000000","message":"ditto, as decorator or self.stub_out","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        def fake_device_exists(*args, **kwargs):"},{"line_number":643,"context_line":"            return False"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"        with mock.patch.object(utils, \u0027execute\u0027, side_effect\u003dfake_execute), \\"},{"line_number":646,"context_line":"                mock.patch.object(linux_net, \u0027device_exists\u0027,"},{"line_number":647,"context_line":"                                  side_effect\u003dfake_device_exists):"},{"line_number":648,"context_line":"            driver \u003d linux_net.LinuxOVSInterfaceDriver()"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"            exc \u003d self.assertRaises(exception.OvsConfigurationFailure,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_1fda9ce8","line":647,"range":{"start_line":645,"start_character":0,"end_line":647,"end_character":66},"updated":"2017-03-24 01:46:01.000000000","message":"ditto","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"95ffbaa53a8b51aa3e9769b6c4268e305657c693","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        def test_ensure(vlan, bridge, interface, network, mac_address, mtu):"},{"line_number":671,"context_line":"            info[\u0027passed_interface\u0027] \u003d interface"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"        with mock.patch.object(linux_net.LinuxBridgeInterfaceDriver,"},{"line_number":674,"context_line":"                               \u0027ensure_vlan_bridge\u0027, side_effect\u003dtest_ensure):"},{"line_number":675,"context_line":"            network \u003d {"},{"line_number":676,"context_line":"                \"bridge\": \"br100\","},{"line_number":677,"context_line":"                \"bridge_interface\": \"base_interface\","}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_bfe05098","line":674,"range":{"start_line":673,"start_character":0,"end_line":674,"end_character":78},"updated":"2017-03-24 01:46:01.000000000","message":"ditto","commit_id":"4d18daeeec6f9b9bd9f3329eee24df01f4fae9b3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2cf19805bcfb310fdb105d8cc8e2f8ff1471f85","unresolved":false,"context_lines":[{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        info \u003d {}"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        @staticmethod"},{"line_number":720,"context_line":"        def test_ensure(bridge, interface, network, gateway):"},{"line_number":721,"context_line":"            info[\u0027passed_interface\u0027] \u003d interface"},{"line_number":722,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a4c0002c","side":"PARENT","line":719,"range":{"start_line":719,"start_character":8,"end_line":719,"end_character":21},"updated":"2017-05-19 14:33:45.000000000","message":"Yup, this can go because it\u0027s nested","commit_id":"0f29badb779df8367f0dec2f4f9880a221babaf1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2cf19805bcfb310fdb105d8cc8e2f8ff1471f85","unresolved":false,"context_lines":[{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        mock_execute.side_effect \u003d fake_execute"},{"line_number":750,"context_line":"        mock_add_dhcp_mangle_rule.side_effect \u003d fake_add_dhcp_mangle_rule"},{"line_number":751,"context_line":"        mock_chmod.side_effect \u003d lambda *a, **kw: None"},{"line_number":752,"context_line":"        mock_write_to_file.side_effect \u003d lambda * a, ** kw: None"},{"line_number":753,"context_line":"        mock_dnsmasq_pid_for.side_effect \u003d lambda *a, **kw: None"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e4cb9847","line":751,"range":{"start_line":751,"start_character":33,"end_line":751,"end_character":54},"updated":"2017-05-19 14:33:45.000000000","message":"I don\u0027t think you need this, or any of the below","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53d5f8d087fa0336082172e7465d4632ada3ece8","unresolved":false,"context_lines":[{"line_number":748,"context_line":""},{"line_number":749,"context_line":"        mock_execute.side_effect \u003d fake_execute"},{"line_number":750,"context_line":"        mock_add_dhcp_mangle_rule.side_effect \u003d fake_add_dhcp_mangle_rule"},{"line_number":751,"context_line":"        mock_chmod.side_effect \u003d lambda *a, **kw: None"},{"line_number":752,"context_line":"        mock_write_to_file.side_effect \u003d lambda * a, ** kw: None"},{"line_number":753,"context_line":"        mock_dnsmasq_pid_for.side_effect \u003d lambda *a, **kw: None"},{"line_number":754,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_30c23087","line":751,"range":{"start_line":751,"start_character":33,"end_line":751,"end_character":54},"in_reply_to":"ff0f0b1f_e4cb9847","updated":"2017-05-29 09:37:05.000000000","message":"Done","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2cf19805bcfb310fdb105d8cc8e2f8ff1471f85","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1044,"context_line":"        manager.iptables_apply_deferred \u003d False"},{"line_number":1045,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1046,"context_line":"            manager._apply()"},{"line_number":1047,"context_line":"            empty_ret \u003d manager.apply()"},{"line_number":1048,"context_line":"            self.assertIsNone(empty_ret)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a44a40a9","line":1046,"range":{"start_line":1046,"start_character":12,"end_line":1046,"end_character":28},"updated":"2017-05-19 14:33:45.000000000","message":"What you actually want to do here is check if this function was called.\n\n    with mock.patch.object(manager, \u0027_apply\u0027) as mock_apply:\n        manager.apply.assert_called_once()","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53d5f8d087fa0336082172e7465d4632ada3ece8","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1044,"context_line":"        manager.iptables_apply_deferred \u003d False"},{"line_number":1045,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1046,"context_line":"            manager._apply()"},{"line_number":1047,"context_line":"            empty_ret \u003d manager.apply()"},{"line_number":1048,"context_line":"            self.assertIsNone(empty_ret)"},{"line_number":1049,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_50736481","line":1046,"range":{"start_line":1046,"start_character":12,"end_line":1046,"end_character":28},"in_reply_to":"ff0f0b1f_a44a40a9","updated":"2017-05-29 09:37:05.000000000","message":"Done","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2cf19805bcfb310fdb105d8cc8e2f8ff1471f85","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1052,"context_line":"        manager.iptables_apply_deferred \u003d True"},{"line_number":1053,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1054,"context_line":"            manager.apply()"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"    def test_deferred_unset_apply_ran(self):"},{"line_number":1057,"context_line":"        manager \u003d linux_net.IptablesManager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_64cae81a","line":1054,"range":{"start_line":1054,"start_character":12,"end_line":1054,"end_character":27},"updated":"2017-05-19 14:33:45.000000000","message":"Ditto, but \"not_called\"","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53d5f8d087fa0336082172e7465d4632ada3ece8","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1052,"context_line":"        manager.iptables_apply_deferred \u003d True"},{"line_number":1053,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1054,"context_line":"            manager.apply()"},{"line_number":1055,"context_line":""},{"line_number":1056,"context_line":"    def test_deferred_unset_apply_ran(self):"},{"line_number":1057,"context_line":"        manager \u003d linux_net.IptablesManager()"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_3070f072","line":1054,"range":{"start_line":1054,"start_character":12,"end_line":1054,"end_character":27},"in_reply_to":"ff0f0b1f_64cae81a","updated":"2017-05-29 09:37:05.000000000","message":"Done","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f2cf19805bcfb310fdb105d8cc8e2f8ff1471f85","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1058,"context_line":"        manager.iptables_apply_deferred \u003d True"},{"line_number":1059,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1060,"context_line":"            manager._apply()"},{"line_number":1061,"context_line":"            manager.defer_apply_off()"},{"line_number":1062,"context_line":"            self.assertFalse(manager.iptables_apply_deferred)"},{"line_number":1063,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_c4e414af","line":1060,"range":{"start_line":1060,"start_character":11,"end_line":1060,"end_character":28},"updated":"2017-05-19 14:33:45.000000000","message":"ditto","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53d5f8d087fa0336082172e7465d4632ada3ece8","unresolved":false,"context_lines":[{"line_number":1057,"context_line":"        manager \u003d linux_net.IptablesManager()"},{"line_number":1058,"context_line":"        manager.iptables_apply_deferred \u003d True"},{"line_number":1059,"context_line":"        with mock.patch.object(manager, \u0027_apply\u0027):"},{"line_number":1060,"context_line":"            manager._apply()"},{"line_number":1061,"context_line":"            manager.defer_apply_off()"},{"line_number":1062,"context_line":"            self.assertFalse(manager.iptables_apply_deferred)"},{"line_number":1063,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_106dec97","line":1060,"range":{"start_line":1060,"start_character":11,"end_line":1060,"end_character":28},"in_reply_to":"ff0f0b1f_c4e414af","updated":"2017-05-29 09:37:05.000000000","message":"Done","commit_id":"8e8b67cf2e9de804e28946dc901f9ef4457695cc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":407,"context_line":"            self.assertEqual(expected, rule)"},{"line_number":408,"context_line":"            self.called \u003d True"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        mock_add_rule.side_effect \u003d verify_add_rule"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"        self.called \u003d False"},{"line_number":413,"context_line":"        linux_net.add_snat_rule(\u002710.0.0.0/24\u0027, is_external)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bb9df35a","line":410,"range":{"start_line":410,"start_character":8,"end_line":410,"end_character":21},"updated":"2017-05-30 00:21:56.000000000","message":"need assert call check for this mock","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            self.assertEqual(\u0027FORWARD\u0027, chain)"},{"line_number":629,"context_line":"            self.assertIn(\u0027ACCEPT\u0027, rule)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"        mock_execute.side_effect \u003d fake_execute"},{"line_number":632,"context_line":"        mock_add_rule.side_effect \u003d verify_add_rule"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        driver \u003d linux_net.LinuxBridgeInterfaceDriver()"},{"line_number":635,"context_line":"        driver.plug({\"bridge\": \"br100\", \"bridge_interface\": \"eth0\","}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_1bb85fc6","line":632,"range":{"start_line":631,"start_character":8,"end_line":632,"end_character":21},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":647,"context_line":"        def fake_device_exists(*args, **kwargs):"},{"line_number":648,"context_line":"            return False"},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"        mock_execute.side_effect \u003d fake_execute"},{"line_number":651,"context_line":"        mock_device_exists.side_effect \u003d fake_device_exists"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        driver \u003d linux_net.LinuxOVSInterfaceDriver()"},{"line_number":654,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_dbb1c7e3","line":651,"range":{"start_line":650,"start_character":8,"end_line":651,"end_character":26},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":677,"context_line":"        def test_ensure(vlan, bridge, interface, network, mac_address, mtu):"},{"line_number":678,"context_line":"            info[\u0027passed_interface\u0027] \u003d interface"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"        mock_ensure_vlan_bridge.side_effect \u003d test_ensure"},{"line_number":681,"context_line":""},{"line_number":682,"context_line":"        network \u003d {"},{"line_number":683,"context_line":"                \"bridge\": \"br100\","}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bbb613d9","line":680,"range":{"start_line":680,"start_character":8,"end_line":680,"end_character":31},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        def test_ensure(bridge, interface, network, gateway):"},{"line_number":708,"context_line":"            info[\u0027passed_interface\u0027] \u003d interface"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        mock_ensure_bridge.side_effect \u003d test_ensure"},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"        network \u003d {"},{"line_number":713,"context_line":"                \"bridge\": \"br100\","}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_9bcb4f52","line":710,"range":{"start_line":710,"start_character":8,"end_line":710,"end_character":26},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":725,"context_line":"    @mock.patch(\u0027os.chmod\u0027)"},{"line_number":726,"context_line":"    @mock.patch.object(linux_net, \u0027_add_dhcp_mangle_rule\u0027)"},{"line_number":727,"context_line":"    @mock.patch.object(linux_net, \u0027_execute\u0027)"},{"line_number":728,"context_line":"    def _test_dnsmasq_execute(self, mock_execute, mock_add_dhcp_mangle_rule,"},{"line_number":729,"context_line":"                              mock_chmod, mock_write_to_file,"},{"line_number":730,"context_line":"                              mock_dnsmasq_pid_for, extra_expected\u003dNone):"},{"line_number":731,"context_line":"        network_ref \u003d {\u0027id\u0027: \u0027fake\u0027,"},{"line_number":732,"context_line":"                       \u0027label\u0027: \u0027fake\u0027,"},{"line_number":733,"context_line":"                       \u0027gateway\u0027: \u002710.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_3bc20335","line":730,"range":{"start_line":728,"start_character":36,"end_line":730,"end_character":50},"updated":"2017-05-30 00:21:56.000000000","message":"ditto, assert call check needed","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":902,"context_line":"            if args[0] \u003d\u003d \u0027sysctl\u0027:"},{"line_number":903,"context_line":"                return \u00271\\n\u0027, \u0027\u0027"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        mock_execute.side_effect \u003d fake_execute"},{"line_number":906,"context_line":""},{"line_number":907,"context_line":"        network \u003d {\u0027dhcp_server\u0027: \u0027192.168.1.1\u0027,"},{"line_number":908,"context_line":"                   \u0027cidr\u0027: \u0027192.168.1.0/24\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_dbe667e9","line":905,"range":{"start_line":905,"start_character":8,"end_line":905,"end_character":20},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":1021,"context_line":""},{"line_number":1022,"context_line":"    @mock.patch.object(linux_net, \u0027ensure_ebtables_rules\u0027)"},{"line_number":1023,"context_line":"    @mock.patch.object(linux_net.iptables_manager, \u0027apply\u0027)"},{"line_number":1024,"context_line":"    def test_ensure_floating_no_duplicate_forwards(self, mock_apply,"},{"line_number":1025,"context_line":"                                                   mock_ensure_ebtables_rules):"},{"line_number":1026,"context_line":"        ln \u003d linux_net"},{"line_number":1027,"context_line":""},{"line_number":1028,"context_line":"        mock_apply.side_effect \u003d lambda: None"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_9bd0eff9","line":1025,"range":{"start_line":1024,"start_character":57,"end_line":1025,"end_character":77},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"            self.assertEqual(\u0027INPUT\u0027, chain)"},{"line_number":1066,"context_line":"            self.assertEqual(expected, rule)"},{"line_number":1067,"context_line":""},{"line_number":1068,"context_line":"        mock_add_rule.side_effect \u003d verify_add_rule"},{"line_number":1069,"context_line":"        linux_net.metadata_accept()"},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"    @mock.patch.object(linux_net.iptables_manager.ipv6[\u0027filter\u0027], \u0027add_rule\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_bb04d37c","line":1068,"range":{"start_line":1068,"start_character":8,"end_line":1068,"end_character":21},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"            self.assertEqual(\u0027INPUT\u0027, chain)"},{"line_number":1075,"context_line":"            self.assertEqual(expected, rule)"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"        mock_add_rule.side_effect \u003d verify_add_rule"},{"line_number":1078,"context_line":"        linux_net.metadata_accept()"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"    def test_metadata_accept(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_fb0a4b88","line":1077,"range":{"start_line":1077,"start_character":8,"end_line":1077,"end_character":21},"updated":"2017-05-30 00:21:56.000000000","message":"ditto","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e66261559bf7b3cc3eb8ccaa2dc72f80ff4bdec","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"            self.assertEqual(\u0027PREROUTING\u0027, chain)"},{"line_number":1112,"context_line":"            self.assertEqual(expected, rule)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        mock_add_rule.side_effect \u003d verify_add_rule"},{"line_number":1115,"context_line":"        linux_net.metadata_forward()"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def test_metadata_forward(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_5bda5717","line":1114,"range":{"start_line":1114,"start_character":8,"end_line":1114,"end_character":21},"updated":"2017-05-30 00:21:56.000000000","message":"this too","commit_id":"bf270f21fd267fc273eda21088488cd4dcecfd1f"}]}