)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cff78f70c000edf05d73b239ed928fb5c58a4b38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements: blueprint custom-emulator-path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I4da91efa7373a4009adf240ba312e6ff431d2895"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixing flake8 errors"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I59ad3afb5fae44c05a23fc838a5b0f422985748b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_1abdd4b6","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":52},"updated":"2017-04-06 17:46:47.000000000","message":"This is against the basic part of gerrit way.\nEvery patch should contain a single Change-Id, not multiple.\nThe gerrit identifies the patch based on this id when updating(changing) patches.","commit_id":"93abcc92fc3586306050f580031007b36a2a6cb0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tadas Ustinavičius \u003ctadas@ring.lt\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-07 17:34:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding unit test for the patch"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I59ad3afb5fae44c05a23fc838a5b0f422985748b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bff0334d_dc439a6b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2017-04-10 09:30:50.000000000","message":"This doesn\u0027t describe the feature - are you sure you didn\u0027t mess this up by mistake? You can fix this like so:\n\n    git review -d 445558  # 445558 is the gerrit ID from the address bar\n    # make your file changes\n    git commit --amend -a  # make your changes to the commit message\n    git review -fy  # submit changes\n\nYou may also wish to rebase the patch before submitting it (the last step). I\u0027ll leave that to you to figure out :)\n\nAlso note that the Change-Id line is important - this is what Gerrit uses to figure out if a patch is the same or not. You need to keep this","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e852c5d2fe1843eff7aaefe23419b58d14455889","unresolved":false,"context_lines":[{"line_number":7,"context_line":"OpenStack lacks ability to define custom path to emulator. Nova will always"},{"line_number":8,"context_line":"use the default path defined by libvirt. This makes impossible to use custom"},{"line_number":9,"context_line":"built qemu emulators in non-default system paths. This patch solves this"},{"line_number":10,"context_line":"problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I59ad3afb5fae44c05a23fc838a5b0f422985748b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bff0334d_9c498b32","line":10,"updated":"2017-04-10 12:33:44.000000000","message":"Your commit message formatting seems off -- your entire message is part of the summary line, which is usually limited to 50 characters or so, followed by the commit message body, which should be line-wrapped around 72 lines.\n\nA handy reference: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ef9329efc31c6b3356cdbc786decba95e54cdada"}],"nova/conf/libvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[{"line_number":568,"context_line":"\"\"\"),"},{"line_number":569,"context_line":"    cfg.StrOpt(\u0027emulator_path\u0027,"},{"line_number":570,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":571,"context_line":"               help\u003d\u0027Change default path to emulator\u0027),"},{"line_number":572,"context_line":"]"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"libvirt_imagebackend_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_dc9cba0f","line":571,"range":{"start_line":571,"start_character":20,"end_line":571,"end_character":53},"updated":"2017-04-10 09:30:50.000000000","message":"You should greatly expand upon this. Use the information you provided in the release note to explain *why* a user would want to set this. Something like:\n\n    The default path to emulator.\n\n    If using a custom QEMU emulator, ...","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"e852c5d2fe1843eff7aaefe23419b58d14455889","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                    \u0027If using a custom QEMU emulator, set this option\u0027"},{"line_number":573,"context_line":"                    \u0027to direct path of QEMU binary you want to use.\u0027"},{"line_number":574,"context_line":"                    \u0027This option will ommit default emulator found in\u0027"},{"line_number":575,"context_line":"                    \u0027PATH environment variable.\u0027),"},{"line_number":576,"context_line":"]"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"libvirt_imagebackend_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_5c29c398","line":575,"updated":"2017-04-10 12:33:44.000000000","message":"Nit: Maybe s/ommit/ignore the/ ?\n\nIn context of Nova, there are cases where a new QEMU requires a new libvirt for it to be useful, so users will get to keep the broken pieces if they\u0027re using a custom QEMU built from Git, and a libvirt from 4 years ago.  \n\nWe should add some verbiage around this, because of the following:\n\n[Thanks to Eric Blake, a libvirt \u0026 QEMU upstream developer for confirming the below.]\n\nIn general, libvirt supports:\n\n  - old QEMU, old libvirt (insofar as those versions \n    are supported)\n  - old QEMU, new libvirt\n  - new QEMU, new libvirt\n\nBut upstream libvirt does NOT give any guarantees of supporting:\n  \n  - new QEMU, and old libvirt (although this works \n    most of the times, it should not be taken \n    for granted)\n\nIt is worth noting that this config option (\u0027emulator_path\u0027) will also have consequences (e.g. voiding support warranty) in downstream context, where Nova is tested with specific versions of QEMU (and libvirt).  So if something breaks, here too, users get to keep the pieces.\n\nSo Nova should not give a mistaken impression that any custom QEMU will be supported with any arbitrary libvirt version.\n\nIMHO, this is worth spelling this out in the release notes.\n\nAlso useful reading:\n\nhttps://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix#QEMU_min_version_change_policy","commit_id":"ef9329efc31c6b3356cdbc786decba95e54cdada"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bff0334d_7cd92ef1","line":3275,"updated":"2017-04-10 09:30:50.000000000","message":"remove this extra whitespace","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"}],"releasenotes/notes/bp-custom-emulator-path-c5981a3507d696d7.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    OpenStack lacks ability to define custom path to emulator. Nova will always"},{"line_number":4,"context_line":"    use the default path defined by libvirt. This makes impossible to use custom"},{"line_number":5,"context_line":"    built qemu emulators in non-default system paths. This patch solves this"},{"line_number":6,"context_line":"    problem."},{"line_number":7,"context_line":"features:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Additional option is added to nova.conf [libvirt] section:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_1c16a2a9","line":6,"range":{"start_line":2,"start_character":0,"end_line":6,"end_character":12},"updated":"2017-04-10 09:30:50.000000000","message":"We reserve the \u0027prelude\u0027 section for release information. You shouldn\u0027t populate this. Instead, this information should belong in the commit message","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    problem."},{"line_number":7,"context_line":"features:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Additional option is added to nova.conf [libvirt] section:"},{"line_number":10,"context_line":"    [libvirt]"},{"line_number":11,"context_line":"    emulator_path \u003d /path/to/qemu"},{"line_number":12,"context_line":"    If configured, nova will omit libvirt\u0027s default emulator path and use custom one."},{"line_number":13,"context_line":"fixes:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Fixes flake8 errors"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_dc595a8e","line":12,"range":{"start_line":9,"start_character":4,"end_line":12,"end_character":85},"updated":"2017-04-10 09:30:50.000000000","message":"Let\u0027s try formatting this as reStructuredText so it\u0027ll output correctly. How about:\n\n    The `[libvirt] emulator_path` option is added. This allows users\n    to define a custom emulator path. This can be helpful for users\n    of custom-built QEMU emulators.","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"df2612811fc5ba85ef5656c1fdbcabd97091ef61","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    [libvirt]"},{"line_number":11,"context_line":"    emulator_path \u003d /path/to/qemu"},{"line_number":12,"context_line":"    If configured, nova will omit libvirt\u0027s default emulator path and use custom one."},{"line_number":13,"context_line":"fixes:"},{"line_number":14,"context_line":"  - |"},{"line_number":15,"context_line":"    Fixes flake8 errors"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_bc10d6a9","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":23},"updated":"2017-04-10 09:30:50.000000000","message":"This section is for bugfixes only. You can remove this.","commit_id":"b82416d24ed65cb6e1b6d9029fc9a4e32e22e42f"}]}