)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19590,"name":"Sarafraj Singh","email":"Sarafraj.Singh@intel.com","username":"sarafrajsingh"},"change_message_id":"93a39702b8b621dd17d3313e6616cc9399e9ed60","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch changes the opt type of configuration options to"},{"line_number":16,"context_line":"use this more relevant opt type - HostAddressOpt."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: John Garbutt \u003cjohn.garbutt@rackspace.com\u003e"},{"line_number":19,"context_line":"Change-Id: I6116b4cc3deef4b9fad9383ea3e6a570a8becead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dfeb2761_bfba3c07","line":17,"updated":"2017-04-03 14:47:02.000000000","message":"nit: missing link to bp \"centralize-config-options-pike\"","commit_id":"128c75054bac5d31ba7a7ea0ebcb9a27aa12100d"}],"nova/conf/spice.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f2e8610d5fc22bf99d94a5f4cdf0a269caca9d3","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CLI_OPTS \u003d ["},{"line_number":34,"context_line":"    cfg.HostAddressOpt(\u0027html5proxy_host\u0027,"},{"line_number":35,"context_line":"                       default\u003d\u00270.0.0.0\u0027,"},{"line_number":36,"context_line":"                       help\u003d\"\"\""},{"line_number":37,"context_line":"IP address or a hostname on which the ``nova-spicehtml5proxy`` service"},{"line_number":38,"context_line":"listens for incoming requests."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_b045d845","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":23},"updated":"2017-04-03 10:28:24.000000000","message":"unrelated change","commit_id":"85f7715e17de8634754c087f92579c13732e8e9f"}],"nova/conf/xenserver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a155694996c80c6c919e1b8388fd015e22f5934","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        default\u003d\u0027/var/run/sr-mount\u0027,"},{"line_number":465,"context_line":"        help\u003d\u0027Base path to the storage repository on the XenServer host.\u0027),"},{"line_number":466,"context_line":"    cfg.HostAddressOpt(\u0027target_host\u0027,"},{"line_number":467,"context_line":"                       help\u003d\"\"\""},{"line_number":468,"context_line":"The iSCSI Target Host."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"This option represents the hostname or ip of the iSCSI Target."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_1ffb6948","line":467,"range":{"start_line":467,"start_character":8,"end_line":467,"end_character":23},"updated":"2017-03-21 14:59:15.000000000","message":"nit: you don\u0027t need to change this line","commit_id":"16ac1cf850b8921f6159b80d07b4e914aad79185"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9f2e8610d5fc22bf99d94a5f4cdf0a269caca9d3","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        default\u003d\u0027/var/run/sr-mount\u0027,"},{"line_number":465,"context_line":"        help\u003d\u0027Base path to the storage repository on the XenServer host.\u0027),"},{"line_number":466,"context_line":"    cfg.HostAddressOpt(\u0027target_host\u0027,"},{"line_number":467,"context_line":"                       help\u003d\"\"\""},{"line_number":468,"context_line":"The iSCSI Target Host."},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"This option represents the hostname or ip of the iSCSI Target."}],"source_content_type":"text/x-python","patch_set":5,"id":"dfeb2761_106a44b2","line":467,"range":{"start_line":467,"start_character":0,"end_line":467,"end_character":31},"updated":"2017-04-03 10:28:24.000000000","message":"unrelated change","commit_id":"85f7715e17de8634754c087f92579c13732e8e9f"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34847510370a68181bcd43a5c879e427cdb7e5a1","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        vm_util.vm_refs_cache_reset()"},{"line_number":202,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dFalse)"},{"line_number":203,"context_line":"        self.flags(cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":204,"context_line":"                   host_ip\u003d\u0027test_url\u0027,"},{"line_number":205,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":206,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":207,"context_line":"                   api_retry_count\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8b8e11ce","side":"PARENT","line":204,"range":{"start_line":204,"start_character":28,"end_line":204,"end_character":36},"updated":"2017-03-27 12:06:31.000000000","message":"fakehostname would work just fine I assume?","commit_id":"47d90a3028438ee8ddc541a807dee3915dcf62aa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"0bd5002e41fbaf42d1a942965180b2fcb836d923","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        vm_util.vm_refs_cache_reset()"},{"line_number":202,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dFalse)"},{"line_number":203,"context_line":"        self.flags(cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":204,"context_line":"                   host_ip\u003d\u0027test_url\u0027,"},{"line_number":205,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":206,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":207,"context_line":"                   api_retry_count\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_dde82ee3","side":"PARENT","line":204,"range":{"start_line":204,"start_character":28,"end_line":204,"end_character":36},"in_reply_to":"ffe62b97_3d671ac0","updated":"2017-03-28 09:47:43.000000000","message":"Yes, I replaced it with a valid hostname, I believe its the \"_\" that is failing here.\n\nIf \"fakehostname\" is not valid in oslo as a hostname, we have a really bad regression on our hands here.","commit_id":"47d90a3028438ee8ddc541a807dee3915dcf62aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ce8a76deece0b78a35385d915f2e883c1fc46274","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        vm_util.vm_refs_cache_reset()"},{"line_number":202,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, is_admin\u003dFalse)"},{"line_number":203,"context_line":"        self.flags(cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":204,"context_line":"                   host_ip\u003d\u0027test_url\u0027,"},{"line_number":205,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":206,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":207,"context_line":"                   api_retry_count\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_3d671ac0","side":"PARENT","line":204,"range":{"start_line":204,"start_character":28,"end_line":204,"end_character":36},"in_reply_to":"ffe62b97_8b8e11ce","updated":"2017-03-28 09:45:45.000000000","message":"Something tells me there\u0027s a dependency in oslo.config that\u0027s used to validate that hostnames are valid. I haven\u0027t gone to check this though","commit_id":"47d90a3028438ee8ddc541a807dee3915dcf62aa"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7a155694996c80c6c919e1b8388fd015e22f5934","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"host_ip \u003d netutils.get_my_ipv4()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"DEFAULT_FLAVORS \u003d ["},{"line_number":74,"context_line":"    {\u0027memory_mb\u0027: 512, \u0027root_gb\u0027: 1, \u0027deleted_at\u0027: None, \u0027name\u0027: \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_3f7d85b1","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":32},"updated":"2017-03-21 14:59:15.000000000","message":"couldn\u0027t you hardcode this to avoid any of the underlying dependencies","commit_id":"16ac1cf850b8921f6159b80d07b4e914aad79185"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"34847510370a68181bcd43a5c879e427cdb7e5a1","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"host_ip \u003d netutils.get_my_ipv4()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"DEFAULT_FLAVORS \u003d ["},{"line_number":74,"context_line":"    {\u0027memory_mb\u0027: 512, \u0027root_gb\u0027: 1, \u0027deleted_at\u0027: None, \u0027name\u0027: \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_8be05198","line":71,"range":{"start_line":71,"start_character":10,"end_line":71,"end_character":32},"in_reply_to":"1a1ced50_3f7d85b1","updated":"2017-03-27 12:06:31.000000000","message":"+1","commit_id":"16ac1cf850b8921f6159b80d07b4e914aad79185"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8322f1ff6fb490db69987f943f3a4a67d15a575f","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"host_ip \u003d \u0027testhostname\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"DEFAULT_FLAVORS \u003d ["},{"line_number":73,"context_line":"    {\u0027memory_mb\u0027: 512, \u0027root_gb\u0027: 1, \u0027deleted_at\u0027: None, \u0027name\u0027: \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_7deb62db","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":7},"updated":"2017-03-28 09:47:29.000000000","message":"This should probably not be called host_ip. It\u0027s also insignificant enough to warrant hardcoding below","commit_id":"33e699b9d0502c6d270c77732c46e51f904d5861"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"171bbf576b18bd5d833c81b491ef594472781523","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"host_ip \u003d \u0027testhostname\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"DEFAULT_FLAVORS \u003d ["},{"line_number":73,"context_line":"    {\u0027memory_mb\u0027: 512, \u0027root_gb\u0027: 1, \u0027deleted_at\u0027: None, \u0027name\u0027: \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_bd7c4a1f","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":7},"in_reply_to":"ffe62b97_7deb62db","updated":"2017-03-28 09:48:33.000000000","message":"yeah, its just a minimal inline edit from the previous patch, happy for some to fix that up.","commit_id":"33e699b9d0502c6d270c77732c46e51f904d5861"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b36898cdd8d4ba0939d2c532ac9acd09ccb9e040","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"host_ip \u003d \u0027testhostname\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"DEFAULT_FLAVORS \u003d ["},{"line_number":73,"context_line":"    {\u0027memory_mb\u0027: 512, \u0027root_gb\u0027: 1, \u0027deleted_at\u0027: None, \u0027name\u0027: \u0027m1.tiny\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_316b65f1","line":70,"range":{"start_line":70,"start_character":0,"end_line":70,"end_character":7},"updated":"2017-03-30 05:17:33.000000000","message":"It is a constant, it should be uppercase letters.","commit_id":"3d39f39dc3fad5eeabfbeff3c421c08609992cdb"}]}