)]}'
{"id":"openstack%2Fnova~4459","triplet_id":"openstack%2Fnova~master~Ifc45abf4cd9f50f732ba4a4b68c0a6242a6c9710","project":"openstack/nova","branch":"master","topic":"bug/934534","hashtags":[],"change_id":"Ifc45abf4cd9f50f732ba4a4b68c0a6242a6c9710","subject":"Include launch_index when creating instances.","status":"MERGED","created":"2012-02-23 19:44:00.000000000","updated":"2012-02-29 16:55:36.000000000","submitted":"2012-02-29 16:55:34.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fc341bc09383796b34b952b2913ec3cc65b16521","_number":4459,"virtual_id_number":4459,"owner":{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"date":"2012-02-29 16:44:48.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-02-29 16:55:34.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"date":"2012-02-24 01:42:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},{"value":0,"date":"2012-02-28 03:40:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-02-28 04:04:18.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"date":"2012-02-29 16:44:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2012-02-28 03:46:13.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-02-29 16:55:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"date":"2012-02-24 01:35:24.000000000","_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2012-02-28 04:04:18.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"date":"2012-02-29 16:44:48.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"date":"2012-02-28 03:46:13.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-02-23 21:57:17.000000000","updated_by":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"reviewer":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"state":"REVIEWER"},{"updated":"2012-02-28 03:40:49.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-02-28 03:46:13.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-02-28 04:04:18.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2012-02-29 16:44:48.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2012-02-29 16:55:34.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"07cbbf8858eb95f095ed9e6b33a61a8f5cae0a62","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-02-23 21:41:37.000000000","message":"Patch Set 1:\n\nSmokeStack Results (patch set 1):\n\tUnit Failed:Nova tests failed.  http://smokestack.openstack.org/?go\u003d/jobs/13446\n\tLibvirt(Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/13444\n\tXenServer(Ubuntu 11.04) Success: http://smokestack.openstack.org/?go\u003d/jobs/13454","accounts_in_message":[],"_revision_number":1},{"id":"f91675d78868704dddc30beba488f1536be54f7d","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-02-23 21:51:15.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t submit this\n\nLooks good, but you need to add yourself to Authors. :)  Unit tests fail until you\u0027re in there.","accounts_in_message":[],"_revision_number":1},{"id":"44bc1257ae511cecd0e5b7aafc361c5905f4c29f","author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"date":"2012-02-23 21:57:17.000000000","message":"Patch Set 1:\n\nWhat is the launch index used for anyway?\n\nIs it just informational for, let\u0027s say, a progress indicator?","accounts_in_message":[],"_revision_number":1},{"id":"90e4ee3731e6fd44866800e262ae43892f7a42a0","author":{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},"date":"2012-02-24 01:35:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0fb1348b8ac1424ca8454e0c32927b0c8fc1fc45","author":{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},"date":"2012-02-24 01:42:08.000000000","message":"Patch Set 2:\n\nOops, added myself to Authors - can you guess I\u0027m new ;)\n\nThe launch_index gets saved to the database record for the instance. It is then used as the value for ami-launch-index in the metadata service. If you start a single instance, ami-launch-index should be zero. If you start multiple instances (in a single API call) then the ami-launch-index will number from 0 to n-1. The same userdata gets passed to each instance, the ami-launch-index lets each instance look at a different part of the userdata.\n\nSee http://docs.amazonwebservices.com/AmazonEC2/dg/2007-01-03/AESDG-chapter-instancedata.html for more details.","accounts_in_message":[],"_revision_number":2},{"id":"d7207a9080260c56d155000ace2951e2b3def255","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-02-28 03:40:49.000000000","message":"Patch Set 2:\n\nSmokeStack Results (patch set 2):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/13490\n\tLibvirt(Fedora 16) Success: http://smokestack.openstack.org/?go\u003d/jobs/13489\n\tXenServer(Ubuntu 11.04) Success: http://smokestack.openstack.org/?go\u003d/jobs/13797","accounts_in_message":[],"_revision_number":2},{"id":"9188dbdc91080836bac085634b83c1a41cfc701e","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-02-28 03:46:13.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c60de58de6c87f7f64360c2ffb345f51c130ad5a","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2012-02-28 04:04:18.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"217f029f93bfe629accd4c3055f726a3e36d6860","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2012-02-29 16:44:48.000000000","message":"Patch Set 2: Approved\n\nLooks like jenkins missed the approval; re-approving.","accounts_in_message":[],"_revision_number":2},{"id":"e0eead550344ccab67b97e5453045def2119f8b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-29 16:55:34.000000000","message":"Patch Set 2: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/1944/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/1614/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/1243/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2995/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e2793a8d09acc9118b68bc025471268274898cfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-29 16:55:36.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e3530a06c4d84e101e07bbe22075a0e2b3a72086","revisions":{"9f35cffab66d65e2c303cee4e4fbaaae4809e433":{"kind":"REWORK","_number":1,"created":"2012-02-23 19:44:00.000000000","uploader":{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},"ref":"refs/changes/59/4459/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/4459/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/4459/1"}}},"commit":{"parents":[{"commit":"b9ead4d26b69ead8d101c2729bae28a51f864eed","subject":"Merge \"Fix quantum get_all_networks() signature (lp#936797)\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b9ead4d26b69ead8d101c2729bae28a51f864eed"}]}],"author":{"name":"Mike Milner","email":"mike.milner@canonical.com","date":"2012-02-23 19:13:51.000000000","tz":-240},"committer":{"name":"Mike Milner","email":"mike.milner@canonical.com","date":"2012-02-23 19:43:47.000000000","tz":-240},"subject":"Include launch_index when creating instances.","message":"Include launch_index when creating instances.\n\nFixes bug 934534.\n\nIf launch_index is not specified it defaults to 1. This is incorrect for the\nsingle instance case (should be 0) and doesn\u0027t correctly handle multi-instance\nstarts.\n\nThis branch changes the default launch_index to 0 (to handle the single\ninstance case) and adds the launch_index in the schedulers for multi-instance\nstarts.\n\nChange-Id: Ifc45abf4cd9f50f732ba4a4b68c0a6242a6c9710\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f35cffab66d65e2c303cee4e4fbaaae4809e433"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9f35cffab66d65e2c303cee4e4fbaaae4809e433"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b9ead4d26b69ead8d101c2729bae28a51f864eed","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"e3530a06c4d84e101e07bbe22075a0e2b3a72086":{"kind":"REWORK","_number":2,"created":"2012-02-24 01:35:24.000000000","uploader":{"_account_id":2660,"name":"Mike Milner","email":"milner@blissisland.ca","username":"milner"},"ref":"refs/changes/59/4459/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/59/4459/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/59/4459/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/59/4459/2"}}},"commit":{"parents":[{"commit":"7c4e31e639c0a96778fb7a158f6e5106bc3f2abb","subject":"Merge \"Fix vnc docs: novaclient now supports vnc consoles.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c4e31e639c0a96778fb7a158f6e5106bc3f2abb"}]}],"author":{"name":"Mike Milner","email":"mike.milner@canonical.com","date":"2012-02-23 19:13:51.000000000","tz":-240},"committer":{"name":"Mike Milner","email":"mike.milner@canonical.com","date":"2012-02-24 01:34:52.000000000","tz":-240},"subject":"Include launch_index when creating instances.","message":"Include launch_index when creating instances.\n\nFixes bug 934534.\n\nThe launch_index column in the database is used as the ami-launch-index value\nprovided by the metadata service.\n\nIf launch_index is not specified it defaults to 1. This is incorrect for the\nsingle instance case (should be 0) and doesn\u0027t correctly handle multi-instance\nstarts.\n\nThis branch changes the default launch_index to 0 (to handle the single\ninstance case) and adds the launch_index in the schedulers for multi-instance\nstarts.\n\nChange-Id: Ifc45abf4cd9f50f732ba4a4b68c0a6242a6c9710\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3530a06c4d84e101e07bbe22075a0e2b3a72086"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e3530a06c4d84e101e07bbe22075a0e2b3a72086"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"7c4e31e639c0a96778fb7a158f6e5106bc3f2abb","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}