)]}'
{"nova/virt/libvirt/utils.py":[{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"7216d5f2dc767458b72b1582b87935c4d354c578","unresolved":false,"context_lines":[{"line_number":387,"context_line":"        disk_path \u003d source.get(\u0027dir\u0027)"},{"line_number":388,"context_line":"        disk_path \u003d disk_path[0:disk_path.rfind(\u0027rootfs\u0027)]"},{"line_number":389,"context_line":"        disk_path \u003d os.path.join(disk_path, \u0027disk\u0027)"},{"line_number":390,"context_line":"    elif (is_vz_container(CONF.libvirt.virt_type, os_type)):"},{"line_number":391,"context_line":"        filesystem \u003d domain.find(\u0027devices/filesystem\u0027)"},{"line_number":392,"context_line":"        driver \u003d filesystem.find(\u0027driver\u0027)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_fec6b416","line":390,"range":{"start_line":390,"start_character":26,"end_line":390,"end_character":48},"updated":"2017-05-30 09:04:10.000000000","message":"I would hide this argument and used it directly from is_vz_container function. Like is_vz_container(os_type)","commit_id":"47539c05722a42f8a788e11464d0851ff1816f08"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"7216d5f2dc767458b72b1582b87935c4d354c578","unresolved":false,"context_lines":[{"line_number":545,"context_line":"    return re.match(r\"^[\\w\\-\\.:]+$\", hostname)"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"def is_vz_container(virt_type, vm_mode):"},{"line_number":549,"context_line":"    if (virt_type \u003d\u003d \"parallels\" and"},{"line_number":550,"context_line":"        vm_mode \u003d\u003d obj_fields.VMMode.EXE):"},{"line_number":551,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_1ee1689b","line":548,"range":{"start_line":548,"start_character":20,"end_line":548,"end_character":29},"updated":"2017-05-30 09:04:10.000000000","message":"According to said above virt_type is unnecessary","commit_id":"47539c05722a42f8a788e11464d0851ff1816f08"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"7216d5f2dc767458b72b1582b87935c4d354c578","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"def is_vz_container(virt_type, vm_mode):"},{"line_number":549,"context_line":"    if (virt_type \u003d\u003d \"parallels\" and"},{"line_number":550,"context_line":"        vm_mode \u003d\u003d obj_fields.VMMode.EXE):"},{"line_number":551,"context_line":"        return True"},{"line_number":552,"context_line":"    return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3efd4c3a","line":549,"range":{"start_line":549,"start_character":8,"end_line":549,"end_character":16},"updated":"2017-05-30 09:04:10.000000000","message":"And here using CONF.libvirt.virt_type would be better","commit_id":"47539c05722a42f8a788e11464d0851ff1816f08"}]}