)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c1016e20f83b1f660a408eb6340e73574ca83da8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"boot, previously this would always be some default value, which"},{"line_number":12,"context_line":"isn\u0027t as useful to the things that need to consider what AZ the"},{"line_number":13,"context_line":"instance is actually in (without doing all the aggregate math to"},{"line_number":14,"context_line":"determine it on the fly)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related to blueprint cells-aware-api"},{"line_number":17,"context_line":"Change-Id: I8d426f2635232ffc4b510548a905794ca88d7f99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1ff146_35498160","line":14,"updated":"2017-03-15 16:49:09.000000000","message":"to be clear, if the operator modified the config option named default_schedule_zone to some existing AZ, then instance.az will be set to that AZ. This is not a problem for that patch given we force instance.az to match what will be the host AZ which will be the same if AZFilter is enabled.\n\nIf the operator left that config opt to the default value of None, then instance.az will be different and reflect the \"real\" AZ (instead of None), which is far better for us wanting to not make an upcall.","commit_id":"5e211a12cf74265cdd4a2a394601adb842f44711"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eecb3d20348edc0c2cde08a4e0c35bd575edb931","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instance is actually in. In the case where no AZ was requested at"},{"line_number":11,"context_line":"boot, previously this would always be some default value, which"},{"line_number":12,"context_line":"isn\u0027t as useful to the things that need to consider what AZ the"},{"line_number":13,"context_line":"instance is actually in (without doing all the aggregate math to"},{"line_number":14,"context_line":"determine it on the fly)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Related to blueprint cells-aware-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a1ced50_0f4936d0","line":13,"range":{"start_line":13,"start_character":47,"end_line":13,"end_character":61},"updated":"2017-03-22 21:31:53.000000000","message":"heh.","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"}],"doc/notification_samples/instance-create-end.json":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"75cf8971f58fd698ca61795eebcefd73cc67cd57","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"},{"line_number":9,"context_line":"            \"display_name\":\"some-server\","}],"source_content_type":"application/json","patch_set":5,"id":"1a1ced50_050e4934","line":6,"updated":"2017-03-16 20:54:10.000000000","message":"so, that\u0027s far better to provide the AZ in the notification, given it\u0027s the real one...","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5a565832c64c8771b67189748976686c78d267c8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"payload\":{"},{"line_number":4,"context_line":"        \"nova_object.data\":{"},{"line_number":5,"context_line":"            \"architecture\":\"x86_64\","},{"line_number":6,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":7,"context_line":"            \"created_at\":\"2012-10-29T13:42:11Z\","},{"line_number":8,"context_line":"            \"deleted_at\":null,"},{"line_number":9,"context_line":"            \"display_name\":\"some-server\","}],"source_content_type":"application/json","patch_set":5,"id":"1a1ced50_8da08e92","line":6,"in_reply_to":"1a1ced50_050e4934","updated":"2017-03-17 10:06:08.000000000","message":"+1","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"}],"nova/conductor/manager.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eecb3d20348edc0c2cde08a4e0c35bd575edb931","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                    (host, node) \u003d (host_state[\u0027host\u0027], host_state[\u0027nodename\u0027])"},{"line_number":707,"context_line":"                    instance.availability_zone \u003d ("},{"line_number":708,"context_line":"                        availability_zones.get_host_availability_zone("},{"line_number":709,"context_line":"                            context, host))"},{"line_number":710,"context_line":"                    self.compute_rpcapi.unshelve_instance("},{"line_number":711,"context_line":"                            context, instance, host, image\u003dimage,"},{"line_number":712,"context_line":"                            filter_properties\u003dfilter_properties, node\u003dnode)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_cf055e46","line":709,"updated":"2017-03-22 21:31:53.000000000","message":"Does the unshelve operation save() the instance?\n\nIt does: https://github.com/openstack/nova/blob/3ee4b0cf0ebd6db5118d0fcdc6f9f76e2fcd521b/nova/compute/manager.py#L4457","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eecb3d20348edc0c2cde08a4e0c35bd575edb931","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":"            instance.availability_zone \u003d ("},{"line_number":803,"context_line":"                availability_zones.get_host_availability_zone("},{"line_number":804,"context_line":"                    context, host))"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"            self.compute_rpcapi.rebuild_instance(context,"},{"line_number":807,"context_line":"                    instance\u003dinstance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_8f9e0605","line":804,"updated":"2017-03-22 21:31:53.000000000","message":"does rebuild_instance() save() the instance?\n\nIt does:\n\nhttps://github.com/openstack/nova/blob/3ee4b0cf0ebd6db5118d0fcdc6f9f76e2fcd521b/nova/compute/manager.py#L2785","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"}],"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c1016e20f83b1f660a408eb6340e73574ca83da8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            self.context, self.instance.uuid, image,"},{"line_number":53,"context_line":"            self.flavor, self.instance.numa_topology,"},{"line_number":54,"context_line":"            self.instance.pci_requests, legacy_props, None,"},{"line_number":55,"context_line":"            self.instance.availability_zone)"},{"line_number":56,"context_line":"        # NOTE(sbauza): Force_hosts/nodes needs to be reset"},{"line_number":57,"context_line":"        # if we want to make sure that the next destination"},{"line_number":58,"context_line":"        # is not forced to be the original host"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1ff146_f548c92f","line":55,"updated":"2017-03-15 16:49:09.000000000","message":"TBH, that will restrict move operations to stay within the same AZ the instance was originally boot in - even if the instance was having no AZ -, but I think it\u0027s a reasonable modification.\n\nAnyway, I\u0027m planning to fix that call and replace it by getting the original Spec object which will contain the original value of instance.az.","commit_id":"5e211a12cf74265cdd4a2a394601adb842f44711"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eecb3d20348edc0c2cde08a4e0c35bd575edb931","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # rpc fake driver."},{"line_number":79,"context_line":"        legacy_spec \u003d jsonutils.loads(jsonutils.dumps(legacy_spec))"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        self.compute_rpcapi.prep_resize("},{"line_number":82,"context_line":"            self.context, self.instance, legacy_spec[\u0027image\u0027],"},{"line_number":83,"context_line":"            self.flavor, host, self.reservations,"},{"line_number":84,"context_line":"            request_spec\u003dlegacy_spec, filter_properties\u003dlegacy_props,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_6a2c5899","line":81,"updated":"2017-03-22 21:31:53.000000000","message":"Does prep_resize() call instance.save()?\n\nIt does: https://github.com/openstack/nova/blob/3ee4b0cf0ebd6db5118d0fcdc6f9f76e2fcd521b/nova/compute/manager.py#L3746","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"eecb3d20348edc0c2cde08a4e0c35bd575edb931","unresolved":false,"context_lines":[{"line_number":2310,"context_line":"                ) as (inst1_save, inst2_save, from_primitives,"},{"line_number":2311,"context_line":"                        select_destinations,"},{"line_number":2312,"context_line":"                        build_and_run_instance):"},{"line_number":2313,"context_line":""},{"line_number":2314,"context_line":"            # build_instances() is a cast, we need to wait for it to complete"},{"line_number":2315,"context_line":"            self.useFixture(cast_as_call.CastAsCall(self.stubs))"},{"line_number":2316,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_2a2fc088","line":2313,"updated":"2017-03-22 21:31:53.000000000","message":"Might have been good to check that all the _mock_save objects were actually called (to save the AZ information on the instance)..","commit_id":"9df4cee3c5bde63f13970387f29e566bcb19104e"}]}