)]}'
{"nova/tests/functional/compute/test_resource_tracker.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45edb7adda6b5d0b24aa8a499eeed7014bed6f7b","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    @mock.patch(\u0027nova.objects.compute_node.ComputeNode.save\u0027)"},{"line_number":333,"context_line":"    @mock.patch(\u0027keystoneauth1.session.Session.get_endpoint\u0027,"},{"line_number":334,"context_line":"                return_value\u003d\u0027http://localhost/placement\u0027)"},{"line_number":335,"context_line":"    def test_compute_node_comes_online_no_instances(self, mock_ep, mock_cn):"},{"line_number":336,"context_line":"        with interceptor.RequestsInterceptor(app\u003dself.app, url\u003dself.url):"},{"line_number":337,"context_line":"            # Verify no existing ResourceProviders"},{"line_number":338,"context_line":"            rps \u003d self.placement_get_rps()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_95af5e93","line":335,"updated":"2017-03-20 22:18:48.000000000","message":"This one is nice from being short, but is not all that clear in what it is doing. I think this has more to do with the resource tracker than this test. That\u0027s going to be the case throughout all of these ...","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b07296a541cdfeb2fa39c63e3d64520f6e01d6ae","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    @mock.patch(\u0027nova.objects.compute_node.ComputeNode.save\u0027)"},{"line_number":333,"context_line":"    @mock.patch(\u0027keystoneauth1.session.Session.get_endpoint\u0027,"},{"line_number":334,"context_line":"                return_value\u003d\u0027http://localhost/placement\u0027)"},{"line_number":335,"context_line":"    def test_compute_node_comes_online_no_instances(self, mock_ep, mock_cn):"},{"line_number":336,"context_line":"        with interceptor.RequestsInterceptor(app\u003dself.app, url\u003dself.url):"},{"line_number":337,"context_line":"            # Verify no existing ResourceProviders"},{"line_number":338,"context_line":"            rps \u003d self.placement_get_rps()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_5696c696","line":335,"in_reply_to":"1a1ced50_95af5e93","updated":"2017-03-30 14:47:41.000000000","message":"What if I named it \"test_that_when_a_compute_node_that_contains_no_instances_comes_online_that_the_proper_resource_provider_record_is_created_but_no_allocation_records_are_created\"?\n\nWould that make it clearer? :)","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45edb7adda6b5d0b24aa8a499eeed7014bed6f7b","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                \u0027numa_topology\u0027: None,"},{"line_number":370,"context_line":"                \u0027resource_class\u0027: None,  # Act like admin hasn\u0027t set yet..."},{"line_number":371,"context_line":"            }"},{"line_number":372,"context_line":"            self.driver_mock.get_inventory.return_value \u003d {"},{"line_number":373,"context_line":"                VCPU: {"},{"line_number":374,"context_line":"                    \u0027total\u0027: cn[\"vcpus\"],"},{"line_number":375,"context_line":"                    \u0027reserved\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_b5a45aa6","line":372,"updated":"2017-03-20 22:18:48.000000000","message":"Is there a FakeVirtDriver or something like that can do this for us? (All 3 of these driver_mock calls)","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b07296a541cdfeb2fa39c63e3d64520f6e01d6ae","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                \u0027numa_topology\u0027: None,"},{"line_number":370,"context_line":"                \u0027resource_class\u0027: None,  # Act like admin hasn\u0027t set yet..."},{"line_number":371,"context_line":"            }"},{"line_number":372,"context_line":"            self.driver_mock.get_inventory.return_value \u003d {"},{"line_number":373,"context_line":"                VCPU: {"},{"line_number":374,"context_line":"                    \u0027total\u0027: cn[\"vcpus\"],"},{"line_number":375,"context_line":"                    \u0027reserved\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_96b0cedf","line":372,"in_reply_to":"1a1ced50_b5a45aa6","updated":"2017-03-30 14:47:41.000000000","message":"If it turns out that tests make the same calls for the mock values, we can refactor them out, but for now I think making them visible in the method itself lends some clarity to the test.","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45edb7adda6b5d0b24aa8a499eeed7014bed6f7b","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            with self.rt.instance_claim(self.ctx, instance, nodename):"},{"line_number":419,"context_line":"                pass"},{"line_number":420,"context_line":"            allocs \u003d self.placement_get_allocations_by_rp(rp_uuid)"},{"line_number":421,"context_line":"            rsrcs \u003d allocs.get(instance.uuid, {}).get(\"resources\", {})"},{"line_number":422,"context_line":"            flv \u003d instance.flavor"},{"line_number":423,"context_line":"            self.assertNotEqual({}, rsrcs)"},{"line_number":424,"context_line":"            self.assertEqual(rsrcs[\"VCPU\"], flv.vcpus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_95ebdeaf","line":421,"updated":"2017-03-20 22:18:48.000000000","message":"is the abbr nec?","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b07296a541cdfeb2fa39c63e3d64520f6e01d6ae","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            with self.rt.instance_claim(self.ctx, instance, nodename):"},{"line_number":419,"context_line":"                pass"},{"line_number":420,"context_line":"            allocs \u003d self.placement_get_allocations_by_rp(rp_uuid)"},{"line_number":421,"context_line":"            rsrcs \u003d allocs.get(instance.uuid, {}).get(\"resources\", {})"},{"line_number":422,"context_line":"            flv \u003d instance.flavor"},{"line_number":423,"context_line":"            self.assertNotEqual({}, rsrcs)"},{"line_number":424,"context_line":"            self.assertEqual(rsrcs[\"VCPU\"], flv.vcpus)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_16c4be3f","line":421,"in_reply_to":"1a1ced50_95ebdeaf","updated":"2017-03-30 14:47:41.000000000","message":"ys","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"45edb7adda6b5d0b24aa8a499eeed7014bed6f7b","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                pass"},{"line_number":420,"context_line":"            allocs \u003d self.placement_get_allocations_by_rp(rp_uuid)"},{"line_number":421,"context_line":"            rsrcs \u003d allocs.get(instance.uuid, {}).get(\"resources\", {})"},{"line_number":422,"context_line":"            flv \u003d instance.flavor"},{"line_number":423,"context_line":"            self.assertNotEqual({}, rsrcs)"},{"line_number":424,"context_line":"            self.assertEqual(rsrcs[\"VCPU\"], flv.vcpus)"},{"line_number":425,"context_line":"            self.assertEqual(rsrcs[\"MEMORY_MB\"], flv.memory_mb)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a1ced50_f5dc1214","line":422,"updated":"2017-03-20 22:18:48.000000000","message":"dit?","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b07296a541cdfeb2fa39c63e3d64520f6e01d6ae","unresolved":false,"context_lines":[{"line_number":419,"context_line":"                pass"},{"line_number":420,"context_line":"            allocs \u003d self.placement_get_allocations_by_rp(rp_uuid)"},{"line_number":421,"context_line":"            rsrcs \u003d allocs.get(instance.uuid, {}).get(\"resources\", {})"},{"line_number":422,"context_line":"            flv \u003d instance.flavor"},{"line_number":423,"context_line":"            self.assertNotEqual({}, rsrcs)"},{"line_number":424,"context_line":"            self.assertEqual(rsrcs[\"VCPU\"], flv.vcpus)"},{"line_number":425,"context_line":"            self.assertEqual(rsrcs[\"MEMORY_MB\"], flv.memory_mb)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffe62b97_96e56edf","line":422,"in_reply_to":"1a1ced50_f5dc1214","updated":"2017-03-30 14:47:41.000000000","message":"y","commit_id":"758026f21e586c712c43b223d0fb41b1009b1ed3"}]}