)]}'
{"nova/tests/functional/regressions/test_bug_1671648.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"545dd7832fd6d1eede1d3cd71070fbe0aef8ef0d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        # nodename \"fake-mini\". The host passed to start_service controls the"},{"line_number":78,"context_line":"        # \"host\" attribute and set_nodes() sets the \"nodename\" attribute."},{"line_number":79,"context_line":"        # We set_nodes() to make host and nodename the same for each compute."},{"line_number":80,"context_line":"        fake.set_nodes([\u0027host1\u0027])"},{"line_number":81,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host1\u0027)"},{"line_number":82,"context_line":"        fake.set_nodes([\u0027host2\u0027])"},{"line_number":83,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_762fb1a1","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":22},"updated":"2017-03-16 23:19:02.000000000","message":"I think using this might be messing up global state. Another test that uses this failed in the gate:\n\nhttp://logs.openstack.org/85/446685/2/gate/gate-nova-tox-functional-py35-ubuntu-xenial/058c588/console.html#_2017-03-16_21_44_01_717711\n\nMaybe we need to use the REQUIRES_LOCKING attribute in these tests?","commit_id":"4adc9a3a9065f331b729b43ad2cf7ba24ebcda63"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"692fb7dcde4aead1c386d72a820294af83d63dea","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        # nodename \"fake-mini\". The host passed to start_service controls the"},{"line_number":78,"context_line":"        # \"host\" attribute and set_nodes() sets the \"nodename\" attribute."},{"line_number":79,"context_line":"        # We set_nodes() to make host and nodename the same for each compute."},{"line_number":80,"context_line":"        fake.set_nodes([\u0027host1\u0027])"},{"line_number":81,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host1\u0027)"},{"line_number":82,"context_line":"        fake.set_nodes([\u0027host2\u0027])"},{"line_number":83,"context_line":"        self.start_service(\u0027compute\u0027, host\u003d\u0027host2\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_96034d0f","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":22},"in_reply_to":"1a1ced50_762fb1a1","updated":"2017-03-16 23:20:51.000000000","message":"Yeah this is failing because it\u0027s messing up global state. You need to use fake.restore_nodes in a cleanup run.","commit_id":"4adc9a3a9065f331b729b43ad2cf7ba24ebcda63"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"18c2ee86ab1e3b83ebfae55f81c17d5c304aa4d4","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Assert that the host is not the failed host."},{"line_number":148,"context_line":"        self.assertNotEqual(self.failed_host,"},{"line_number":149,"context_line":"                            server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Assert that we retried."},{"line_number":152,"context_line":"        self.assertEqual(2, self.attempts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_cf03700c","line":149,"range":{"start_line":149,"start_character":28,"end_line":149,"end_character":59},"updated":"2017-03-16 19:41:26.000000000","message":"In my opinion the api-ref descriptions for host, hypervisor_hostname, and hostId are terrible and we should clean those up. I don\u0027t know if there is a security risk in explaining what the fields actually mean, but they seem terrible.","commit_id":"4adc9a3a9065f331b729b43ad2cf7ba24ebcda63"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"61a5a682b1635a974d713a5a10075f708fd8377c","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Assert that the host is not the failed host."},{"line_number":148,"context_line":"        self.assertNotEqual(self.failed_host,"},{"line_number":149,"context_line":"                            server[\u0027OS-EXT-SRV-ATTR:host\u0027])"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # Assert that we retried."},{"line_number":152,"context_line":"        self.assertEqual(2, self.attempts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_6f6c3c9d","line":149,"range":{"start_line":149,"start_character":28,"end_line":149,"end_character":59},"in_reply_to":"1a1ced50_cf03700c","updated":"2017-03-16 19:50:05.000000000","message":"https://bugs.launchpad.net/nova/+bug/1673593","commit_id":"4adc9a3a9065f331b729b43ad2cf7ba24ebcda63"}]}
